From patchwork Wed Feb 10 16:00:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corneliu ZUZU X-Patchwork-Id: 8273141 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4D3659F1C1 for ; Wed, 10 Feb 2016 16:03:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 31C89203A4 for ; Wed, 10 Feb 2016 16:03:57 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49574202B8 for ; Wed, 10 Feb 2016 16:03:55 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aTXCT-0001xT-Pe; Wed, 10 Feb 2016 16:01:05 +0000 Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aTXCR-0001xL-FG for xen-devel@lists.xen.org; Wed, 10 Feb 2016 16:01:03 +0000 Received: from [85.158.143.35] by server-2.bemta-4.messagelabs.com id B9/5E-08977-EBE5BB65; Wed, 10 Feb 2016 16:01:02 +0000 X-Env-Sender: czuzu@bitdefender.com X-Msg-Ref: server-4.tower-21.messagelabs.com!1455120061!15012987!1 X-Originating-IP: [91.199.104.161] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 56073 invoked from network); 10 Feb 2016 16:01:02 -0000 Received: from mx01.buh.bitdefender.com (HELO mx01.buh.bitdefender.com) (91.199.104.161) by server-4.tower-21.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 10 Feb 2016 16:01:02 -0000 Comment: DomainKeys? See http://domainkeys.sourceforge.net/ DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=Evy5UZF/7ap++XdTrYHlfyUVsCZcYR1chIL6a0xCbSafqxxXZsLqDl8sx0l1oit/k2ZtdZJLSKgO82BIzJccYuj2ISRb0s3yjzJgxdJzaizQHhjucr3i+p9MxGrh91ttn2W/wbBFwGxCRM7ETvO0nF5Nr68wwHgzBkjV546gN7KWH3dCo06gd5kLghwTldlN2kLL58sTCdHILTd8cb9zKsLSac2ABH06+fjfBjGxCQvyWfz9q0SmKVdjJ065v7oUMXnKdBUDOCCN3RjDj0FqKgMxJTMnXkbV03eomcNr8vTwRO3qusIr3fVzxbimV4OlcdrQLPrkzUOvhb9wxJ7Hbg==; h=Received:Received:Received:Received:Received:From:To:Cc:Subject:Date:Message-Id:X-Mailer:In-Reply-To:References:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp; DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bitdefender.com; h=from:to :cc:subject:date:message-id:in-reply-to:references; s=default; bh=omvaY6UFl8+I/cwtm9Tf+ideX8M=; b=I40W2Btz8T49QDrAzzpPNffh1aiL Pe99AjTUNObOQ1Hf8Ignb2QYo/wG78acZ9PnGDWi7KvLynPR1uFSh7hGyTwU3Ym9 SSJkty5qEyPagvsC5zxPlMFbDGy8dN2T2BSoNFa3CXynqx/wHtP+8A0/J30EfBu+ Bnu7QbQnyi15yM0mOfti7J5JdscMoCW6j+gg025/hPMSlTeeFGthCTjd+jfgCLGU I2haJftxSOEgvpl3OfojoFoTkncYwVyXm1knQzjCPTIrm9uUetZMInip5TSKLg+f pFqjJ59fvrDuOpgjxJgZ/1aQr8WsKvhEAJgbefsvZ0a6+0ENjEeA7scesA== Received: (qmail 20416 invoked from network); 10 Feb 2016 18:01:01 +0200 Received: from unknown (HELO mx-sr.buh.bitdefender.com) (10.17.80.103) by mx01.buh.bitdefender.com with AES256-GCM-SHA384 encrypted SMTP; 10 Feb 2016 18:01:01 +0200 Received: from smtp01.buh.bitdefender.com (unknown [10.17.80.75]) by mx-sr.buh.bitdefender.com (Postfix) with ESMTP id E6BE17FBD8 for ; Wed, 10 Feb 2016 18:01:00 +0200 (EET) Received: (qmail 30564 invoked from network); 10 Feb 2016 18:00:48 +0200 Received: from 82-137-14-90.rdsnet.ro (HELO localhost.localdomain) (czuzu@bitdefender.com@82.137.14.90) by smtp01.buh.bitdefender.com with AES128-SHA256 encrypted SMTP; 10 Feb 2016 18:00:48 +0200 From: Corneliu ZUZU To: xen-devel@lists.xen.org Date: Wed, 10 Feb 2016 18:00:37 +0200 Message-Id: <1455120037-2784-1-git-send-email-czuzu@bitdefender.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1455119259-2161-1-git-send-email-czuzu@bitdefender.com> References: <1455119259-2161-1-git-send-email-czuzu@bitdefender.com> X-BitDefender-Scanner: Clean, Agent: BitDefender qmail 3.1.4 on smtp01.buh.bitdefender.com, sigver: 7.64459 X-BitDefender-Spam: No (0) X-BitDefender-SpamStamp: Build: [Engines: 2.15.6.743, Dats: 414080, Stamp: 3], Multi: [Enabled, t: (0.000011, 0.007164)], BW: [Enabled, t: (0.000007,0.000001)], RBL DNSBL: [Disabled], APM: [Enabled, Score: 500, t: (0.004637), Flags: 2A917CE3; NN_LARGISH_BIGGISH; NN_NO_CONTENT_TYPE; NN_LEGIT_SUMM_400_WORDS; NN_NO_LINK_NMD; NN_LEGIT_BITDEFENDER; NN_LEGIT_S_SQARE_BRACKETS; NN_LEGIT_MAILING_LIST_TO], SGN: [Enabled, t: (0.010369)], URL: [Enabled, t: (0.000006)], RTDA: [Enabled, t: (0.023844), Hit: No, Details: v2.3.3; Id: 2m1ghar.1aatui73f.2a1dk], total: 0(775) X-BitDefender-CF-Stamp: none Cc: Andrew Cooper , Kevin Tian , Keir Fraser , Jan Beulich , Jun Nakajima Subject: [Xen-devel] [PATCH v2 7/7] xen/vm-events: move arch_domain.monitor bits to common X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch moves bitfield members for single-step, software-breakpoint and guest-request monitor vm-events from the arch-side (arch_domain.monitor) to the common-side (domain.monitor). Ctrl-reg bits (i.e. write_ctrlreg_* members) are left on the arch-side, because control-registers number can vary across architectures. Signed-off-by: Corneliu ZUZU --- xen/arch/x86/hvm/vmx/vmcs.c | 4 ++-- xen/common/hvm/event.c | 12 ++++++------ xen/common/monitor.c | 17 +++++++---------- xen/include/asm-x86/domain.h | 16 ++++++---------- xen/include/xen/sched.h | 16 ++++++++++++++++ 5 files changed, 37 insertions(+), 28 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index 5bc3c74..07acbf2 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -1706,8 +1706,8 @@ void vmx_do_resume(struct vcpu *v) } debug_state = v->domain->debugger_attached - || v->domain->arch.monitor.software_breakpoint_enabled - || v->domain->arch.monitor.singlestep_enabled; + || v->domain->monitor.software_breakpoint_enabled + || v->domain->monitor.singlestep_enabled; if ( unlikely(v->arch.hvm_vcpu.debug_state_latch != debug_state) ) { diff --git a/xen/common/hvm/event.c b/xen/common/hvm/event.c index 0b532d5..0e5f30e 100644 --- a/xen/common/hvm/event.c +++ b/xen/common/hvm/event.c @@ -107,16 +107,16 @@ bool_t hvm_event_cr(unsigned int index, void hvm_event_guest_request(void) { struct vcpu *curr = current; - struct arch_domain *ad = &curr->domain->arch; + struct domain *d = curr->domain; - if ( ad->monitor.guest_request_enabled ) + if ( d->monitor.guest_request_enabled ) { vm_event_request_t req = { .reason = VM_EVENT_REASON_GUEST_REQUEST, .vcpu_id = curr->vcpu_id, }; - hvm_event_traps(curr, ad->monitor.guest_request_sync, &req); + hvm_event_traps(curr, d->monitor.guest_request_sync, &req); } } #endif // HAS_VM_EVENT_GUEST_REQUEST @@ -126,14 +126,14 @@ int hvm_event_breakpoint(unsigned long ip, enum hvm_event_breakpoint_type type) { struct vcpu *curr = current; - struct arch_domain *ad = &curr->domain->arch; + struct domain *d = curr->domain; vm_event_request_t req; switch ( type ) { #if CONFIG_HAS_VM_EVENT_SOFTWARE_BREAKPOINT case HVM_EVENT_SOFTWARE_BREAKPOINT: - if ( !ad->monitor.software_breakpoint_enabled ) + if ( !d->monitor.software_breakpoint_enabled ) return 0; req.reason = VM_EVENT_REASON_SOFTWARE_BREAKPOINT; req.u.software_breakpoint.gfn = arch_hvm_event_gfn_of_ip(ip); @@ -142,7 +142,7 @@ int hvm_event_breakpoint(unsigned long ip, #if CONFIG_HAS_VM_EVENT_SINGLESTEP case HVM_EVENT_SINGLESTEP_BREAKPOINT: - if ( !ad->monitor.singlestep_enabled ) + if ( !d->monitor.singlestep_enabled ) return 0; req.reason = VM_EVENT_REASON_SINGLESTEP; req.u.singlestep.gfn = arch_hvm_event_gfn_of_ip(ip); diff --git a/xen/common/monitor.c b/xen/common/monitor.c index 03063bb..3c69b5e 100644 --- a/xen/common/monitor.c +++ b/xen/common/monitor.c @@ -116,14 +116,13 @@ int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop) #if CONFIG_HAS_VM_EVENT_SINGLESTEP case XEN_DOMCTL_MONITOR_EVENT_SINGLESTEP: { - struct arch_domain *ad = &d->arch; - bool_t old_status = ad->monitor.singlestep_enabled; + bool_t old_status = d->monitor.singlestep_enabled; if ( unlikely(old_status == requested_status) ) return -EEXIST; domain_pause(d); - ad->monitor.singlestep_enabled = !old_status; + d->monitor.singlestep_enabled = !old_status; domain_unpause(d); break; } @@ -132,14 +131,13 @@ int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop) #if CONFIG_HAS_VM_EVENT_SOFTWARE_BREAKPOINT case XEN_DOMCTL_MONITOR_EVENT_SOFTWARE_BREAKPOINT: { - struct arch_domain *ad = &d->arch; - bool_t old_status = ad->monitor.software_breakpoint_enabled; + bool_t old_status = d->monitor.software_breakpoint_enabled; if ( unlikely(old_status == requested_status) ) return -EEXIST; domain_pause(d); - ad->monitor.software_breakpoint_enabled = !old_status; + d->monitor.software_breakpoint_enabled = !old_status; domain_unpause(d); break; } @@ -148,15 +146,14 @@ int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop) #if CONFIG_HAS_VM_EVENT_GUEST_REQUEST case XEN_DOMCTL_MONITOR_EVENT_GUEST_REQUEST: { - struct arch_domain *ad = &d->arch; - bool_t old_status = ad->monitor.guest_request_enabled; + bool_t old_status = d->monitor.guest_request_enabled; if ( unlikely(old_status == requested_status) ) return -EEXIST; domain_pause(d); - ad->monitor.guest_request_sync = mop->u.guest_request.sync; - ad->monitor.guest_request_enabled = !old_status; + d->monitor.guest_request_sync = mop->u.guest_request.sync; + d->monitor.guest_request_enabled = !old_status; domain_unpause(d); break; } diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h index 4072e27..6254060 100644 --- a/xen/include/asm-x86/domain.h +++ b/xen/include/asm-x86/domain.h @@ -376,17 +376,13 @@ struct arch_domain unsigned long *pirq_eoi_map; unsigned long pirq_eoi_map_mfn; - /* Monitor options */ + /* Arch-specific monitor vm-event options */ struct { - unsigned int write_ctrlreg_enabled : 4; - unsigned int write_ctrlreg_sync : 4; - unsigned int write_ctrlreg_onchangeonly : 4; - unsigned int mov_to_msr_enabled : 1; - unsigned int mov_to_msr_extended : 1; - unsigned int singlestep_enabled : 1; - unsigned int software_breakpoint_enabled : 1; - unsigned int guest_request_enabled : 1; - unsigned int guest_request_sync : 1; + uint16_t write_ctrlreg_enabled : 4; + uint16_t write_ctrlreg_sync : 4; + uint16_t write_ctrlreg_onchangeonly : 4; + uint16_t mov_to_msr_enabled : 1; + uint16_t mov_to_msr_extended : 1; } monitor; /* Mem_access emulation control */ diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index b47a3fe..5b01a7f 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -464,6 +464,22 @@ struct domain /* vNUMA topology accesses are protected by rwlock. */ rwlock_t vnuma_rwlock; struct vnuma_info *vnuma; + + /* Common monitor vm-events options */ + struct { +#if CONFIG_HAS_VM_EVENT_SINGLESTEP + uint8_t singlestep_enabled : 1; +#endif // HAS_VM_EVENT_SINGLESTEP + +#if CONFIG_HAS_VM_EVENT_SOFTWARE_BREAKPOINT + uint8_t software_breakpoint_enabled : 1; +#endif // HAS_VM_EVENT_SOFTWARE_BREAKPOINT + +#if CONFIG_HAS_VM_EVENT_GUEST_REQUEST + uint8_t guest_request_enabled : 1; + uint8_t guest_request_sync : 1; +#endif // HAS_VM_EVENT_GUEST_REQUEST + } monitor; }; /* Protect updates/reads (resp.) of domain_list and domain_hash. */