diff mbox

[v3,2/2] build: specify minimum versions of make

Message ID 1455193422-14558-2-git-send-email-ian.campbell@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ian Campbell Feb. 11, 2016, 12:23 p.m. UTC 
From: Doug Goldstein <cardoe@cardoe.com>

To help people avoid having to figure out what versions of make
needs to be supported document it explicitly.

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
v3: [ijc] Put make into a separate patch to reduce risk to
gcc+binutils patch #1 (since I'm not sure if v3.80 was really agreed)
---
 README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Cooper Feb. 11, 2016, 12:30 p.m. UTC | #1 
On 11/02/16 12:23, Ian Campbell wrote:
> From: Doug Goldstein <cardoe@cardoe.com>
>
> To help people avoid having to figure out what versions of make
> needs to be supported document it explicitly.
>
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

In particular, I have had changes rejected before for using v3.81'isms,
whereas we have plenty of v3.80'isms

> ---
> v3: [ijc] Put make into a separate patch to reduce risk to
> gcc+binutils patch #1 (since I'm not sure if v3.80 was really agreed)
> ---
>  README | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/README b/README
> index 356a350..dd36ec8 100644
> --- a/README
> +++ b/README
> @@ -38,7 +38,7 @@ provided by your OS distributor:
>      * GCC
>        - For x86 4.1.2_20070115 or later
>        - For ARM 4.8 or later
> -    * GNU Make
> +    * GNU Make v3.80 or later
>      * GNU Binutils:
>        - For x86 2.16.91.0.5 or later
>        - For ARM 2.24 or later
diff mbox

Patch

diff --git a/README b/README
index 356a350..dd36ec8 100644
--- a/README
+++ b/README
@@ -38,7 +38,7 @@  provided by your OS distributor:
     * GCC
       - For x86 4.1.2_20070115 or later
       - For ARM 4.8 or later
-    * GNU Make
+    * GNU Make v3.80 or later
     * GNU Binutils:
       - For x86 2.16.91.0.5 or later
       - For ARM 2.24 or later