From patchwork Wed Feb 17 15:39:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 8340421 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id ED0229F372 for ; Wed, 17 Feb 2016 15:43:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1C336203B7 for ; Wed, 17 Feb 2016 15:43:29 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 571F0203AE for ; Wed, 17 Feb 2016 15:43:28 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aW4DW-00024o-4h; Wed, 17 Feb 2016 15:40:38 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aW4DU-000247-W1 for xen-devel@lists.xen.org; Wed, 17 Feb 2016 15:40:37 +0000 Received: from [85.158.139.211] by server-7.bemta-5.messagelabs.com id EF/50-29293-47494C65; Wed, 17 Feb 2016 15:40:36 +0000 X-Env-Sender: prvs=848fde4e6=Ian.Campbell@citrix.com X-Msg-Ref: server-3.tower-206.messagelabs.com!1455723634!23067615!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 38307 invoked from network); 17 Feb 2016 15:40:35 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-3.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 17 Feb 2016 15:40:35 -0000 X-IronPort-AV: E=Sophos;i="5.22,461,1449532800"; d="scan'208";a="332364263" From: Ian Campbell To: , , Date: Wed, 17 Feb 2016 15:39:55 +0000 Message-ID: <1455723595-30904-1-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 X-DLP: MIA2 Cc: Ian Campbell Subject: [Xen-devel] [PATCH] xenpaging: don't try to log via xch if xc_interface_close fails X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Since xch may not be valid (enough) any longer, xc_interface_close already logs anything of any use before it tears down the integrated logger so there is no need to log any further in the application via that path. CID: 1056203 Signed-off-by: Ian Campbell Acked-by: Ian Jackson --- tools/xenpaging/xenpaging.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tools/xenpaging/xenpaging.c b/tools/xenpaging/xenpaging.c index 6157d3a..d0571ca 100644 --- a/tools/xenpaging/xenpaging.c +++ b/tools/xenpaging/xenpaging.c @@ -550,11 +550,7 @@ static void xenpaging_teardown(struct xenpaging *paging) xs_close(paging->xs_handle); /* Close connection to Xen */ - rc = xc_interface_close(xch); - if ( rc != 0 ) - { - ERROR("Error closing connection to xen"); - } + xc_interface_close(xch); } static void get_request(struct vm_event *vm_event, vm_event_request_t *req)