From patchwork Fri Feb 19 02:57:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Goldstein X-Patchwork-Id: 8355781 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D55E99F38B for ; Fri, 19 Feb 2016 03:00:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EBEEA203F1 for ; Fri, 19 Feb 2016 03:00:58 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07A69203E6 for ; Fri, 19 Feb 2016 03:00:58 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aWbH9-0003Ci-M8; Fri, 19 Feb 2016 02:58:35 +0000 Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aWbFx-0002uB-Kc for xen-devel@lists.xen.org; Fri, 19 Feb 2016 02:58:34 +0000 Received: from [85.158.143.35] by server-1.bemta-6.messagelabs.com id C3/25-05517-F8486C65; Fri, 19 Feb 2016 02:57:19 +0000 X-Env-Sender: cardoe@cardoe.com X-Msg-Ref: server-5.tower-21.messagelabs.com!1455850639!4556872!1 X-Originating-IP: [209.85.161.174] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 15367 invoked from network); 19 Feb 2016 02:57:20 -0000 Received: from mail-yw0-f174.google.com (HELO mail-yw0-f174.google.com) (209.85.161.174) by server-5.tower-21.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 19 Feb 2016 02:57:20 -0000 Received: by mail-yw0-f174.google.com with SMTP id h129so57699091ywb.1 for ; Thu, 18 Feb 2016 18:57:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cardoe.com; s=google; h=from:to:cc:subject:date:message-id; bh=o9dgVyL5sgpSIkDG0FgG1zxFEAV4SzM7FiFVmzeq190=; b=Zqn6aZPKRHnlR0b1s29GSKPyZYGXRqlst2txGY6Co+PD9CpAzK6cmA9Gc0mUSKWEhl 9zV+3b1zvoKsQ5Dou4gZLEbcfIZS8i0Hniuc9xZn2zqJoOqCDmeUcrWHDlBNqaQAIC4V lMEtC23zJjZhIPDc1T70+4x8iKaUUzwxCm2aI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=o9dgVyL5sgpSIkDG0FgG1zxFEAV4SzM7FiFVmzeq190=; b=FQ17iiKO9Mkx1N6LpGb66c3P9oRTSFiNjNb06AnInBkXAInUnlficMJFM8rrfRNjmD VffKkMe3kb+KkbZI6HDO/Pw/3x3N26Th1MslA3zjBabfemSS+80KNSJlNIqCp98SjpxH TUVx80saZ9P52Y+VQBvhFEej0whDxh79mkSToo5WVl4Xo/tT5LlSHhAIuesYNHrw4rEK fqxanCyvVa4UJ16hPcz8/Yp1J/sX6U4UgbrgVDJBF1s7QruH7Pra/l67AOMuBU1BCZ5V Hkkwaa2DvwUvqevzKtinlfiB3e4WRMJfC0mSf6JwI0TV7xl81hFplcabIFfb4d4kq4j5 RuUg== X-Gm-Message-State: AG10YOTPZJWsfSv5hdqkaIxHT/gqr567CZYdwffeY+i49mwhKVA65+3JEa9TQ/4mUoFNAw== X-Received: by 10.13.249.194 with SMTP id j185mr7149275ywf.66.1455850639258; Thu, 18 Feb 2016 18:57:19 -0800 (PST) Received: from swanson.lan (c-68-46-196-185.hsd1.al.comcast.net. [68.46.196.185]) by smtp.gmail.com with ESMTPSA id h131sm7083124ywb.25.2016.02.18.18.57.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 18 Feb 2016 18:57:17 -0800 (PST) From: Doug Goldstein To: xen-devel@lists.xen.org Date: Thu, 18 Feb 2016 20:57:02 -0600 Message-Id: <1455850625-9624-1-git-send-email-cardoe@cardoe.com> X-Mailer: git-send-email 2.4.10 Cc: Ian Jackson , Wei Liu , Doug Goldstein , Ian Campbell , Stefano Stabellini Subject: [Xen-devel] [PATCH v2 1/4] tools/configure: only require bcc/ld86/as86 when needed X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP bcc/ld86/as86 are only necessary when we build rombios and not always so failing the build when they aren't available should not happen if the user isn't building rombios. Signed-off-by: Doug Goldstein Reviewed-by: Konrad Rzeszutek Wilk --- CC: Ian Jackson CC: Stefano Stabellini CC: Ian Campbell CC: Wei Liu change since v1: - don't screw up the white space --- README | 3 ++- tools/configure.ac | 11 +++++++---- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/README b/README index dd36ec8..7cde45f 100644 --- a/README +++ b/README @@ -58,7 +58,6 @@ provided by your OS distributor: * iproute package (/sbin/ip) * GNU bison and GNU flex * GNU gettext - * 16-bit x86 assembler, loader and compiler (dev86 rpm or bin86 & bcc debs) * ACPI ASL compiler (iasl) * Libc multiarch package (e.g. libc6-dev-i386 / glibc-devel.i686). Required when building on a 64-bit platform to build @@ -78,6 +77,8 @@ disabled at compile time: libnl-3-dev, etc). Required if network buffering is desired when using Remus with libxl. See docs/README.remus for detailed information. + * 16-bit x86 assembler, loader and compiler for qemu-traditional / rombios + (dev86 rpm or bin86 & bcc debs) Second, you need to acquire a suitable kernel for use in domain 0. If possible you should use a kernel provided by your OS distributor. If diff --git a/tools/configure.ac b/tools/configure.ac index 6c70040..5b5dda4 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -164,7 +164,13 @@ AC_ARG_ENABLE([rombios], ]) ]) AS_IF([test "x$enable_rombios" = "xyes"], [ -AC_DEFINE([HAVE_ROMBIOS], [1], [ROMBIOS enabled]) + dnl as86, ld86, and bcc are only required when building rombios. They + dnl are only needed when the host system is x86 but that check is done + dnl for us above when checking if we should build with qemu-traditional. + AX_PATH_PROG_OR_FAIL([AS86], [as86]) + AX_PATH_PROG_OR_FAIL([LD86], [ld86]) + AX_PATH_PROG_OR_FAIL([BCC], [bcc]) + AC_DEFINE([HAVE_ROMBIOS], [1], [ROMBIOS enabled]) rombios=y],[ rombios=n ]) @@ -320,9 +326,6 @@ dnl going to run, not the platform on which we are building (known as dnl "build" in gnu speak). case "$host_cpu" in i[[3456]]86|x86_64) - AX_PATH_PROG_OR_FAIL([AS86], [as86]) - AX_PATH_PROG_OR_FAIL([LD86], [ld86]) - AX_PATH_PROG_OR_FAIL([BCC], [bcc]) AX_PATH_PROG_OR_FAIL([IASL], [iasl]) ;; esac