From patchwork Fri Feb 19 16:21:44 2016
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Ian Campbell <Ian.Campbell@citrix.com>
X-Patchwork-Id: 8362671
Return-Path: <xen-devel-bounces@lists.xen.org>
X-Original-To: patchwork-xen-devel@patchwork.kernel.org
Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org
Received: from mail.kernel.org (mail.kernel.org [198.145.29.136])
	by patchwork1.web.kernel.org (Postfix) with ESMTP id C61E59F372
	for <patchwork-xen-devel@patchwork.kernel.org>;
	Fri, 19 Feb 2016 16:24:15 +0000 (UTC)
Received: from mail.kernel.org (localhost [127.0.0.1])
	by mail.kernel.org (Postfix) with ESMTP id 21AB22052D
	for <patchwork-xen-devel@patchwork.kernel.org>;
	Fri, 19 Feb 2016 16:24:14 +0000 (UTC)
Received: from lists.xen.org (lists.xenproject.org [50.57.142.19])
	(using TLSv1 with cipher AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id 4543B20524
	for <patchwork-xen-devel@patchwork.kernel.org>;
	Fri, 19 Feb 2016 16:24:13 +0000 (UTC)
Received: from localhost ([127.0.0.1] helo=lists.xen.org)
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <xen-devel-bounces@lists.xen.org>)
	id 1aWnoU-0005Hi-Fh; Fri, 19 Feb 2016 16:21:50 +0000
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=850ae70d9=Ian.Campbell@citrix.com>)
	id 1aWnoT-0005HU-K9
	for xen-devel@lists.xen.org; Fri, 19 Feb 2016 16:21:49 +0000
Received: from [85.158.137.68] by server-9.bemta-3.messagelabs.com id
	DB/90-03814-C1147C65; Fri, 19 Feb 2016 16:21:48 +0000
X-Env-Sender: prvs=850ae70d9=Ian.Campbell@citrix.com
X-Msg-Ref: server-12.tower-31.messagelabs.com!1455898906!23612746!1
X-Originating-IP: [66.165.176.89]
X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor:
	VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n,
	received_headers: No Received headers
X-StarScan-Received: 
X-StarScan-Version: 7.35.1; banners=-,-,-
X-VirusChecked: Checked
Received: (qmail 33389 invoked from network); 19 Feb 2016 16:21:47 -0000
Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89)
	by server-12.tower-31.messagelabs.com with RC4-SHA encrypted SMTP;
	19 Feb 2016 16:21:47 -0000
X-IronPort-AV: E=Sophos;i="5.22,471,1449532800"; d="scan'208";a="332914592"
From: Ian Campbell <ian.campbell@citrix.com>
To: <ian.jackson@eu.citrix.com>, <xen-devel@lists.xen.org>
Date: Fri, 19 Feb 2016 16:21:44 +0000
Message-ID: <1455898904-28077-1-git-send-email-ian.campbell@citrix.com>
X-Mailer: git-send-email 2.6.1
MIME-Version: 1.0
X-DLP: MIA1
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [Xen-devel] [PATCH OSSTEST] sg-report-flight: move "started" column
	to the left in Step table
X-BeenThere: xen-devel@lists.xen.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: Xen developer discussion <xen-devel.lists.xen.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED,
	UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org
X-Virus-Scanned: ClamAV using ClamSMTP

With the current ordering of status => started I frequently (more
often than not) read the failing step as "(stepno,testid,script)
failed at <time>" (where <time> is actually the start time, not the
fail time).

Move the "started" column to the left of the "status" column. On the
basis that "(stepno,testid,script) started at $time and failed" reads
more (chrono)logically.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 sg-report-flight | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sg-report-flight b/sg-report-flight
index db0d922..99bde92 100755
--- a/sg-report-flight
+++ b/sg-report-flight
@@ -954,8 +954,8 @@ END
 </ul>
 <h2>Steps</h2>
 <table rules=all>
-<tr><th>stepno</th><th>testid</th><th>script</th><th>status</th>
-<th>started</th><th>duration</th></tr>
+<tr><th>stepno</th><th>testid</th><th>script</th><th>started</th>
+<th>status</th><th>duration</th></tr>
 END
 
     my %issteplog;
@@ -977,6 +977,8 @@ END
         $stepcol->('testid', '');
         $stepcol->('step', '');
 
+        printf H "<td>%s</td>", show_abs_time $step->{started};
+
         my $st= $step->{status};
         my $logfilename= "$step->{stepno}.$step->{step}.log";
         printf H "<td bgcolor='%s'><a href='%s'>%s</a></td>",
@@ -985,8 +987,6 @@ END
             encode_entities($st);
         $issteplog{$logfilename}= 1;
 
-        printf H "<td>%s</td>", show_abs_time $step->{started};
-
 	if (defined $step->{finished} && defined $step->{started}) {
 	    printf H "<td align=right>%d</td>\n",
                 $step->{finished} - $step->{started};