From patchwork Wed Feb 24 12:53:19 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harmandeep Kaur X-Patchwork-Id: 8405911 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 24F5CC0553 for ; Wed, 24 Feb 2016 12:56:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2798F20303 for ; Wed, 24 Feb 2016 12:56:35 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31CDE202F0 for ; Wed, 24 Feb 2016 12:56:34 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aYYxM-0007zi-1n; Wed, 24 Feb 2016 12:54:16 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aYYxL-0007zU-15 for xen-devel@lists.xenproject.org; Wed, 24 Feb 2016 12:54:15 +0000 Received: from [85.158.139.211] by server-2.bemta-5.messagelabs.com id 35/3E-03303-6F7ADC65; Wed, 24 Feb 2016 12:54:14 +0000 X-Env-Sender: write.harmandeep@gmail.com X-Msg-Ref: server-10.tower-206.messagelabs.com!1456318452!24638659!1 X-Originating-IP: [209.85.220.67] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 47674 invoked from network); 24 Feb 2016 12:54:13 -0000 Received: from mail-pa0-f67.google.com (HELO mail-pa0-f67.google.com) (209.85.220.67) by server-10.tower-206.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 24 Feb 2016 12:54:13 -0000 Received: by mail-pa0-f67.google.com with SMTP id a7so871999pax.3 for ; Wed, 24 Feb 2016 04:54:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AG+a1BMUfUrFSrHV1XrzhylN1RFJK3SX+9DO9b8EuOY=; b=Ii6MMxlxCpZF6CYh8qOu/Wf5VwI9ZjEi6mXEVzJWUJt9nvUoKpeJI9GldG6srwLSrr eiXro15xU/86H/CNPR2d0fttGmFAdVsNLHYMAcVU45KYNwbzGBxlmvoc71taIA6j8wXi 5mZXR+b/ZZV1i70TY1xjzUm31RfCXiVCcolAQEN8+cqQbeyvlRmA1tvfckaTRTuuwXzq t34YufT/zU15c1lWFAYDKQSKcq9e8qpi5lWsSm7N9ZLG9GImwEIE/buDRsMJIgwoX/4t L3bw0hniCPPmN1IOUuHFaWhGofc4Uz9mW6IXB/w7VVfSqD6L/2Qh+04DJtJwLX/4+cgq droA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AG+a1BMUfUrFSrHV1XrzhylN1RFJK3SX+9DO9b8EuOY=; b=ImNxJ5NfWfPiVkRzTt66LmVLk8DSF5th8yDwRPEDbWlBWxm1HacMa/H58SHoudqdPR TEdJaMzQpgeaiID2FX5he46ncv0sebxaRPYqgG6Wqj28Es2JGJKDj0D1kMCTrv29Tgni d7qFgmSrLxevokPxVCIHh6GOQ+uaUF99qNzSa5mJjq0qj4jb5zeakqctCKUbmowY/zI/ OuVQDjvgkc+20VXMXJcP2QMRXj9ijUBK6OF058QYcJws4idJ4AC2r3jO2oEWbGRuhH6E REjWnlwGYhCZ5fQoBpjrMg67HGZ6T53ooMIkmdt6u2D+tWa+Kqo9LzKByfOcsDu9drff RswA== X-Gm-Message-State: AG10YOSrc371qtw2nv3Ft5CNtgWuDCUYQtyrZuKPumxJVSl3AfzjEvOaUME31Nc1rO5EaQ== X-Received: by 10.67.24.104 with SMTP id ih8mr54624451pad.124.1456318451929; Wed, 24 Feb 2016 04:54:11 -0800 (PST) Received: from localhost.localdomain ([124.253.62.0]) by smtp.googlemail.com with ESMTPSA id t87sm5027294pfa.14.2016.02.24.04.54.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 24 Feb 2016 04:54:11 -0800 (PST) From: Harmandeep Kaur To: xen-devel@lists.xenproject.org Date: Wed, 24 Feb 2016 18:23:19 +0530 Message-Id: <1456318407-3635-2-git-send-email-write.harmandeep@gmail.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1456318407-3635-1-git-send-email-write.harmandeep@gmail.com> References: <1456318407-3635-1-git-send-email-write.harmandeep@gmail.com> Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, Harmandeep Kaur Subject: [Xen-devel] [PATCH 1/9] xl: Improve return and exit codes of memory related functions. X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Harmandeep Kaur --- tools/libxl/xl_cmdimpl.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 116363d..8f5a2f4 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -172,7 +172,7 @@ static uint32_t find_domain(const char *p) rc = libxl_domain_qualifier_to_domid(ctx, p, &domid); if (rc) { fprintf(stderr, "%s is an invalid domain identifier (rc=%d)\n", p, rc); - exit(2); + exit(EXIT_FAILURE); } common_domname = libxl_domid_to_name(ctx, domid); return domid; @@ -3275,7 +3275,7 @@ static int set_memory_max(uint32_t domid, const char *mem) memorykb = parse_mem_size_kb(mem); if (memorykb == -1) { fprintf(stderr, "invalid memory size: %s\n", mem); - exit(3); + exit(EXIT_FAILURE); } rc = libxl_domain_setmaxmem(ctx, domid, memorykb); @@ -3300,10 +3300,10 @@ int main_memmax(int argc, char **argv) rc = set_memory_max(domid, mem); if (rc) { fprintf(stderr, "cannot set domid %d static max memory to : %s\n", domid, mem); - return 1; + return EXIT_FAILURE; } - return 0; + return EXIT_SUCCESS; } static void set_memory_target(uint32_t domid, const char *mem) @@ -3313,7 +3313,7 @@ static void set_memory_target(uint32_t domid, const char *mem) memorykb = parse_mem_size_kb(mem); if (memorykb == -1) { fprintf(stderr, "invalid memory size: %s\n", mem); - exit(3); + exit(EXIT_FAILURE); } libxl_set_memory_target(ctx, domid, memorykb, 0, /* enforce */ 1); @@ -3333,7 +3333,7 @@ int main_memset(int argc, char **argv) mem = argv[optind + 1]; set_memory_target(domid, mem); - return 0; + return EXIT_SUCCESS; } static int cd_insert(uint32_t domid, const char *virtdev, char *phys)