From patchwork Thu Feb 25 14:48:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: George Dunlap X-Patchwork-Id: 8423761 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id BBBE7C0553 for ; Thu, 25 Feb 2016 14:51:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0FEC42034C for ; Thu, 25 Feb 2016 14:51:50 +0000 (UTC) Received: from lists.xen.org (unknown [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A78620268 for ; Thu, 25 Feb 2016 14:51:49 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1aYxEG-00085q-6j; Thu, 25 Feb 2016 14:49:20 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1aYxEF-00084L-1x for xen-devel@lists.xen.org; Thu, 25 Feb 2016 14:49:19 +0000 Received: from [85.158.137.68] by server-5.bemta-3.messagelabs.com id 90/BD-03651-E641FC65; Thu, 25 Feb 2016 14:49:18 +0000 X-Env-Sender: prvs=856900a8f=George.Dunlap@citrix.com X-Msg-Ref: server-10.tower-31.messagelabs.com!1456411754!25026848!2 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 31391 invoked from network); 25 Feb 2016 14:49:17 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-10.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 25 Feb 2016 14:49:17 -0000 X-IronPort-AV: E=Sophos;i="5.22,498,1449532800"; d="scan'208";a="341078880" From: George Dunlap To: Date: Thu, 25 Feb 2016 14:48:56 +0000 Message-ID: <1456411743-17741-2-git-send-email-george.dunlap@eu.citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1456411743-17741-1-git-send-email-george.dunlap@eu.citrix.com> References: <1456411743-17741-1-git-send-email-george.dunlap@eu.citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: George Dunlap , Ian Jackson , Wei Liu , George Dunlap Subject: [Xen-devel] [PATCH 1/8] tools/xenalyze: Close symbol_file after reading it X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,RDNS_NONE, UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP ...to avoid leaking the FD and associated memory. CID 1306872 Signed-off-by: George Dunlap Acked-by: Ian Jackson --- Not sure if this will actually make coverity happy, or if we need to actually set symbol_file to NULL. CC: Ian Jackson CC: Wei Liu --- tools/xentrace/xenalyze.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c index 1651302..3c90a0f 100644 --- a/tools/xentrace/xenalyze.c +++ b/tools/xentrace/xenalyze.c @@ -363,6 +363,8 @@ void parse_symbol_file(char *fn) { p=&((*p)->next); } } + + fclose(symbol_file); } /* WARNING not thread safe */