| Message ID | 1456822933-25041-2-git-send-email-jgross@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 2016-03-01 at 10:02 +0100, Juergen Gross wrote: > When taking cpus offline for suspend or bringing them online on > resume > again the scheduler might issue debug messages when temporarily > breaking vcpu affinity or restoring the original affinity settings. > > The resume message can be removed completely, while the message when > breaking affinity should only be issued if the breakage is permanent. > > Suggested-by: Jan Beulich <jbeulich@suse.com> > Signed-off-by: Juergen Gross <jgross@suse.com> > Acked-by: Dario Faggioli <dario.faggioli@citrix.com> Thanks and Regards, Dario
diff --git a/xen/common/schedule.c b/xen/common/schedule.c index 434dcfc..b0d4b18 100644 --- a/xen/common/schedule.c +++ b/xen/common/schedule.c @@ -615,7 +615,6 @@ void restore_vcpu_affinity(struct domain *d) if ( v->affinity_broken ) { - printk(XENLOG_DEBUG "Restoring affinity for %pv\n", v); cpumask_copy(v->cpu_hard_affinity, v->cpu_hard_affinity_saved); v->affinity_broken = 0; } @@ -670,14 +669,14 @@ int cpu_disable_scheduler(unsigned int cpu) if ( cpumask_empty(&online_affinity) && cpumask_test_cpu(cpu, v->cpu_hard_affinity) ) { - printk(XENLOG_DEBUG "Breaking affinity for %pv\n", v); - if (system_state == SYS_STATE_suspend) { cpumask_copy(v->cpu_hard_affinity_saved, v->cpu_hard_affinity); v->affinity_broken = 1; } + else + printk(XENLOG_DEBUG "Breaking affinity for %pv\n", v); cpumask_setall(v->cpu_hard_affinity); }
When taking cpus offline for suspend or bringing them online on resume again the scheduler might issue debug messages when temporarily breaking vcpu affinity or restoring the original affinity settings. The resume message can be removed completely, while the message when breaking affinity should only be issued if the breakage is permanent. Suggested-by: Jan Beulich <jbeulich@suse.com> Signed-off-by: Juergen Gross <jgross@suse.com> --- xen/common/schedule.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)