From patchwork Tue Mar 8 19:02:10 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harmandeep Kaur X-Patchwork-Id: 8536841 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0F5959F372 for ; Tue, 8 Mar 2016 19:05:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3B77520204 for ; Tue, 8 Mar 2016 19:05:49 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B35620218 for ; Tue, 8 Mar 2016 19:05:47 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1adMuc-00016F-UQ; Tue, 08 Mar 2016 19:03:18 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1adMub-00015R-Uf for xen-devel@lists.xenproject.org; Tue, 08 Mar 2016 19:03:18 +0000 Received: from [85.158.139.211] by server-10.bemta-5.messagelabs.com id 59/9E-02017-5F12FD65; Tue, 08 Mar 2016 19:03:17 +0000 X-Env-Sender: write.harmandeep@gmail.com X-Msg-Ref: server-5.tower-206.messagelabs.com!1457463796!27692033!1 X-Originating-IP: [74.125.82.67] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.11; banners=-,-,- X-VirusChecked: Checked Received: (qmail 44836 invoked from network); 8 Mar 2016 19:03:16 -0000 Received: from mail-wm0-f67.google.com (HELO mail-wm0-f67.google.com) (74.125.82.67) by server-5.tower-206.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 8 Mar 2016 19:03:16 -0000 Received: by mail-wm0-f67.google.com with SMTP id n186so5921944wmn.0 for ; Tue, 08 Mar 2016 11:03:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=g06WfSJkM3v0hHUCb5hRsafSo0rbFpVyk6AKPc1FIOc=; b=bUIcf43gI+QqS1v2MNCBHnA1Lgdy8yp0lUr7gmApn+ujxUZvzZ5cK4QA4eqtxZho5I 9127VOrRQtMY6vCeo+aXidjJROh3jIiwgeRfl3Ab4kSaAcJnQzLzs7mODswS0zRmPi/i 10Qsnpo2RhX8Uz/i7+tGGdQ5jxeHClCBt5nEtoRTV+Pf5QM1rzNpqDQKm5+zm5+AHm8T 3GX5Klofus1yS/ab2SSCX45qDZmukP811vGP1Q/xvF9eX1YCaUAVnGjPrfmvMqiyFCIz dg/M0pPg/DhVEf3Fl/+LOQnvEfSWN6NPV1MXcCQKwfkLufteuHZSBlIsTmwe/ozaMC49 VVlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=g06WfSJkM3v0hHUCb5hRsafSo0rbFpVyk6AKPc1FIOc=; b=IVHW0zx8VFD5hn9y6YzWOeN45HFkyM9n5iPd31+s8eGWf6VYGB8jXxIgLjxz67txjH 2h9IvEoONSK+eq+eNmGgdek/zcelkwusZxbS9XtGD7ceatDqveC6I17QrMqYmI/dGPuL KE3ZGt6I78+cBhH+heqB3J3NvtSa9gB/Jhs34xuKdsWLpjC+iF1sHjYJf8K8rO5a8uoc zeAXyR/YoGlGLuQ8ypigTi1w0d+xAU29cO+lG+/BGxP9E89Vmk9KDUOPgtvMtf+AyefW sJdcnKEKs7Mx/n3BDGKtenOCenbVu81GtCH2dNr7g13kKrvFG2igvKfu1uMHrByLecdi IWOg== X-Gm-Message-State: AD7BkJJsLjc2t9RdYPRTwX9YUxtRv5XRiJ6Uan+J0YFL4c3h7M4dQR1oLMzhH7yANLoZDg== X-Received: by 10.28.158.15 with SMTP id h15mr1786701wme.89.1457463796210; Tue, 08 Mar 2016 11:03:16 -0800 (PST) Received: from localhost.localdomain ([124.253.57.150]) by smtp.googlemail.com with ESMTPSA id hu1sm4310795wjb.36.2016.03.08.11.03.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 08 Mar 2016 11:03:15 -0800 (PST) From: Harmandeep Kaur To: xen-devel@lists.xenproject.org Date: Wed, 9 Mar 2016 00:32:10 +0530 Message-Id: <1457463730-4712-10-git-send-email-write.harmandeep@gmail.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1457463730-4712-1-git-send-email-write.harmandeep@gmail.com> References: <1457463730-4712-1-git-send-email-write.harmandeep@gmail.com> Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, Harmandeep Kaur Subject: [Xen-devel] [PATCH 9/9 v2] xl: Improve return and exit codes of domain id and name related functions. X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP find_domain(), main_domid() and main_domname() are fixed. Signed-off-by: Harmandeep Kaur --- v2: Add find_domain(). --- tools/libxl/xl_cmdimpl.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 4b2ae68..883589b 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -172,7 +172,7 @@ static uint32_t find_domain(const char *p) rc = libxl_domain_qualifier_to_domid(ctx, p, &domid); if (rc) { fprintf(stderr, "%s is an invalid domain identifier (rc=%d)\n", p, rc); - exit(2); + exit(EXIT_FAILURE); } common_domname = libxl_domid_to_name(ctx, domid); return domid; @@ -6335,12 +6335,12 @@ int main_domid(int argc, char **argv) if (libxl_name_to_domid(ctx, domname, &domid)) { fprintf(stderr, "Can't get domid of domain name '%s', maybe this domain does not exist.\n", domname); - return 1; + return EXIT_FAILURE; } printf("%d\n", domid); - return 0; + return EXIT_SUCCESS; } int main_domname(int argc, char **argv) @@ -6358,19 +6358,19 @@ int main_domname(int argc, char **argv) if (domid == 0 && !strcmp(endptr, argv[optind])) { /*no digits at all*/ fprintf(stderr, "Invalid domain id.\n\n"); - return 1; + return EXIT_FAILURE; } domname = libxl_domid_to_name(ctx, domid); if (!domname) { fprintf(stderr, "Can't get domain name of domain id '%d', maybe this domain does not exist.\n", domid); - return 1; + return EXIT_FAILURE; } printf("%s\n", domname); free(domname); - return 0; + return EXIT_SUCCESS; } int main_rename(int argc, char **argv)