| Message ID | 1460022028-25174-5-git-send-email-cyliu@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/04/16 11:40, Chunyan Liu wrote: > Missing a check of controller type. > > Signed-off-by: Chunyan Liu <cyliu@suse.com> > CC: Simon Cao <caobosimon@gmail.com> > CC: George Dunlap <george.dunlap@citrix.com> > CC: Ian Jackson <Ian.Jackson@eu.citrix.com> > CC: Juergen Gross <jgross@suse.com> Reviewed-by: Juergen Gross <jgross@suse.com> > --- > This affects Juergen's qusb patch too. Fix that together. This patch > could be applied on top of Juergen's qusb backend patch. > > tools/libxl/libxl_pvusb.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tools/libxl/libxl_pvusb.c b/tools/libxl/libxl_pvusb.c > index 02d3e55..6447639 100644 > --- a/tools/libxl/libxl_pvusb.c > +++ b/tools/libxl/libxl_pvusb.c > @@ -811,6 +811,13 @@ static int libxl__device_usbdev_setdefault(libxl__gc *gc, > } > } > > + if (usbctrl->type != LIBXL_USBCTRL_TYPE_PV && > + usbctrl->type != LIBXL_USBCTRL_TYPE_QUSB) { > + LOG(ERROR, "Unsupported USB controller type"); > + rc = ERROR_FAIL; > + goto out; > + } > + > rc = libxl__device_usbctrl_add_xenstore(gc, domid, usbctrl, > update_json); > if (rc) goto out; >
diff --git a/tools/libxl/libxl_pvusb.c b/tools/libxl/libxl_pvusb.c index 02d3e55..6447639 100644 --- a/tools/libxl/libxl_pvusb.c +++ b/tools/libxl/libxl_pvusb.c @@ -811,6 +811,13 @@ static int libxl__device_usbdev_setdefault(libxl__gc *gc, } } + if (usbctrl->type != LIBXL_USBCTRL_TYPE_PV && + usbctrl->type != LIBXL_USBCTRL_TYPE_QUSB) { + LOG(ERROR, "Unsupported USB controller type"); + rc = ERROR_FAIL; + goto out; + } + rc = libxl__device_usbctrl_add_xenstore(gc, domid, usbctrl, update_json); if (rc) goto out;
Missing a check of controller type. Signed-off-by: Chunyan Liu <cyliu@suse.com> CC: Simon Cao <caobosimon@gmail.com> CC: George Dunlap <george.dunlap@citrix.com> CC: Ian Jackson <Ian.Jackson@eu.citrix.com> CC: Juergen Gross <jgross@suse.com> --- This affects Juergen's qusb patch too. Fix that together. This patch could be applied on top of Juergen's qusb backend patch. tools/libxl/libxl_pvusb.c | 7 +++++++ 1 file changed, 7 insertions(+)