From patchwork Thu Apr 7 17:45:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 8775411 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 671D0C0553 for ; Thu, 7 Apr 2016 17:48:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A3A272024F for ; Thu, 7 Apr 2016 17:48:26 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1EC420204 for ; Thu, 7 Apr 2016 17:48:25 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aoE0r-0008LJ-PL; Thu, 07 Apr 2016 17:46:37 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aoE0q-0008Kw-2b for xen-devel@lists.xenproject.org; Thu, 07 Apr 2016 17:46:36 +0000 Received: from [85.158.137.68] by server-17.bemta-3.messagelabs.com id 02/F4-03149-BFC96075; Thu, 07 Apr 2016 17:46:35 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKIsWRWlGSWpSXmKPExsXitHSDve6vOWz hBp0dWhbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8a+5atZCzq4Kp5/WcvWwHiJvYuRk0NCwF9i T8dEMJtNQEfi4tydbF2MHBwiAioSt/cagISZBYolvq7qYwWxhQUiJaa8mM8EYrMAlcyaNBEsz ivgIrGqdz0rxEhdiZO7N7GDjOEUcJXY9oYHJCwEVPKx4SsjRLmgxMmZT1ggxmtKtG7/zQ5hy0 s0b53NDFGvKNE/7wHYNRIC3BJ/u+0nMPLPQtI9C0n3LCTdCxiZVzGqF6cWlaUW6VroJRVlpme U5CZm5ugaGhjr5aYWFyemp+YkJhXrJefnbmIEBh8DEOxgvNDufIhRkoNJSZR3eQdbuBBfUn5K ZUZicUZ8UWlOavEhRhkODiUJXi9gMAsJFqWmp1akZeYA4wAmLcHBoyTCGweS5i0uSMwtzkyHS J1iVJQS570xGyghAJLIKM2Da4PF3iVGWSlhXkagQ4R4ClKLcjNLUOVfMYpzMCoJ89qDjOfJzC uBm/4KaDET0OIL/GCLSxIRUlINjNqnD67d/fLymyMNqbGbJjXOFPLQOKR48tY+ky880tEFgWf nr7n2SbL8C+euepm5O+vKXWNsDl95Ybc81l+JW8dP0uyNSKJIH8vvHROZzAOucmrPtGAqedEZ 9v7msXOnNxt1zOPsP51vVyIxhydZ2WHp6WX1tsU1krs1PrNUPm1SfPrnr+OxaCWW4oxEQy3mo uJEAJOLQjC4AgAA X-Env-Sender: prvs=898fe3ee9=roger.pau@citrix.com X-Msg-Ref: server-7.tower-31.messagelabs.com!1460051192!26102191!2 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 8.28; banners=-,-,- X-VirusChecked: Checked Received: (qmail 59106 invoked from network); 7 Apr 2016 17:46:34 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-7.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 7 Apr 2016 17:46:34 -0000 X-IronPort-AV: E=Sophos;i="5.24,449,1454976000"; d="scan'208";a="352270227" From: Roger Pau Monne To: Date: Thu, 7 Apr 2016 19:45:29 +0200 Message-ID: <1460051129-20817-5-git-send-email-roger.pau@citrix.com> X-Mailer: git-send-email 2.6.4 (Apple Git-63) In-Reply-To: <1460051129-20817-1-git-send-email-roger.pau@citrix.com> References: <1460051129-20817-1-git-send-email-roger.pau@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: Wei Liu , Ian Jackson , Roger Pau Monne Subject: [Xen-devel] [PATCH 4/4] libxl: remove code added to use the 'phy' backend with CDROM devices X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Roger Pau Monné Cc: Ian Jackson Cc: Wei Liu Acked-by: Wei Liu --- tools/libxl/libxl_device.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/tools/libxl/libxl_device.c b/tools/libxl/libxl_device.c index ce53520..82405a7 100644 --- a/tools/libxl/libxl_device.c +++ b/tools/libxl/libxl_device.c @@ -191,20 +191,13 @@ static int disk_try_backend(disk_try_backend_args *a, switch (backend) { case LIBXL_DISK_BACKEND_PHY: - if (!(a->disk->format == LIBXL_DISK_FORMAT_RAW || - a->disk->format == LIBXL_DISK_FORMAT_EMPTY)) { + if (a->disk->format != LIBXL_DISK_FORMAT_RAW) { goto bad_format; } if (libxl_defbool_val(a->disk->colo_enable)) goto bad_colo; - if (a->disk->format == LIBXL_DISK_FORMAT_EMPTY) { - LOG(DEBUG, "Disk vdev=%s is empty, skipping physical device check", - a->disk->vdev); - return backend; - } - if (a->disk->backend_domid != LIBXL_TOOLSTACK_DOMID) { LOG(DEBUG, "Disk vdev=%s, is using a storage driver domain, " "skipping physical device check", a->disk->vdev);