Message ID | 1460158825-13117-10-git-send-email-mcgrof@kernel.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <xen-devel-bounces@lists.xen.org> X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id AF25FC0553 for <patchwork-xen-devel@patchwork.kernel.org>; Fri, 8 Apr 2016 23:43:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E4BDF20256 for <patchwork-xen-devel@patchwork.kernel.org>; Fri, 8 Apr 2016 23:43:06 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03A8A2024D for <patchwork-xen-devel@patchwork.kernel.org>; Fri, 8 Apr 2016 23:43:06 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from <xen-devel-bounces@lists.xen.org>) id 1aog1P-00007c-Er; Fri, 08 Apr 2016 23:41:03 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from <mcgrof@kernel.org>) id 1aog1O-00006n-Ff for xen-devel@lists.xensource.com; Fri, 08 Apr 2016 23:41:02 +0000 Received: from [85.158.139.211] by server-13.bemta-5.messagelabs.com id 43/BD-28710-D8148075; Fri, 08 Apr 2016 23:41:01 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJLMWRWlGSWpSXmKPExsVybKJsh26vI0e 4wbkFnBb3prxnd2D02N63iz2AMYo1My8pvyKBNeNuywLGgg7uirsr+5gaGJdzdjFycQgJTGWU ONc+l6WLkRPImcEksfxWchcjBwebgK7EzdsSIGERgQSJu0+/MYPUMwucY5HYcGk+G0hCWMBO4 uf9aUwgNouAqsSmhTvYQWxeASeJhUf7GUFsCQE5iZYfu1lBbE6g+MF9f5ghdjlKXD3zhgWiJk NiXs8cVgjbS2LRjUtQtprE1XObmCcw8i1gZFjFqF6cWlSWWqRrqpdUlJmeUZKbmJmja2hgqpe bWlycmJ6ak5hUrJecn7uJERgkDECwg/FLv/MhRkkOJiVR3m0P2cOF+JLyUyozEosz4otKc1KL DzHKcHAoSfAWOnCECwkWpaanVqRl5gDDFSYtwcGjJMK7HyTNW1yQmFucmQ6ROsWoKCXOuw0kI QCSyCjNg2uDxcglRlkpYV5GoEOEeApSi3IzS1DlXzGKczAqCfPuBZnCk5lXAjf9FdBiJqDFF/ jZQBaXJCKkpBoYNU8EPdu+i0+mI4Mz79Fi7cjfcT1+gVseSN1L8+Z+u+h48NrfCxlfbSztU54 +5bTc7s9i3hNzOE/vCvpWosjZmqWskGgktOEz42mXN4c7r566dLB0Qm/qx7Yz7S2GqveYDs/0 3Vewycu6cv0/eYn3Tx4sMX0pOF0/Kj+sdJv60rPmk/aeC2FhUWIpzkg01GIuKk4EAI2XgXyMA gAA X-Env-Sender: mcgrof@kernel.org X-Msg-Ref: server-11.tower-206.messagelabs.com!1460158859!21528587!1 X-Originating-IP: [198.145.29.136] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.28; banners=-,-,- X-VirusChecked: Checked Received: (qmail 47937 invoked from network); 8 Apr 2016 23:41:01 -0000 Received: from mail.kernel.org (HELO mail.kernel.org) (198.145.29.136) by server-11.tower-206.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 8 Apr 2016 23:41:01 -0000 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D8AA62035B; Fri, 8 Apr 2016 23:40:58 +0000 (UTC) Received: from garbanzo.do-not-panic.com (c-73-15-241-2.hsd1.ca.comcast.net [73.15.241.2]) (using TLSv1.2 with cipher AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4BDDB2035E; Fri, 8 Apr 2016 23:40:57 +0000 (UTC) From: "Luis R. Rodriguez" <mcgrof@kernel.org> To: bp@alien8.de, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, rusty@rustcorp.com.au Date: Fri, 8 Apr 2016 16:40:20 -0700 Message-Id: <1460158825-13117-10-git-send-email-mcgrof@kernel.org> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1460158825-13117-1-git-send-email-mcgrof@kernel.org> References: <1460158825-13117-1-git-send-email-mcgrof@kernel.org> X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Cc: kozerkov@parallels.com, matt@codeblueprint.co.uk, lv.zheng@intel.com, xen-devel@lists.xensource.com, joro@8bytes.org, x86@kernel.org, robert.moore@intel.com, linux-acpi@vger.kernel.org, glin@suse.com, lenb@kernel.org, josh@joshtriplett.org, jlee@suse.com, lguest@lists.ozlabs.org, boris.ostrovsky@oracle.com, andriy.shevchenko@linux.intel.com, toshi.kani@hp.com, andrew.cooper3@citrix.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, luto@amacapital.net, "Luis R. Rodriguez" <mcgrof@kernel.org>, david.vrabel@citrix.com, tiwai@suse.de Subject: [Xen-devel] [PATCH v5 09/14] x86/tboot: remove paravirt_enabled() X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion <xen-devel.lists.xen.org> List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>, <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe> List-Post: <mailto:xen-devel@lists.xen.org> List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help> List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xen.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org> X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c index e72a07f20b05..9b0185fbe3eb 100644 --- a/arch/x86/kernel/tboot.c +++ b/arch/x86/kernel/tboot.c @@ -74,12 +74,6 @@ void __init tboot_probe(void) return; } - /* only a natively booted kernel should be using TXT */ - if (paravirt_enabled()) { - pr_warning("non-0 tboot_addr but pv_ops is enabled\n"); - return; - } - /* Map and check for tboot UUID. */ set_fixmap(FIX_TBOOT_BASE, boot_params.tboot_addr); tboot = (struct tboot *)fix_to_virt(FIX_TBOOT_BASE);
There is already a check for boot_params.tboot_addr prior to paravirt_enabled(). Both Xen and lguest, which are also the only ones that set paravirt_enabled to true, never set the boot_params.tboot_addr. The Xen folks are sure a force disable to 0 is not needed, we recently forced disabled this on lguest. With this in place this check is no longer needed. Xen folks are sure force disable to 0 is not needed because apm_info lives in .bss, we recently forced disabled this on lguest, and on the Xen side just to be sure Boris zeroed out the .bss for PV guests through commit 04b6b4a56884327c1648 ("xen/x86: Zero out .bss for PV guests"). With this care taken into consideration the paravirt_enabled() check is simply not needed anymore. Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> --- arch/x86/kernel/tboot.c | 6 ------ 1 file changed, 6 deletions(-)