From patchwork Wed Apr 20 13:54:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 8890191 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E19AA9F39A for ; Wed, 20 Apr 2016 14:01:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2B16320211 for ; Wed, 20 Apr 2016 14:01:53 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70FDA201B9 for ; Wed, 20 Apr 2016 14:01:50 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1asseS-00054A-2O; Wed, 20 Apr 2016 13:58:44 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1asseQ-000544-KQ for xen-devel@lists.xen.org; Wed, 20 Apr 2016 13:58:42 +0000 Received: from [193.109.254.147] by server-8.bemta-14.messagelabs.com id C1/1E-03512-11B87175; Wed, 20 Apr 2016 13:58:41 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMIsWRWlGSWpSXmKPExsVyMfSOs65gt3i 4wdbZYhZLPi5mcWD0OLr7N1MAYxRrZl5SfkUCa0bT7YdMBd84Kn6sXMXSwHiIrYuRi0NIoJ9R 4vm+pexdjJwcLAKXWCRWvrUDSUgIvGORWHf2OitIQkIgRmLG3zagDg4gu1zi9aEMkLCQgIrE3 E09jBCDepgkrk0+ygiSYBNQkzjyfiaYLSIgLXHt82Uwm1kgV+JVdwsLiC0sYCBxYspxNojFqh Lb7/8Ai/MKuEi8b1rECLFXTmLK/XamCYx8CxgZVjFqFKcWlaUW6Roa6SUVZaZnlOQmZuboGhq a6OWmFhcnpqfmJCYV6yXn525iBAYKAxDsYDw7zfkQoyQHk5Io75sm8XAhvqT8lMqMxOKM+KLS nNTiQ4wyHBxKErwXO4FygkWp6akVaZk5wJCFSUtw8CiJ8J4BSfMWFyTmFmemQ6ROMVpybPl9b S0Tx7ap94DkvEm7jjEJseTl56VKifNuAWkQAGnIKM2DGweLq0uMslLCvIxABwrxFKQW5WaWoM q/YhTnYFQS5j0NMoUnM68EbusroIOYgA7ivysKclBJIkJKqoFxp8rbqKOyrDoHf58tnKqytLL cfOGiU7Hte+V+X/r6Z2fD74T/NWw3JUzOm6542/j+4PttO85k7vJ80svk9mMjU4W2SNuEfQs2 8Dww61FOqNDn1DmS5mn7VHm7xKW97v4JHKsWrfPOCw58IGz2VetVyxaLllUHeM8eT1299JKPW ZVlIa98Kc8EJZbijERDLeai4kQA6XbYyaYCAAA= X-Env-Sender: van.freenix@gmail.com X-Msg-Ref: server-6.tower-27.messagelabs.com!1461160719!36895930!1 X-Originating-IP: [209.85.220.67] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.28; banners=-,-,- X-VirusChecked: Checked Received: (qmail 63135 invoked from network); 20 Apr 2016 13:58:41 -0000 Received: from mail-pa0-f67.google.com (HELO mail-pa0-f67.google.com) (209.85.220.67) by server-6.tower-27.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 20 Apr 2016 13:58:41 -0000 Received: by mail-pa0-f67.google.com with SMTP id i5so4083480pag.3 for ; Wed, 20 Apr 2016 06:58:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=rqkUK7ve5sG6do/unWCbazmipM27pfImK/1rttkyEcg=; b=WuxaybMwzxCviQo2zw2vpcj1GQbxhgQ/cdfqgjtmcju11dUmF3o0sPQT+eQIUVip8V TWeFc0gjtgT2NKXDzDK1ItUzhv4EtJKJVPVyQcDKYnqagtg4aK4wHj/XmDUSm4TXUO06 gF6hXL/fPG64Nx9etgS4m/ttaNdJ1pfnkJ77jVtcCMGR3M2f14K5VcIyYNx0XH838WyT HiF1utsxPicMLNVa2z54sjsZwvVulDwyIORsIFc/TYTTgAkBoeVOInhqFRotsTzagLAv x6dUw8Xp/MzHPp/ZiwFuag7ZzSzr+W3WvTnLZh0b+1VcWrR2BEKSG2TrqCwto6qkwhEt 62lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=rqkUK7ve5sG6do/unWCbazmipM27pfImK/1rttkyEcg=; b=ZgpDR/2aBh0fIJk/EXcU0/ASqMZLE55m8rOGBuHFwDac933bZKf0JEl7W86ekb5kPq U9jwDU0N807KCw6JfM0udT5UIUwguHjdbPCgJzt9chhdcSRxFS5XaJkB8F9Ox3Nv7S8u jbg8krvra7LTze8ANimVg6pd0eB3liTEmvu32J50IiG8PP44yA46VkKHVv0eZ4p8Mwc+ FajV/zczDLhxbx6dyz9cFgy2uNHtV2LBcj0yXpj7m5fkylfsjFimLSIQ0DyV6eYTT0Hr rd1XAlYw5jD/DIN65V4Jp9usvKkWZRjsMNTX5EcKCY4iMpnLhpQ/Qm4WKwASctpBgBCL ZGaQ== X-Gm-Message-State: AOPr4FVtwMpvf2RTuaYGE62PhIC+cf1FI8NHUVEd73tPYjwh2rttWePxHeZxeVZsaf4AJQ== X-Received: by 10.67.2.41 with SMTP id bl9mr12313328pad.39.1461160719438; Wed, 20 Apr 2016 06:58:39 -0700 (PDT) Received: from linux-7smt.suse (gate-zmy3.freescale.com. [192.88.167.1]) by smtp.gmail.com with ESMTPSA id m186sm37990384pfm.29.2016.04.20.06.58.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 20 Apr 2016 06:58:38 -0700 (PDT) From: Peng Fan To: xen-devel@lists.xen.org Date: Wed, 20 Apr 2016 21:54:23 +0800 Message-Id: <1461160464-2194-1-git-send-email-van.freenix@gmail.com> X-Mailer: git-send-email 2.6.2 Cc: van.freenix@gmail.com, Julien Grall , Stefano Stabellini Subject: [Xen-devel] [PATCH 1/2] xen/arm64: correct comments X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The 'Base address for 4K mapping' is '(x19 >> THIRD_SHIFT) << THIRD_SHIFT'. Also we are building 4K page mapping, not section mapping. Signed-off-by: Peng Fan Cc: Stefano Stabellini Cc: Julien Grall --- xen/arch/arm/arm64/head.S | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 946e2c9..05e3db0 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -471,10 +471,10 @@ skip_bss: ldr x4, =boot_third add x4, x4, x20 /* x4 := paddr (boot_third) */ - lsr x2, x19, #THIRD_SHIFT /* Base address for 4K mapping */ - lsl x2, x2, #THIRD_SHIFT - mov x3, #PT_MEM_L3 /* x2 := Section map */ - orr x2, x2, x3 + lsr x2, x19, #THIRD_SHIFT + lsl x2, x2, #THIRD_SHIFT /* Base address for 4K mapping */ + mov x3, #PT_MEM_L3 + orr x2, x2, x3 /* x2 := Page map */ /* ... map of vaddr(start) in boot_third */ mov x1, xzr