From patchwork Tue May 3 10:55:10 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 9002771 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 89611BF440 for ; Tue, 3 May 2016 10:57:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B18F1201C7 for ; Tue, 3 May 2016 10:57:26 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D10B82021F for ; Tue, 3 May 2016 10:57:25 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1axXzI-0000bf-1U; Tue, 03 May 2016 10:55:32 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1axXzH-0000b0-LI for xen-devel@lists.xenproject.org; Tue, 03 May 2016 10:55:31 +0000 Received: from [85.158.139.211] by server-13.bemta-5.messagelabs.com id 35/88-28710-3A388275; Tue, 03 May 2016 10:55:31 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKIsWRWlGSWpSXmKPExsXitHRDpO6iZo1 wg3Pz1Cy+b5nM5MDocfjDFZYAxijWzLyk/IoE1oyGOUcZC36wV9zbfp2tgXEjWxcjB4eEgL/E gl31XYycHGwCOhIX5+4EC4sIqEjc3msAEmYWKJb4uqqPFcQWFnCSePZtAROIzQJU8n//PkYQm 1fAReLRjNNgcQkBXYmTuzexg4zhFHCVaLwHNkYIqGTmhF42iHJBiZMzn7BAjNeUaN3+mx3Clp do3jqbGaJeUaJ/3gM2iJHcErdPT2WewMg/C0n7LCTts5C0L2BkXsWoXpxaVJZapGusl1SUmZ5 RkpuYmaNraGCql5taXJyYnpqTmFSsl5yfu4kRGHwMQLCDce8/p0OMkhxMSqK8EnfVw4X4kvJT KjMSizPii0pzUosPMcpwcChJ8FY3aYQLCRalpqdWpGXmAOMAJi3BwaMkwtsMkuYtLkjMLc5Mh 0idYlSUEuetB0kIgCQySvPg2mCxd4lRVkqYlxHoECGegtSi3MwSVPlXjOIcjErCvCdBpvBk5p XATX8FtJgJaHH2elWQxSWJCCmpBkYr33159quW759e6eMkxjc/reOtR5DLXla7wk9xDf0zl9T /nC3LpNMVenef/trrdpFmDHqh9rsmvJmz29l2Y1+G7adzHWc7uVktmR58XTqn1KnRx0Z/kueq ojdywZ7Zy+Vv/zzr8nftV705fO1WSReOrNVQv2LNfzPi0suaCYLyz8PPHfjnxqbEUpyRaKjFX FScCADu30gxuAIAAA== X-Env-Sender: prvs=924d4b44a=roger.pau@citrix.com X-Msg-Ref: server-13.tower-206.messagelabs.com!1462272918!33733871!5 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 8.34; banners=-,-,- X-VirusChecked: Checked Received: (qmail 64896 invoked from network); 3 May 2016 10:55:30 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-13.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 3 May 2016 10:55:30 -0000 X-IronPort-AV: E=Sophos;i="5.24,572,1454976000"; d="scan'208";a="351336750" From: Roger Pau Monne To: Date: Tue, 3 May 2016 12:55:10 +0200 Message-ID: <1462272910-41200-7-git-send-email-roger.pau@citrix.com> X-Mailer: git-send-email 2.6.4 (Apple Git-63) In-Reply-To: <1462272910-41200-1-git-send-email-roger.pau@citrix.com> References: <1462272910-41200-1-git-send-email-roger.pau@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: Wei Liu , Ian Jackson , Roger Pau Monne Subject: [Xen-devel] [PATCH v2 for-4.7 6/6] libxl: fix usage of XEN_EOPNOTSUPP X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The errno values returned by libxc are already translated into the underlying OS error space, so it's wrong to compare them against Xen error codes. Signed-off-by: Roger Pau Monné Acked-by: Wei Liu --- Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/libxl_dom_save.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_dom_save.c b/tools/libxl/libxl_dom_save.c index 076be04..579039f 100644 --- a/tools/libxl/libxl_dom_save.c +++ b/tools/libxl/libxl_dom_save.c @@ -386,7 +386,7 @@ void libxl__domain_save(libxl__egc *egc, libxl__domain_save_state *dss) */ ret = xc_domain_getvnuma(CTX->xch, domid, &nr_vnodes, &nr_vmemranges, &nr_vcpus, NULL, NULL, NULL); - if (ret != -1 || errno != XEN_EOPNOTSUPP) { + if (ret != -1 || errno != EOPNOTSUPP) { LOG(ERROR, "Cannot save a guest with vNUMA configured"); rc = ERROR_FAIL; goto out;