From patchwork Mon May 23 11:35:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony PERARD X-Patchwork-Id: 9131615 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 142DE6075F for ; Mon, 23 May 2016 11:39:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 145AF28230 for ; Mon, 23 May 2016 11:39:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0914B28236; Mon, 23 May 2016 11:39:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8CD0428230 for ; Mon, 23 May 2016 11:39:42 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4o9f-00055C-QT; Mon, 23 May 2016 11:36:15 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4o9e-00054V-If for xen-devel@lists.xen.org; Mon, 23 May 2016 11:36:14 +0000 Received: from [85.158.137.68] by server-9.bemta-3.messagelabs.com id 0B/15-03814-D2BE2475; Mon, 23 May 2016 11:36:13 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnkeJIrShJLcpLzFFi42JxWrohUlf3tVO 4wYujIhZLPi5mcWD0OLr7N1MAYxRrZl5SfkUCa8bfsw/YCzoEKt7s+83ewLiZt4uRk0NCwF/i 58nDrCA2m4CBxIrpVxlBbBEBWYnVXXPYuxg5OJgFyiWOHtMFCQsLBEic+TmDCcRmEVCVuPN3D 5jNK+ApMfH9QUaQcgkBOYkr/xJAwpwCXhLfWs8zg9hCQCX/LjyHstUkbixcxgLRKihxcuYTMJ tZQELi4IsXzBCXcUvcPj2VeQIj3ywkZbOQlC1gZFrFqFGcWlSWWqRraKiXVJSZnlGSm5iZo2t oYKyXm1pcnJiempOYVKyXnJ+7iREYUAxAsINx9W+nQ4ySHExKorwndziFC/El5adUZiQWZ8QX leakFh9ilOHgUJLgvfISKCdYlJqeWpGWmQMMbZi0BAePkgjvRJA0b3FBYm5xZjpE6hSjopQ4r +4roIQASCKjNA+uDRZPlxhlpYR5GYEOEeIpSC3KzSxBlX/FKM7BqCTMewtkPE9mXgnc9FdAi5 mAFj+UdgBZXJKIkJJqYNS9OlNk2yKrkyuXnv0QWmdTwXFeflJas2leKJvryS/M2y8L2BacsDz x3SVlrSCHoeGZ+Lus1ftOvN61YS3T6e7cmdOvKMtHW0szG6+2fL6/fPHm//eYmPM2ily6m3Oe +dfbbM/n3+bv+Ba9vmueee7sbqHle2T12D92tuQ9m1IYz11baPad7ZESS3FGoqEWc1FxIgDar xi/ogIAAA== X-Env-Sender: prvs=944f9d766=anthony.perard@citrix.com X-Msg-Ref: server-9.tower-31.messagelabs.com!1464003370!8687869!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 8.34; banners=-,-,- X-VirusChecked: Checked Received: (qmail 1331 invoked from network); 23 May 2016 11:36:12 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-9.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 23 May 2016 11:36:12 -0000 X-IronPort-AV: E=Sophos;i="5.26,355,1459814400"; d="scan'208";a="355908924" From: Anthony PERARD To: Date: Mon, 23 May 2016 12:35:02 +0100 Message-ID: <1464003302-12187-1-git-send-email-anthony.perard@citrix.com> X-Mailer: git-send-email 2.8.2 In-Reply-To: <1463759301-30930-1-git-send-email-anthony.perard@citrix.com> References: <1463759301-30930-1-git-send-email-anthony.perard@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: Anthony PERARD , Wei Liu , Ian Jackson Subject: [Xen-devel] [PATCH] libxl: Do not warn about non existing user for the device model X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Running QEMU as non-root user is not ready yet, so avoid avertising it with a warning. Also improve the doc to include more potential issue with running QEMU as non-root. Signed-off-by: Anthony PERARD --- docs/man/xl.cfg.pod.5 | 5 +++-- docs/misc/qemu-deprivilege.txt | 4 ++-- tools/libxl/libxl_dm.c | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5 index accd9b4..8a4f4c5 100644 --- a/docs/man/xl.cfg.pod.5 +++ b/docs/man/xl.cfg.pod.5 @@ -1953,8 +1953,9 @@ option to the device-model. Run the device model as user "username", instead of B or B or B. -Please note that running QEMU as non-root causes migration and PCI -passthrough not to work properly. +Please note that running QEMU as non-root causes several features like +migration and PCI passthrough to not work properly and may prevent the guest +from booting. =back diff --git a/docs/misc/qemu-deprivilege.txt b/docs/misc/qemu-deprivilege.txt index 879a98e..7751194 100644 --- a/docs/misc/qemu-deprivilege.txt +++ b/docs/misc/qemu-deprivilege.txt @@ -31,5 +31,5 @@ adduser --no-create-home --system xen-qemuuser-shared As a last resort, libxl will start QEMU as root. -Please note that running QEMU as non-root causes migration and PCI -passthrough not to work properly. +Please note that running QEMU as non-root causes several features like migration and +PCI passthrough to not work properly and may prevent the guest from booting. diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index 4aff323a..4248f4c 100644 --- a/tools/libxl/libxl_dm.c +++ b/tools/libxl/libxl_dm.c @@ -1482,7 +1482,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, } user = NULL; - LOG(WARN, "Could not find user %s, starting QEMU as root", + LOG(DEBUG, "Could not find user %s, starting QEMU as root", LIBXL_QEMU_USER_SHARED); end_search: