| Message ID | 1464367072-29262-2-git-send-email-julien.grall@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, May 27, 2016 at 05:37:51PM +0100, Julien Grall wrote: > Convert device-tree debugging to 'Kconfig' as > CONFIG_DEVICE_TREE_DEBUG. > > The option is not enabled by default because the output is very > verbose. > > Signed-off-by: Julien Grall <julien.grall@arm.com> > Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > --- > Changes in v2: > - Fix typoes in the commit message and the Kconfig description > - Update the Kconfig description > - Add Edgar's reviewed-by > > Cc: Andrew Cooper <andrew.cooper3@citrix.com> > Cc: George Dunlap <George.Dunlap@eu.citrix.com> > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > Cc: Jan Beulich <jbeulich@suse.com> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > Cc: Stefano Stabellini <sstabellini@kernel.org> > Cc: Tim Deegan <tim@xen.org> > Cc: Wei Liu <wei.liu2@citrix.com> > Cc: Doug Goldstein <cardoe@cardoe.com> > --- > xen/Kconfig.debug | 8 ++++++++ > xen/arch/arm/domain_build.c | 4 +--- > xen/common/device_tree.c | 4 +--- > 3 files changed, 10 insertions(+), 6 deletions(-) > > diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug > index 303bf36..360c3be 100644 > --- a/xen/Kconfig.debug > +++ b/xen/Kconfig.debug > @@ -55,6 +55,14 @@ config VERBOSE_DEBUG > Guest output from HYPERVISOR_console_io and hypervisor parsing > ELF images (dom0) is logged in the Xen ring buffer. > > +config DEVICE_TREE_DEBUG > + bool "Device tree debug messages" > + depends on HAS_DEVICE_TREE > + ---help--- > + Device tree parsing and DOM0 device tree building messages are > + logged in the Xen ring buffer. > + If unsure, say N here. > + > endif # DEBUG || EXPERT > > endmenu > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 00dc07a..fb035ff 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -42,9 +42,7 @@ static void __init parse_dom0_mem(const char *s) > } > custom_param("dom0_mem", parse_dom0_mem); > > -//#define DEBUG_DT > - > -#ifdef DEBUG_DT > +#ifdef CONFIG_DEVICE_TREE_DEBUG > # define DPRINT(fmt, args...) printk(XENLOG_DEBUG fmt, ##args) > #else > # define DPRINT(fmt, args...) do {} while ( 0 ) > diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c > index 06a2837..0df2e4b 100644 > --- a/xen/common/device_tree.c > +++ b/xen/common/device_tree.c > @@ -54,9 +54,7 @@ struct dt_alias_prop { > > static LIST_HEAD(aliases_lookup); > > -// #define DEBUG_DT > - > -#ifdef DEBUG_DT > +#ifdef CONFIG_DEVICE_TREE_DEBUG > # define dt_dprintk(fmt, args...) printk(XENLOG_DEBUG fmt, ##args) > static void dt_dump_addr(const char *s, const __be32 *addr, int na) > { > -- > 1.9.1 >
diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug index 303bf36..360c3be 100644 --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -55,6 +55,14 @@ config VERBOSE_DEBUG Guest output from HYPERVISOR_console_io and hypervisor parsing ELF images (dom0) is logged in the Xen ring buffer. +config DEVICE_TREE_DEBUG + bool "Device tree debug messages" + depends on HAS_DEVICE_TREE + ---help--- + Device tree parsing and DOM0 device tree building messages are + logged in the Xen ring buffer. + If unsure, say N here. + endif # DEBUG || EXPERT endmenu diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 00dc07a..fb035ff 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -42,9 +42,7 @@ static void __init parse_dom0_mem(const char *s) } custom_param("dom0_mem", parse_dom0_mem); -//#define DEBUG_DT - -#ifdef DEBUG_DT +#ifdef CONFIG_DEVICE_TREE_DEBUG # define DPRINT(fmt, args...) printk(XENLOG_DEBUG fmt, ##args) #else # define DPRINT(fmt, args...) do {} while ( 0 ) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 06a2837..0df2e4b 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -54,9 +54,7 @@ struct dt_alias_prop { static LIST_HEAD(aliases_lookup); -// #define DEBUG_DT - -#ifdef DEBUG_DT +#ifdef CONFIG_DEVICE_TREE_DEBUG # define dt_dprintk(fmt, args...) printk(XENLOG_DEBUG fmt, ##args) static void dt_dump_addr(const char *s, const __be32 *addr, int na) {