From patchwork Fri May 27 16:37:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 9138753 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 877D460467 for ; Fri, 27 May 2016 16:40:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A07027CCD for ; Fri, 27 May 2016 16:40:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6EDE128114; Fri, 27 May 2016 16:40:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 02E6727CCD for ; Fri, 27 May 2016 16:40:17 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b6Klw-0003N9-GW; Fri, 27 May 2016 16:38:04 +0000 Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b6Klv-0003Mi-Mp for xen-devel@lists.xen.org; Fri, 27 May 2016 16:38:03 +0000 Received: from [85.158.143.35] by server-3.bemta-6.messagelabs.com id 1F/53-25713-BE778475; Fri, 27 May 2016 16:38:03 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGLMWRWlGSWpSXmKPExsVysyfVTfdVuUe 4wdlmeYslHxezODB6HN39mymAMYo1My8pvyKBNaNh4lqmgvXCFec2TmBsYNwl0MXIxSEksJFR 4t+VzUwQzmlGiTWf7jF2MXJysAloStz5/IkJxBYRkJa49vkyI0gRs8BKZolj31vZQBLCAnYSa +59YwexWQRUJfpf9oE18Aq4SBx8+J0FxJYQkJM4eWwyaxcjBwengKvEy8nBIGEhoJInT3exTm DkXsDIsIpRvTi1qCy1SNdQL6koMz2jJDcxM0fX0MBMLze1uDgxPTUnMalYLzk/dxMj0L8MQLC Dcedzp0OMkhxMSqK871M9woX4kvJTKjMSizPii0pzUosPMcpwcChJ8P4tA8oJFqWmp1akZeYA Aw0mLcHBoyTCywIMNiHe4oLE3OLMdIjUKUZFKXFeK5CEAEgiozQPrg0W3JcYZaWEeRmBDhHiK Ugtys0sQZV/xSjOwagkzCsOMoUnM68EbvoroMVMQIsXsIAtLklESEk1MJrOc1y35fXuklNqjJ vS33Koh5am+n7IlOVvKw8RypxyY4N1+szQlSEBXeLVCu9bGk/K/ZU+cfDEGifdl74xRb+W/F6 vYiN/neFHxjT9e6/jP3TfTur50r/cZeMErQuPWRQOnXrG23BOLlwoyG35qZTkhKMHjs4vDrpv JrbwxrMHdvvjfDtfNCixFGckGmoxFxUnAgCLW1u4aQIAAA== X-Env-Sender: julien.grall@arm.com X-Msg-Ref: server-13.tower-21.messagelabs.com!1464367082!16355651!1 X-Originating-IP: [217.140.101.70] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked Received: (qmail 58170 invoked from network); 27 May 2016 16:38:02 -0000 Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by server-13.tower-21.messagelabs.com with SMTP; 27 May 2016 16:38:02 -0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2CE315F; Fri, 27 May 2016 09:38:27 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.215.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B67DF3F246; Fri, 27 May 2016 09:37:59 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xen.org Date: Fri, 27 May 2016 17:37:51 +0100 Message-Id: <1464367072-29262-2-git-send-email-julien.grall@arm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1464367072-29262-1-git-send-email-julien.grall@arm.com> References: <1464367072-29262-1-git-send-email-julien.grall@arm.com> Cc: "Edgar E. Iglesias" , sstabellini@kernel.org, Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Julien Grall , Jan Beulich , Doug Goldstein Subject: [Xen-devel] [for-4.8 v2 1/2] xen/arm: Convert DEBUG_DT to Kconfig X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Convert device-tree debugging to 'Kconfig' as CONFIG_DEVICE_TREE_DEBUG. The option is not enabled by default because the output is very verbose. Signed-off-by: Julien Grall Reviewed-by: Edgar E. Iglesias Reviewed-by: Konrad Rzeszutek Wilk --- Changes in v2: - Fix typoes in the commit message and the Kconfig description - Update the Kconfig description - Add Edgar's reviewed-by Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc: Tim Deegan Cc: Wei Liu Cc: Doug Goldstein --- xen/Kconfig.debug | 8 ++++++++ xen/arch/arm/domain_build.c | 4 +--- xen/common/device_tree.c | 4 +--- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug index 303bf36..360c3be 100644 --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -55,6 +55,14 @@ config VERBOSE_DEBUG Guest output from HYPERVISOR_console_io and hypervisor parsing ELF images (dom0) is logged in the Xen ring buffer. +config DEVICE_TREE_DEBUG + bool "Device tree debug messages" + depends on HAS_DEVICE_TREE + ---help--- + Device tree parsing and DOM0 device tree building messages are + logged in the Xen ring buffer. + If unsure, say N here. + endif # DEBUG || EXPERT endmenu diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 00dc07a..fb035ff 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -42,9 +42,7 @@ static void __init parse_dom0_mem(const char *s) } custom_param("dom0_mem", parse_dom0_mem); -//#define DEBUG_DT - -#ifdef DEBUG_DT +#ifdef CONFIG_DEVICE_TREE_DEBUG # define DPRINT(fmt, args...) printk(XENLOG_DEBUG fmt, ##args) #else # define DPRINT(fmt, args...) do {} while ( 0 ) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 06a2837..0df2e4b 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -54,9 +54,7 @@ struct dt_alias_prop { static LIST_HEAD(aliases_lookup); -// #define DEBUG_DT - -#ifdef DEBUG_DT +#ifdef CONFIG_DEVICE_TREE_DEBUG # define dt_dprintk(fmt, args...) printk(XENLOG_DEBUG fmt, ##args) static void dt_dump_addr(const char *s, const __be32 *addr, int na) {