diff mbox

Run autogen.sh

Message ID 1465475285-14777-1-git-send-email-wei.liu2@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wei Liu June 9, 2016, 12:28 p.m. UTC 
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 configure         | 18 +++++++++---------
 docs/configure    | 18 +++++++++---------
 stubdom/configure | 18 +++++++++---------
 tools/configure   | 18 +++++++++---------
 4 files changed, 36 insertions(+), 36 deletions(-)

Comments

Wei Liu June 9, 2016, 12:34 p.m. UTC | #1 
On Thu, Jun 09, 2016 at 01:28:05PM +0100, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  configure         | 18 +++++++++---------
>  docs/configure    | 18 +++++++++---------
>  stubdom/configure | 18 +++++++++---------
>  tools/configure   | 18 +++++++++---------
>  4 files changed, 36 insertions(+), 36 deletions(-)

I'm not sure if this requires review or ack. But I would rather err on
the safe side here.

Wei.
Ian Jackson June 9, 2016, 1:02 p.m. UTC | #2 
Wei Liu writes ("Re: [PATCH] Run autogen.sh"):
> On Thu, Jun 09, 2016 at 01:28:05PM +0100, Wei Liu wrote:
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> >  configure         | 18 +++++++++---------
> >  docs/configure    | 18 +++++++++---------
> >  stubdom/configure | 18 +++++++++---------
> >  tools/configure   | 18 +++++++++---------
> >  4 files changed, 36 insertions(+), 36 deletions(-)
> 
> I'm not sure if this requires review or ack. But I would rather err on
> the safe side here.

Did we forget to run autogen.sh after some recent patch ?  Or is this
of a different version ?

I think some explanation is required.

Ian.
Andrew Cooper June 9, 2016, 1:08 p.m. UTC | #3 
On 09/06/16 14:02, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH] Run autogen.sh"):
>> On Thu, Jun 09, 2016 at 01:28:05PM +0100, Wei Liu wrote:
>>> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>>> ---
>>>  configure         | 18 +++++++++---------
>>>  docs/configure    | 18 +++++++++---------
>>>  stubdom/configure | 18 +++++++++---------
>>>  tools/configure   | 18 +++++++++---------
>>>  4 files changed, 36 insertions(+), 36 deletions(-)
>> I'm not sure if this requires review or ack. But I would rather err on
>> the safe side here.
> Did we forget to run autogen.sh after some recent patch ?

Yes - your patch changing the version number from 4.7 to 4.8 and opening
unstable again for general contribution.

~Andrew
Olaf Hering June 9, 2016, 1:34 p.m. UTC | #4 
On Thu, Jun 09, Andrew Cooper wrote:

> Yes - your patch changing the version number from 4.7 to 4.8 and opening
> unstable again for general contribution.

This also means pkgconfig(xenlight) should report itself as 4.8.
As suggested by Roger the SONAME in tools/libxl should be bumped at some
point after RELEASE-4.7.0 was tagged, or now that staging is open again.

Olaf
Wei Liu June 9, 2016, 2:10 p.m. UTC | #5 
On Thu, Jun 09, 2016 at 02:02:00PM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH] Run autogen.sh"):
> > On Thu, Jun 09, 2016 at 01:28:05PM +0100, Wei Liu wrote:
> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > > ---
> > >  configure         | 18 +++++++++---------
> > >  docs/configure    | 18 +++++++++---------
> > >  stubdom/configure | 18 +++++++++---------
> > >  tools/configure   | 18 +++++++++---------
> > >  4 files changed, 36 insertions(+), 36 deletions(-)
> > 
> > I'm not sure if this requires review or ack. But I would rather err on
> > the safe side here.
> 
> Did we forget to run autogen.sh after some recent patch ?  Or is this
> of a different version ?
> 
> I think some explanation is required.
> 

You patch to open 4.8 didn't update output from autogen.sh.

Maybe running autogen.sh should become part of the branching checklist.

Wei.

> Ian.
Wei Liu June 9, 2016, 2:19 p.m. UTC | #6 
On Thu, Jun 09, 2016 at 03:34:02PM +0200, Olaf Hering wrote:
> On Thu, Jun 09, Andrew Cooper wrote:
> 
> > Yes - your patch changing the version number from 4.7 to 4.8 and opening
> > unstable again for general contribution.
> 
> This also means pkgconfig(xenlight) should report itself as 4.8.
> As suggested by Roger the SONAME in tools/libxl should be bumped at some
> point after RELEASE-4.7.0 was tagged, or now that staging is open again.
> 

I'm waiting for Ian's reply to that thread. We haven't come to a
conclusion whether we should bump the number at the beginning of the
release.

But I think it would be quite safe to bump libxl and libxc, so I don't
mind doing that.

Wei.

> Olaf
Ian Jackson June 9, 2016, 2:55 p.m. UTC | #7 
Wei Liu writes ("Re: [PATCH] Run autogen.sh"):
> On Thu, Jun 09, 2016 at 02:02:00PM +0100, Ian Jackson wrote:
> > Did we forget to run autogen.sh after some recent patch ?  Or is this
> > of a different version ?
> > 
> > I think some explanation is required.
> 
> You patch to open 4.8 didn't update output from autogen.sh.

Ah, sorry.  I think the requirement to do this is fairly new.

The reason should be explained in the commit message.  With some
suitable message,

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

> Maybe running autogen.sh should become part of the branching checklist.

Noted in the checklist.

Ian.
Wei Liu June 9, 2016, 3 p.m. UTC | #8 
On Thu, Jun 09, 2016 at 03:55:43PM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH] Run autogen.sh"):
> > On Thu, Jun 09, 2016 at 02:02:00PM +0100, Ian Jackson wrote:
> > > Did we forget to run autogen.sh after some recent patch ?  Or is this
> > > of a different version ?
> > > 
> > > I think some explanation is required.
> > 
> > You patch to open 4.8 didn't update output from autogen.sh.
> 
> Ah, sorry.  I think the requirement to do this is fairly new.
> 
> The reason should be explained in the commit message.  With some
> suitable message,
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 

Thanks.

I will update the commit message as followed:

    In 936a7a54 ("Open Xen 4.8-unstable), output of autogen.sh was not
    included. The configure scripts still referred to 4.7.
    
    Run autogen.sh and commit the result.
Ian Jackson June 9, 2016, 3:45 p.m. UTC | #9 
Wei Liu writes ("Re: [Xen-devel] [PATCH] Run autogen.sh"):
> I'm waiting for Ian's reply to that thread. We haven't come to a
> conclusion whether we should bump the number at the beginning of the
> release.

For all the libraries whose version number is currently 4.7 I'm happy
for them to be bumped now, and I think that woudl be a good idea.

Ian.
Wei Liu June 9, 2016, 3:47 p.m. UTC | #10 
On Thu, Jun 09, 2016 at 04:45:15PM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [Xen-devel] [PATCH] Run autogen.sh"):
> > I'm waiting for Ian's reply to that thread. We haven't come to a
> > conclusion whether we should bump the number at the beginning of the
> > release.
> 
> For all the libraries whose version number is currently 4.7 I'm happy
> for them to be bumped now, and I think that woudl be a good idea.
> 

OK. I will prepare a patch for that.

Wei.

> Ian.
diff mbox

Patch

diff --git a/configure b/configure
index 8b07126..ebc55ad 100755
--- a/configure
+++ b/configure
@@ -1,6 +1,6 @@ 
 #! /bin/sh
 # Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.69 for Xen Hypervisor 4.7.
+# Generated by GNU Autoconf 2.69 for Xen Hypervisor 4.8.
 #
 # Report bugs to <xen-devel@lists.xen.org>.
 #
@@ -579,8 +579,8 @@  MAKEFLAGS=
 # Identity of this package.
 PACKAGE_NAME='Xen Hypervisor'
 PACKAGE_TARNAME='xen'
-PACKAGE_VERSION='4.7'
-PACKAGE_STRING='Xen Hypervisor 4.7'
+PACKAGE_VERSION='4.8'
+PACKAGE_STRING='Xen Hypervisor 4.8'
 PACKAGE_BUGREPORT='xen-devel@lists.xen.org'
 PACKAGE_URL='http://www.xen.org/'
 
@@ -1217,7 +1217,7 @@  if test "$ac_init_help" = "long"; then
   # Omit some internal or obsolete options to make the list less imposing.
   # This message is too long to be a string in the A/UX 3.1 sh.
   cat <<_ACEOF
-\`configure' configures Xen Hypervisor 4.7 to adapt to many kinds of systems.
+\`configure' configures Xen Hypervisor 4.8 to adapt to many kinds of systems.
 
 Usage: $0 [OPTION]... [VAR=VALUE]...
 
@@ -1282,7 +1282,7 @@  fi
 
 if test -n "$ac_init_help"; then
   case $ac_init_help in
-     short | recursive ) echo "Configuration of Xen Hypervisor 4.7:";;
+     short | recursive ) echo "Configuration of Xen Hypervisor 4.8:";;
    esac
   cat <<\_ACEOF
 
@@ -1376,7 +1376,7 @@  fi
 test -n "$ac_init_help" && exit $ac_status
 if $ac_init_version; then
   cat <<\_ACEOF
-Xen Hypervisor configure 4.7
+Xen Hypervisor configure 4.8
 generated by GNU Autoconf 2.69
 
 Copyright (C) 2012 Free Software Foundation, Inc.
@@ -1393,7 +1393,7 @@  cat >config.log <<_ACEOF
 This file contains any messages produced by compilers while
 running configure, to aid debugging if configure makes a mistake.
 
-It was created by Xen Hypervisor $as_me 4.7, which was
+It was created by Xen Hypervisor $as_me 4.8, which was
 generated by GNU Autoconf 2.69.  Invocation command line was
 
   $ $0 $@
@@ -2794,7 +2794,7 @@  cat >>$CONFIG_STATUS <<\_ACEOF || ac_write_fail=1
 # report actual input values of CONFIG_FILES etc. instead of their
 # values after options handling.
 ac_log="
-This file was extended by Xen Hypervisor $as_me 4.7, which was
+This file was extended by Xen Hypervisor $as_me 4.8, which was
 generated by GNU Autoconf 2.69.  Invocation command line was
 
   CONFIG_FILES    = $CONFIG_FILES
@@ -2848,7 +2848,7 @@  _ACEOF
 cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"
 ac_cs_version="\\
-Xen Hypervisor config.status 4.7
+Xen Hypervisor config.status 4.8
 configured by $0, generated by GNU Autoconf 2.69,
   with options \\"\$ac_cs_config\\"
 
diff --git a/docs/configure b/docs/configure
index 642c754..fbb78ac 100755
--- a/docs/configure
+++ b/docs/configure
@@ -1,6 +1,6 @@ 
 #! /bin/sh
 # Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.69 for Xen Hypervisor Documentation 4.7.
+# Generated by GNU Autoconf 2.69 for Xen Hypervisor Documentation 4.8.
 #
 # Report bugs to <xen-devel@lists.xen.org>.
 #
@@ -579,8 +579,8 @@  MAKEFLAGS=
 # Identity of this package.
 PACKAGE_NAME='Xen Hypervisor Documentation'
 PACKAGE_TARNAME='xen'
-PACKAGE_VERSION='4.7'
-PACKAGE_STRING='Xen Hypervisor Documentation 4.7'
+PACKAGE_VERSION='4.8'
+PACKAGE_STRING='Xen Hypervisor Documentation 4.8'
 PACKAGE_BUGREPORT='xen-devel@lists.xen.org'
 PACKAGE_URL='http://www.xen.org/'
 
@@ -1186,7 +1186,7 @@  if test "$ac_init_help" = "long"; then
   # Omit some internal or obsolete options to make the list less imposing.
   # This message is too long to be a string in the A/UX 3.1 sh.
   cat <<_ACEOF
-\`configure' configures Xen Hypervisor Documentation 4.7 to adapt to many kinds of systems.
+\`configure' configures Xen Hypervisor Documentation 4.8 to adapt to many kinds of systems.
 
 Usage: $0 [OPTION]... [VAR=VALUE]...
 
@@ -1247,7 +1247,7 @@  fi
 
 if test -n "$ac_init_help"; then
   case $ac_init_help in
-     short | recursive ) echo "Configuration of Xen Hypervisor Documentation 4.7:";;
+     short | recursive ) echo "Configuration of Xen Hypervisor Documentation 4.8:";;
    esac
   cat <<\_ACEOF
 
@@ -1327,7 +1327,7 @@  fi
 test -n "$ac_init_help" && exit $ac_status
 if $ac_init_version; then
   cat <<\_ACEOF
-Xen Hypervisor Documentation configure 4.7
+Xen Hypervisor Documentation configure 4.8
 generated by GNU Autoconf 2.69
 
 Copyright (C) 2012 Free Software Foundation, Inc.
@@ -1344,7 +1344,7 @@  cat >config.log <<_ACEOF
 This file contains any messages produced by compilers while
 running configure, to aid debugging if configure makes a mistake.
 
-It was created by Xen Hypervisor Documentation $as_me 4.7, which was
+It was created by Xen Hypervisor Documentation $as_me 4.8, which was
 generated by GNU Autoconf 2.69.  Invocation command line was
 
   $ $0 $@
@@ -2628,7 +2628,7 @@  cat >>$CONFIG_STATUS <<\_ACEOF || ac_write_fail=1
 # report actual input values of CONFIG_FILES etc. instead of their
 # values after options handling.
 ac_log="
-This file was extended by Xen Hypervisor Documentation $as_me 4.7, which was
+This file was extended by Xen Hypervisor Documentation $as_me 4.8, which was
 generated by GNU Autoconf 2.69.  Invocation command line was
 
   CONFIG_FILES    = $CONFIG_FILES
@@ -2682,7 +2682,7 @@  _ACEOF
 cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"
 ac_cs_version="\\
-Xen Hypervisor Documentation config.status 4.7
+Xen Hypervisor Documentation config.status 4.8
 configured by $0, generated by GNU Autoconf 2.69,
   with options \\"\$ac_cs_config\\"
 
diff --git a/stubdom/configure b/stubdom/configure
index 5b9c609..29e90af 100755
--- a/stubdom/configure
+++ b/stubdom/configure
@@ -1,6 +1,6 @@ 
 #! /bin/sh
 # Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.69 for Xen Hypervisor Stub Domains 4.7.
+# Generated by GNU Autoconf 2.69 for Xen Hypervisor Stub Domains 4.8.
 #
 # Report bugs to <xen-devel@lists.xen.org>.
 #
@@ -579,8 +579,8 @@  MAKEFLAGS=
 # Identity of this package.
 PACKAGE_NAME='Xen Hypervisor Stub Domains'
 PACKAGE_TARNAME='xen'
-PACKAGE_VERSION='4.7'
-PACKAGE_STRING='Xen Hypervisor Stub Domains 4.7'
+PACKAGE_VERSION='4.8'
+PACKAGE_STRING='Xen Hypervisor Stub Domains 4.8'
 PACKAGE_BUGREPORT='xen-devel@lists.xen.org'
 PACKAGE_URL='http://www.xen.org/'
 
@@ -1250,7 +1250,7 @@  if test "$ac_init_help" = "long"; then
   # Omit some internal or obsolete options to make the list less imposing.
   # This message is too long to be a string in the A/UX 3.1 sh.
   cat <<_ACEOF
-\`configure' configures Xen Hypervisor Stub Domains 4.7 to adapt to many kinds of systems.
+\`configure' configures Xen Hypervisor Stub Domains 4.8 to adapt to many kinds of systems.
 
 Usage: $0 [OPTION]... [VAR=VALUE]...
 
@@ -1315,7 +1315,7 @@  fi
 
 if test -n "$ac_init_help"; then
   case $ac_init_help in
-     short | recursive ) echo "Configuration of Xen Hypervisor Stub Domains 4.7:";;
+     short | recursive ) echo "Configuration of Xen Hypervisor Stub Domains 4.8:";;
    esac
   cat <<\_ACEOF
 
@@ -1425,7 +1425,7 @@  fi
 test -n "$ac_init_help" && exit $ac_status
 if $ac_init_version; then
   cat <<\_ACEOF
-Xen Hypervisor Stub Domains configure 4.7
+Xen Hypervisor Stub Domains configure 4.8
 generated by GNU Autoconf 2.69
 
 Copyright (C) 2012 Free Software Foundation, Inc.
@@ -1480,7 +1480,7 @@  cat >config.log <<_ACEOF
 This file contains any messages produced by compilers while
 running configure, to aid debugging if configure makes a mistake.
 
-It was created by Xen Hypervisor Stub Domains $as_me 4.7, which was
+It was created by Xen Hypervisor Stub Domains $as_me 4.8, which was
 generated by GNU Autoconf 2.69.  Invocation command line was
 
   $ $0 $@
@@ -4178,7 +4178,7 @@  cat >>$CONFIG_STATUS <<\_ACEOF || ac_write_fail=1
 # report actual input values of CONFIG_FILES etc. instead of their
 # values after options handling.
 ac_log="
-This file was extended by Xen Hypervisor Stub Domains $as_me 4.7, which was
+This file was extended by Xen Hypervisor Stub Domains $as_me 4.8, which was
 generated by GNU Autoconf 2.69.  Invocation command line was
 
   CONFIG_FILES    = $CONFIG_FILES
@@ -4232,7 +4232,7 @@  _ACEOF
 cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"
 ac_cs_version="\\
-Xen Hypervisor Stub Domains config.status 4.7
+Xen Hypervisor Stub Domains config.status 4.8
 configured by $0, generated by GNU Autoconf 2.69,
   with options \\"\$ac_cs_config\\"
 
diff --git a/tools/configure b/tools/configure
index 2fde4f4..a80f132 100755
--- a/tools/configure
+++ b/tools/configure
@@ -1,6 +1,6 @@ 
 #! /bin/sh
 # Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.69 for Xen Hypervisor Tools 4.7.
+# Generated by GNU Autoconf 2.69 for Xen Hypervisor Tools 4.8.
 #
 # Report bugs to <xen-devel@lists.xen.org>.
 #
@@ -580,8 +580,8 @@  MAKEFLAGS=
 # Identity of this package.
 PACKAGE_NAME='Xen Hypervisor Tools'
 PACKAGE_TARNAME='xen'
-PACKAGE_VERSION='4.7'
-PACKAGE_STRING='Xen Hypervisor Tools 4.7'
+PACKAGE_VERSION='4.8'
+PACKAGE_STRING='Xen Hypervisor Tools 4.8'
 PACKAGE_BUGREPORT='xen-devel@lists.xen.org'
 PACKAGE_URL='http://www.xen.org/'
 
@@ -1391,7 +1391,7 @@  if test "$ac_init_help" = "long"; then
   # Omit some internal or obsolete options to make the list less imposing.
   # This message is too long to be a string in the A/UX 3.1 sh.
   cat <<_ACEOF
-\`configure' configures Xen Hypervisor Tools 4.7 to adapt to many kinds of systems.
+\`configure' configures Xen Hypervisor Tools 4.8 to adapt to many kinds of systems.
 
 Usage: $0 [OPTION]... [VAR=VALUE]...
 
@@ -1456,7 +1456,7 @@  fi
 
 if test -n "$ac_init_help"; then
   case $ac_init_help in
-     short | recursive ) echo "Configuration of Xen Hypervisor Tools 4.7:";;
+     short | recursive ) echo "Configuration of Xen Hypervisor Tools 4.8:";;
    esac
   cat <<\_ACEOF
 
@@ -1644,7 +1644,7 @@  fi
 test -n "$ac_init_help" && exit $ac_status
 if $ac_init_version; then
   cat <<\_ACEOF
-Xen Hypervisor Tools configure 4.7
+Xen Hypervisor Tools configure 4.8
 generated by GNU Autoconf 2.69
 
 Copyright (C) 2012 Free Software Foundation, Inc.
@@ -2059,7 +2059,7 @@  cat >config.log <<_ACEOF
 This file contains any messages produced by compilers while
 running configure, to aid debugging if configure makes a mistake.
 
-It was created by Xen Hypervisor Tools $as_me 4.7, which was
+It was created by Xen Hypervisor Tools $as_me 4.8, which was
 generated by GNU Autoconf 2.69.  Invocation command line was
 
   $ $0 $@
@@ -10173,7 +10173,7 @@  cat >>$CONFIG_STATUS <<\_ACEOF || ac_write_fail=1
 # report actual input values of CONFIG_FILES etc. instead of their
 # values after options handling.
 ac_log="
-This file was extended by Xen Hypervisor Tools $as_me 4.7, which was
+This file was extended by Xen Hypervisor Tools $as_me 4.8, which was
 generated by GNU Autoconf 2.69.  Invocation command line was
 
   CONFIG_FILES    = $CONFIG_FILES
@@ -10236,7 +10236,7 @@  _ACEOF
 cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"
 ac_cs_version="\\
-Xen Hypervisor Tools config.status 4.7
+Xen Hypervisor Tools config.status 4.8
 configured by $0, generated by GNU Autoconf 2.69,
   with options \\"\$ac_cs_config\\"