| Message ID | 1465804155-14469-15-git-send-email-wei.liu2@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Wei Liu writes ("[PATCH 14/17] ocaml/libxs: generate a paths.ml"):
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
FAOD I don't consider myself qualified to review this.
Ian.
On Mon, Jun 13, 2016 at 04:19:59PM +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH 14/17] ocaml/libxs: generate a paths.ml"): > > Signed-off-by: Wei Liu <wei.liu2@citrix.com> > > FAOD I don't consider myself qualified to review this. > David gave his ack to a similar path so I presume he will be fine with this, too. I will wait for his ack anyway. Wei. > Ian.
> On 13 Jun 2016, at 16:22, Wei Liu <wei.liu2@citrix.com> wrote: > > On Mon, Jun 13, 2016 at 04:19:59PM +0100, Ian Jackson wrote: >> Wei Liu writes ("[PATCH 14/17] ocaml/libxs: generate a paths.ml"): >>> Signed-off-by: Wei Liu <wei.liu2@citrix.com> >> >> FAOD I don't consider myself qualified to review this. >> > > David gave his ack to a similar path so I presume he will be fine with > this, too. > > I will wait for his ack anyway. Looks fine to me. Acked-by: David Scott <dave@recoil.org> Cheers, Dave
On Mon, Jun 13, 2016 at 08:50:02PM +0100, David Scott wrote: > > > On 13 Jun 2016, at 16:22, Wei Liu <wei.liu2@citrix.com> wrote: > > > > On Mon, Jun 13, 2016 at 04:19:59PM +0100, Ian Jackson wrote: > >> Wei Liu writes ("[PATCH 14/17] ocaml/libxs: generate a paths.ml"): > >>> Signed-off-by: Wei Liu <wei.liu2@citrix.com> > >> > >> FAOD I don't consider myself qualified to review this. > >> > > > > David gave his ack to a similar path so I presume he will be fine with > > this, too. > > > > I will wait for his ack anyway. > > Looks fine to me. > > Acked-by: David Scott <dave@recoil.org> > Thanks. FAOD: I think this ack is only for this patch. I will hold off pushing this one and wait until other ocaml patches are acked. Wei. > Cheers, > Dave
> On 14 Jun 2016, at 10:36, Wei Liu <wei.liu2@citrix.com> wrote: > > On Mon, Jun 13, 2016 at 08:50:02PM +0100, David Scott wrote: >> >>> On 13 Jun 2016, at 16:22, Wei Liu <wei.liu2@citrix.com> wrote: >>> >>> On Mon, Jun 13, 2016 at 04:19:59PM +0100, Ian Jackson wrote: >>>> Wei Liu writes ("[PATCH 14/17] ocaml/libxs: generate a paths.ml"): >>>>> Signed-off-by: Wei Liu <wei.liu2@citrix.com> >>>> >>>> FAOD I don't consider myself qualified to review this. >>>> >>> >>> David gave his ack to a similar path so I presume he will be fine with >>> this, too. >>> >>> I will wait for his ack anyway. >> >> Looks fine to me. >> >> Acked-by: David Scott <dave@recoil.org> >> > > Thanks. > > FAOD: I think this ack is only for this patch. I will hold off pushing > this one and wait until other ocaml patches are asked. I think I’ve acked the rest — let me know if I missed one :) Cheers, Dave > > Wei. > >> Cheers, >> Dave >
On Tue, Jun 14, 2016 at 09:08:59PM +0100, David Scott wrote: > > > On 14 Jun 2016, at 10:36, Wei Liu <wei.liu2@citrix.com> wrote: > > > > On Mon, Jun 13, 2016 at 08:50:02PM +0100, David Scott wrote: > >> > >>> On 13 Jun 2016, at 16:22, Wei Liu <wei.liu2@citrix.com> wrote: > >>> > >>> On Mon, Jun 13, 2016 at 04:19:59PM +0100, Ian Jackson wrote: > >>>> Wei Liu writes ("[PATCH 14/17] ocaml/libxs: generate a paths.ml"): > >>>>> Signed-off-by: Wei Liu <wei.liu2@citrix.com> > >>>> > >>>> FAOD I don't consider myself qualified to review this. > >>>> > >>> > >>> David gave his ack to a similar path so I presume he will be fine with > >>> this, too. > >>> > >>> I will wait for his ack anyway. > >> > >> Looks fine to me. > >> > >> Acked-by: David Scott <dave@recoil.org> > >> > > > > Thanks. > > > > FAOD: I think this ack is only for this patch. I will hold off pushing > > this one and wait until other ocaml patches are asked. > > I think I’ve acked the rest — let me know if I missed one :) > Thanks. I think that's all I need for this series. Wei. > Cheers, > Dave > > > > > Wei. > > > >> Cheers, > >> Dave > > >
diff --git a/.gitignore b/.gitignore index 8e0a177..5914bbe 100644 --- a/.gitignore +++ b/.gitignore @@ -348,6 +348,7 @@ tools/ocaml/libs/xl/xenlight.mli tools/ocaml/libs/xentoollog/_xtl_levels.* tools/ocaml/libs/xentoollog/xentoollog.ml tools/ocaml/libs/xentoollog/xentoollog.mli +tools/ocaml/libs/xs/paths.ml tools/ocaml/xenstored/oxenstored tools/ocaml/xenstored/oxenstored.conf tools/ocaml/xenstored/paths.ml diff --git a/tools/ocaml/libs/xs/Makefile b/tools/ocaml/libs/xs/Makefile index 7a3d886..572efb7 100644 --- a/tools/ocaml/libs/xs/Makefile +++ b/tools/ocaml/libs/xs/Makefile @@ -11,7 +11,7 @@ OCAMLOPTFLAGS += -for-pack Xenstore PREINTF = xsraw.cmi xst.cmi PREOBJS = queueop xsraw xst PRELIBS = $(foreach obj, $(PREOBJS),$(obj).cmo) $(foreach obj,$(PREOJBS),$(obj).cmx) -OBJS = queueop xsraw xst xs +OBJS = paths queueop xsraw xst xs INTF = xsraw.cmi xst.cmi xs.cmi LIBS = xenstore.cma xenstore.cmxa @@ -45,3 +45,7 @@ uninstall: include $(TOPLEVEL)/Makefile.rules +genpath-target = $(call buildmakevars2module,paths.ml) +$(eval $(genpath-target)) + +GENERATED_FILES += paths.ml
Signed-off-by: Wei Liu <wei.liu2@citrix.com> --- Cc: Ian Jackson <ian.jackson@eu.citrix.com> Cc: David Scot <dave@recoil.org> --- .gitignore | 1 + tools/ocaml/libs/xs/Makefile | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-)