diff mbox

tests: fix CPUID detection tests compilation failure

Message ID 1465809101-6341-1-git-send-email-wei.liu2@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wei Liu June 13, 2016, 9:11 a.m. UTC
In 3704b9003 ("tests: Add CPU detection tests"), a macro called
DO_TEST_CPUID_JSON is added. But it took only two arguments when QEMU
or YAJL is not set.

Fix it by adding a third argument. Shouldn't have any effect because
that macro compiles to nothing.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Jiri Denemark <jdenemar@redhat.com>

For error: see
http://logs.test-lab.xenproject.org/osstest/logs/95577/build-amd64-libvirt/5.ts-libvirt-build.log
---
 tests/cputest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jiri Denemark June 13, 2016, 10:26 a.m. UTC | #1
On Mon, Jun 13, 2016 at 10:11:41 +0100, Wei Liu wrote:
> In 3704b9003 ("tests: Add CPU detection tests"), a macro called
> DO_TEST_CPUID_JSON is added. But it took only two arguments when QEMU
> or YAJL is not set.
> 
> Fix it by adding a third argument. Shouldn't have any effect because
> that macro compiles to nothing.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: Jiri Denemark <jdenemar@redhat.com>
> 
> For error: see
> http://logs.test-lab.xenproject.org/osstest/logs/95577/build-amd64-libvirt/5.ts-libvirt-build.log
> ---
>  tests/cputest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/cputest.c b/tests/cputest.c
> index f68a3ec..c374ddf 100644
> --- a/tests/cputest.c
> +++ b/tests/cputest.c
> @@ -700,7 +700,7 @@ mymain(void)
>          }                                                               \
>      } while (0)
>  #else
> -# define DO_TEST_CPUID_JSON(arch, host)
> +# define DO_TEST_CPUID_JSON(arch, host, json)
>  #endif
>  
>  #define DO_TEST_CPUID(arch, host, json)                                 \

Oops, thanks for fixing this. ACK and pushed.

Jirka
diff mbox

Patch

diff --git a/tests/cputest.c b/tests/cputest.c
index f68a3ec..c374ddf 100644
--- a/tests/cputest.c
+++ b/tests/cputest.c
@@ -700,7 +700,7 @@  mymain(void)
         }                                                               \
     } while (0)
 #else
-# define DO_TEST_CPUID_JSON(arch, host)
+# define DO_TEST_CPUID_JSON(arch, host, json)
 #endif
 
 #define DO_TEST_CPUID(arch, host, json)                                 \