From patchwork Tue Jul 5 14:26:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corneliu ZUZU X-Patchwork-Id: 9214329 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A2B336048F for ; Tue, 5 Jul 2016 14:28:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9421122F4A for ; Tue, 5 Jul 2016 14:28:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 88C9823B3C; Tue, 5 Jul 2016 14:28:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1E90222F4A for ; Tue, 5 Jul 2016 14:28:51 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKRJG-0006EQ-0N; Tue, 05 Jul 2016 14:26:46 +0000 Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKRJE-0006EH-TL for xen-devel@lists.xen.org; Tue, 05 Jul 2016 14:26:45 +0000 Received: from [85.158.143.35] by server-1.bemta-6.messagelabs.com id A1/11-09256-4A3CB775; Tue, 05 Jul 2016 14:26:44 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRWlGSWpSXmKPExsUSfTxjoe7iw9X hBtPWm1gs+biYxYHR4+ju30wBjFGsmXlJ+RUJrBkLzhxhKvjAXfH3yi6mBsZOzi5GDg4hAXeJ tlkBXYxcQOYaRonNS24yQzgnGSUWvXzB1MXICVa0adEaFojEOkaJuyd+giXYBLQlzh26B2aLC EhLXPt8mRGkiFlgNqPE94NPWUESwgLOEi0fLrKB2CwCqhJfHq5jAbF5BVwlehffZQY5Q0JATm LBhXSQMKeAm8Tz15dYIRa7SjSdfMcMYksI5Egc//GTDaJcSuJ/qxLIKgmBbhaJhq9/mSBqZCQ eTbzJNoFRaAEjwypG9eLUorLUIl0jvaSizPSMktzEzBxdQwMzvdzU4uLE9NScxKRiveT83E2M wDBkAIIdjMv+Oh1ilORgUhLllV1aHS7El5SfUpmRWJwRX1Sak1p8iFGGg0NJgvfpIaCcYFFqe mpFWmYOMCJg0hIcPEoivJdA0rzFBYm5xZnpEKlTjIpS4rwHQRICIImM0jy4NlgUXmKUlRLmZQ Q6RIinILUoN7MEVf4VozgHo5IwryAwpoV4MvNK4Ka/AlrMBLT4pwvY4pJEhJRUA+Pm21fVLgv m7X4q85B/sqzlwTm2HBy8Jleqpn9WmBG2UWuy/bWlV12ynO9vyur3dVWYaCv2oul4mc3BM5V2 PT1mzElrObsZTke8q3137UzmucgttxUOuIc9fCUz76z8nIsFoj9EbK8LaCbxSlbkLAv7ez7/9 n635JWbDVy0E1dFb3541cx6o6ISS3FGoqEWc1FxIgAgAIcMvQIAAA== X-Env-Sender: czuzu@bitdefender.com X-Msg-Ref: server-7.tower-21.messagelabs.com!1467728803!22489470!1 X-Originating-IP: [91.199.104.161] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked Received: (qmail 38006 invoked from network); 5 Jul 2016 14:26:43 -0000 Received: from mx01.bbu.dsd.mx.bitdefender.com (HELO mx01.bbu.dsd.mx.bitdefender.com) (91.199.104.161) by server-7.tower-21.messagelabs.com with DHE-RSA-AES128-GCM-SHA256 encrypted SMTP; 5 Jul 2016 14:26:43 -0000 Received: (qmail 18535 invoked from network); 5 Jul 2016 17:26:39 +0300 Received: from unknown (HELO mx-sr.buh.bitdefender.com) (10.17.80.103) by mx01.bbu.dsd.mx.bitdefender.com with AES256-GCM-SHA384 encrypted SMTP; 5 Jul 2016 17:26:39 +0300 Received: from smtp01.buh.bitdefender.com (unknown [10.17.80.75]) by mx-sr.buh.bitdefender.com (Postfix) with ESMTP id 711AE7FBEF for ; Tue, 5 Jul 2016 17:26:39 +0300 (EEST) Received: (qmail 11203 invoked from network); 5 Jul 2016 17:26:39 +0300 Received: from 188-24-34-246.rdsnet.ro (HELO localhost.localdomain) (czuzu@bitdefender.com@188.24.34.246) by smtp01.buh.bitdefender.com with SMTP; 5 Jul 2016 17:26:39 +0300 From: Corneliu ZUZU To: xen-devel@lists.xen.org Date: Tue, 5 Jul 2016 17:26:34 +0300 Message-Id: <1467728794-13638-1-git-send-email-czuzu@bitdefender.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1467728717-13592-1-git-send-email-czuzu@bitdefender.com> References: <1467728717-13592-1-git-send-email-czuzu@bitdefender.com> X-BitDefender-Scanner: Clean, Agent: BitDefender qmail 3.1.6 on smtp01.buh.bitdefender.com, sigver: 7.66188 X-BitDefender-Spam: No (0) X-BitDefender-SpamStamp: Build: [Engines: 2.15.6.911, Dats: 425435, Stamp: 3], Multi: [Enabled, t: (0.000009, 0.001845)], BW: [Enabled, t: (0.000007,0.000001)], RBL DNSBL: [Disabled], APM: [Enabled, Score: 500, t: (0.002363), Flags: BB9BAF5C; NN_NO_CONTENT_TYPE; NN_NO_LINK_NMD; NN_LEGIT_BITDEFENDER; NN_LEGIT_S_SQARE_BRACKETS; NN_LEGIT_MAILING_LIST_TO], SGN: [Enabled, t: (0.006547)], URL: [Enabled, t: (0.000005)], RTDA: [Enabled, t: (0.124775), Hit: No, Details: v2.3.10; Id: 2m1ghic.1aml0sh1c.crs7], total: 0(775) X-BitDefender-CF-Stamp: none Cc: Andrew Cooper , Kevin Tian , Jan Beulich , Jun Nakajima Subject: [Xen-devel] [PATCH v2 1/7] x86/vmx_update_guest_cr: minor optimization X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Minor optimization @ vmx_update_guest_cr: checks if v->arch.hvm_vmx.exec_control was modified before actually calling vmx_update_cpu_exec_control(v). Signed-off-by: Corneliu ZUZU --- Changed since v1: --- xen/arch/x86/hvm/vmx/vmx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index df19579..8ab074f 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -1434,8 +1434,10 @@ static void vmx_update_guest_cr(struct vcpu *v, unsigned int cr) if ( paging_mode_hap(v->domain) ) { /* Manage GUEST_CR3 when CR0.PE=0. */ + uint32_t old_ctls = v->arch.hvm_vmx.exec_control; uint32_t cr3_ctls = (CPU_BASED_CR3_LOAD_EXITING | CPU_BASED_CR3_STORE_EXITING); + v->arch.hvm_vmx.exec_control &= ~cr3_ctls; if ( !hvm_paging_enabled(v) && !vmx_unrestricted_guest(v) ) v->arch.hvm_vmx.exec_control |= cr3_ctls; @@ -1445,7 +1447,8 @@ static void vmx_update_guest_cr(struct vcpu *v, unsigned int cr) monitor_ctrlreg_bitmask(VM_EVENT_X86_CR3) ) v->arch.hvm_vmx.exec_control |= CPU_BASED_CR3_LOAD_EXITING; - vmx_update_cpu_exec_control(v); + if ( old_ctls != v->arch.hvm_vmx.exec_control ) + vmx_update_cpu_exec_control(v); } if ( !nestedhvm_vcpu_in_guestmode(v) )