From patchwork Fri Jul 8 18:25:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 9221659 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EF68D60467 for ; Fri, 8 Jul 2016 18:28:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E4AAC28375 for ; Fri, 8 Jul 2016 18:28:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D95082837F; Fri, 8 Jul 2016 18:28:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 810852836F for ; Fri, 8 Jul 2016 18:28:52 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bLaUA-0003q4-4p; Fri, 08 Jul 2016 18:26:46 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bLaU9-0003pN-4z for xen-devel@lists.xenproject.org; Fri, 08 Jul 2016 18:26:45 +0000 Received: from [85.158.139.211] by server-5.bemta-5.messagelabs.com id E7/86-07189-460FF775; Fri, 08 Jul 2016 18:26:44 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRWlGSWpSXmKPExsXitHRDpG7Kh/p wg/2yFt+3TGZyYPQ4/OEKSwBjFGtmXlJ+RQJrxs1Td9gK3rBVXPl9j6mBcSZrFyMnh4SAv8S5 th4wm01AV6Jpy1+2LkYODhEBFYnbew1ATGaBUIkdLyxBKoQFnCVWTXzNAmKzAFWcfXOHCcTmF fCQeP17GjPERDmJ88d/gtmcAp4Su5bcZAexhYBqmn81MYKMFBJQk5i7Ph6iVVDi5MwnYCOZBS QkDr54ATWGW+L26anMExj5ZiEpm4WkbAEj0ypG9eLUorLUIl0TvaSizPSMktzEzBxdQwNTvdz U4uLE9NScxKRiveT83E2MwFBiAIIdjLf6nA8xSnIwKYny7ntWHy7El5SfUpmRWJwRX1Sak1p8 iFGGg0NJgpf5PVBOsCg1PbUiLTMHGNQwaQkOHiURXkaQNG9xQWJucWY6ROoUoy7Hgh+31zIJs eTl56VKifO+eQdUJABSlFGaBzcCFmGXGGWlhHkZgY4S4ilILcrNLEGVf8UozsGoJMx7FmQKT2 ZeCdymV0BHMAEdYRAAdkRJIkJKqoGR77WDhbTLy/JSu9p0ox6jm8GX1GKt/U9/8zcocpi8wcK aaZXMzuAHDVG1ivd4RfncX4brXi/Rm/dZkjNLwbjNLpD3gqHT0wUcVorCSopbVHJ6Nsctc9Kx s8xtYbs3gTEnLav6pKSl0UOxw897JvyZt3J2oZaR3PL5lra3VeSeZgZeKFinqMRSnJFoqMVcV JwIAMllGMerAgAA X-Env-Sender: prvs=9904f56b2=Ian.Jackson@citrix.com X-Msg-Ref: server-4.tower-206.messagelabs.com!1468002401!49240152!2 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked Received: (qmail 53645 invoked from network); 8 Jul 2016 18:26:43 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-4.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 8 Jul 2016 18:26:43 -0000 X-IronPort-AV: E=Sophos;i="5.28,331,1464652800"; d="scan'208";a="365150938" From: Ian Jackson To: Date: Fri, 8 Jul 2016 19:25:53 +0100 Message-ID: <1468002385-4407-2-git-send-email-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1468002385-4407-1-git-send-email-ian.jackson@eu.citrix.com> References: <1468002385-4407-1-git-send-email-ian.jackson@eu.citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: Ian Jackson Subject: [Xen-devel] [OSSTEST PATCH 01/33] mg-allocate: Fix "issteallable" call X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP 81cac5a1656e "mg-allocate: Support --steal" introduced an erroneous call to the subref $issteallable, using { } instead of ( ), producing this error: Not a HASH reference at ./mg-allocate line 225. Signed-off-by: Ian Jackson --- mg-allocate | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mg-allocate b/mg-allocate index 42e35b3..d295997 100755 --- a/mg-allocate +++ b/mg-allocate @@ -222,7 +222,7 @@ END next if $isallocatable->($sharerow); next if $sharerow->{taskid} == $tid; next if $sharerow->{taskid} == $magictask{preparing}; - next if $isstealable->{$sharerow}; + next if $isstealable->($sharerow); logm("$desc: shared, $sharerow->{shareix} locked by ". $findowner->($sharerow)); $allshareok= 0;