From patchwork Fri Jul 15 10:42:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corneliu ZUZU X-Patchwork-Id: 9231649 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7195660865 for ; Fri, 15 Jul 2016 10:44:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 631032819A for ; Fri, 15 Jul 2016 10:44:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 57DC228325; Fri, 15 Jul 2016 10:44:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CB5142819A for ; Fri, 15 Jul 2016 10:44:44 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bO0Zk-00032z-7p; Fri, 15 Jul 2016 10:42:32 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bO0Zj-00032p-C1 for xen-devel@lists.xen.org; Fri, 15 Jul 2016 10:42:31 +0000 Received: from [85.158.137.68] by server-6.bemta-3.messagelabs.com id A2/A8-24961-61EB8875; Fri, 15 Jul 2016 10:42:30 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBIsWRWlGSWpSXmKPExsUSfTxjoa7ovo5 wg4MnjC2WfFzM4sDocXT3b6YAxijWzLyk/IoE1ox55/rYC57yV6xaPYWtgfEMTxcjJ4eQgIfE 3mlP2CHstYwSq3+7djFyAdknGSVWbO5ghyl69PMCK0RiNaPEspMzWEESbALaEucO3WMCsUUEp CWufb7MCGIzC/hLLDvUCxYXFgiX2LilBWwQi4CqxLeeJcwgNq+Aq8StOW1sXYwcHBICchILLq SDmJwCbhLPerUg1rpKLH4+mwXElhDIkbi7cik7RLWUxP9WJYhwN4vE5Bk2ELaMxKOJN9kmMAo tYGRYxahRnFpUllqka2Sil1SUmZ5RkpuYmaNraGCsl5taXJyYnpqTmFSsl5yfu4kRGIL1DAyM OxhfHfc7xCjJwaQkyrsxpSNciC8pP6UyI7E4I76oNCe1+BCjDAeHkgTv6T1AOcGi1PTUirTMH GA0wKQlOHiURHh3gqR5iwsSc4sz0yFSpxgVpcR5b4AkBEASGaV5cG2wCLzEKCslzMvIwMAgxF OQWpSbWYIq/4pRnINRSZjXdC/QFJ7MvBK46a+AFjMBLbY2bwdZXJKIkJJqYDQq+Zs/15ErbZo yf8aMktwFb08Ul5wSKFFxESlhtLh0+xbnNaNSu82bbP1T/Z/NamTf1axpYc5XmhqTXj83Wi+h gEe1/NDC/VKOBytt2CbHhMjKr56Z/3+519GE+WE3CndfMT2cM2Xzm3iv1xypL0KsL+1wiHZQU uXJ43ItfGv9erOl/9efSizFGYmGWsxFxYkALk2447sCAAA= X-Env-Sender: czuzu@bitdefender.com X-Msg-Ref: server-5.tower-31.messagelabs.com!1468579349!47629640!1 X-Originating-IP: [91.199.104.161] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.77; banners=-,-,- X-VirusChecked: Checked Received: (qmail 15876 invoked from network); 15 Jul 2016 10:42:29 -0000 Received: from mx01.bbu.dsd.mx.bitdefender.com (HELO mx01.bbu.dsd.mx.bitdefender.com) (91.199.104.161) by server-5.tower-31.messagelabs.com with DHE-RSA-AES128-GCM-SHA256 encrypted SMTP; 15 Jul 2016 10:42:29 -0000 Received: (qmail 23340 invoked from network); 15 Jul 2016 13:42:29 +0300 Received: from unknown (HELO mx-sr.buh.bitdefender.com) (10.17.80.103) by mx01.bbu.dsd.mx.bitdefender.com with AES256-GCM-SHA384 encrypted SMTP; 15 Jul 2016 13:42:29 +0300 Received: from smtp02.buh.bitdefender.net (unknown [10.17.80.76]) by mx-sr.buh.bitdefender.com (Postfix) with ESMTP id A9A9E7FC05 for ; Fri, 15 Jul 2016 13:42:25 +0300 (EEST) Received: (qmail 21223 invoked from network); 15 Jul 2016 13:42:25 +0300 Received: from unknown (HELO czuzu-dev-vm.clj.bitdefender.biz) (czuzu@bitdefender.com@91.199.104.243) by smtp02.buh.bitdefender.net with SMTP; 15 Jul 2016 13:42:25 +0300 From: Corneliu ZUZU To: xen-devel@lists.xen.org Date: Fri, 15 Jul 2016 13:42:07 +0300 Message-Id: <1468579327-19776-1-git-send-email-czuzu@bitdefender.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1468579290-19685-1-git-send-email-czuzu@bitdefender.com> References: <1468579290-19685-1-git-send-email-czuzu@bitdefender.com> X-BitDefender-Scanner: Clean, Agent: BitDefender qmail 3.1.6 on smtp02.buh.bitdefender.net, sigver: 7.66331 X-BitDefender-Spam: No (0) X-BitDefender-SpamStamp: Build: [Engines: 2.15.6.911, Dats: 426567, Stamp: 3], Multi: [Enabled, t: (0.000009, 0.002348)], BW: [Enabled, t: (0.000007,0.000001)], RBL DNSBL: [Disabled], APM: [Enabled, Score: 500, t: (0.002558), Flags: 85D2ED72; NN_NO_CONTENT_TYPE; NN_NO_LINK_NMD; NN_LEGIT_BITDEFENDER; NN_LEGIT_S_SQARE_BRACKETS; NN_LEGIT_MAILING_LIST_TO], SGN: [Enabled, t: (0.009589)], URL: [Enabled, t: (0.000005)], RTDA: [Enabled, t: (0.019738), Hit: No, Details: v2.3.10; Id: 2m1ghjn.1anlufvtl.2aml], total: 0(775) X-BitDefender-CF-Stamp: none Cc: Andrew Cooper , Jan Beulich Subject: [Xen-devel] [PATCH v5 2/7] asm-x86/atomic.h: minor: proper atomic_inc_and_test() placement X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Place atomic_inc_and_test() implementation after atomic_inc(). Also empty line fix. Signed-off-by: Corneliu ZUZU Reviewed-by: Andrew Cooper --- Changed since v4: --- xen/include/asm-x86/atomic.h | 39 +++++++++++++++++++-------------------- 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/xen/include/asm-x86/atomic.h b/xen/include/asm-x86/atomic.h index d246b70..5f9f2dd 100644 --- a/xen/include/asm-x86/atomic.h +++ b/xen/include/asm-x86/atomic.h @@ -110,7 +110,6 @@ static inline int _atomic_read(atomic_t v) return v.counter; } - /** * atomic_set - set atomic variable * @v: pointer of type atomic_t @@ -217,6 +216,25 @@ static inline void atomic_inc(atomic_t *v) } /** + * atomic_inc_and_test - increment and test + * @v: pointer of type atomic_t + * + * Atomically increments @v by 1 + * and returns true if the result is zero, or false for all + * other cases. + */ +static inline int atomic_inc_and_test(atomic_t *v) +{ + unsigned char c; + + asm volatile ( + "lock; incl %0; sete %1" + : "=m" (*(volatile int *)&v->counter), "=qm" (c) + : "m" (*(volatile int *)&v->counter) : "memory" ); + return c != 0; +} + +/** * atomic_dec - decrement atomic variable * @v: pointer of type atomic_t * @@ -250,25 +268,6 @@ static inline int atomic_dec_and_test(atomic_t *v) } /** - * atomic_inc_and_test - increment and test - * @v: pointer of type atomic_t - * - * Atomically increments @v by 1 - * and returns true if the result is zero, or false for all - * other cases. - */ -static inline int atomic_inc_and_test(atomic_t *v) -{ - unsigned char c; - - asm volatile ( - "lock; incl %0; sete %1" - : "=m" (*(volatile int *)&v->counter), "=qm" (c) - : "m" (*(volatile int *)&v->counter) : "memory" ); - return c != 0; -} - -/** * atomic_add_negative - add and test if negative * @v: pointer of type atomic_t * @i: integer value to add