From patchwork Tue Jul 26 15:45:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 9248345 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B38F460757 for ; Tue, 26 Jul 2016 15:52:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A474C201F5 for ; Tue, 26 Jul 2016 15:52:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 990E2272AA; Tue, 26 Jul 2016 15:52:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E97B8201F5 for ; Tue, 26 Jul 2016 15:52:26 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bS4bB-0007cg-Fm; Tue, 26 Jul 2016 15:48:49 +0000 Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bS4bA-0007cY-BR for xen-devel@lists.xenproject.org; Tue, 26 Jul 2016 15:48:48 +0000 Received: from [85.158.143.35] by server-2.bemta-6.messagelabs.com id 9D/FD-13744-F5687975; Tue, 26 Jul 2016 15:48:47 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjkeJIrShJLcpLzFFi42JxWrohUje+bXq 4wfOpHBbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8ahac+YClYKVhw99oG9gbGBv4uRk0NCwF/i 8OlFrCA2m4COxMW5O9m6GDk4RARUJG7vNehi5OJgFuhnljj79j4LSFxYIEri530ZkHIWAVWJV QuPsIHYvAIuEsueNrJAjNSVeHjuNytEXFDi5MwnYHFmAU2J1u2/2SFseYnmrbOZQWwhAUWJ/n kPwNZKCHBL/O22n8DIOwtJ9ywk3bOQdC9gZF7FqF6cWlSWWqRrppdUlJmeUZKbmJmja2hgppe bWlycmJ6ak5hUrJecn7uJERhODECwg3HeCf9DjJIcTEqivEwTpoUL8SXlp1RmJBZnxBeV5qQW H2KU4eBQkuAtbZ0eLiRYlJqeWpGWmQMMbJi0BAePkgjv9WagNG9xQWJucWY6ROoUo6KUOC8PS J8ASCKjNA+uDRZNlxhlpYR5GYEOEeIpSC3KzSxBlX/FKM7BqCTMWwIyhSczrwRu+iugxUxAix fwTAZZXJKIkJJqYJx12IvRdimrQkX3UrPQ5996bteZnXHNXeXEdVi69vVb2VtFgb+DZwp6ve0 qy9+0kf/H/ydvZk9zac+/s/rFox/vNrM6st/y33TiwWK/3Iblixd5bLt4kP1eg4ngI5+yOa1s B4XiW3ptdd+KTjmtv2plL4dUrRJXcgp/9+x5yzr0mSa77Oo+nKXEUpyRaKjFXFScCAD41libo QIAAA== X-Env-Sender: prvs=008a5108a=roger.pau@citrix.com X-Msg-Ref: server-3.tower-21.messagelabs.com!1469548125!25166973!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 8.77; banners=-,-,- X-VirusChecked: Checked Received: (qmail 50748 invoked from network); 26 Jul 2016 15:48:46 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-3.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 26 Jul 2016 15:48:46 -0000 X-IronPort-AV: E=Sophos;i="5.28,425,1464652800"; d="scan'208";a="368485515" From: Roger Pau Monne To: Date: Tue, 26 Jul 2016 17:45:40 +0200 Message-ID: <1469547940-19406-1-git-send-email-roger.pau@citrix.com> X-Mailer: git-send-email 2.7.4 (Apple Git-66) MIME-Version: 1.0 X-DLP: MIA1 Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Jan Beulich , Doug Goldstein , Roger Pau Monne Subject: [Xen-devel] [PATCH] xen/kconfig: unify messages of options moved from command line to kconfig X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Change the message so that it mentions running from the top level directory and using '-C xen' in order to call the 'menuconfig' target inside of the xen directory (there's no top-level menuconfig target). Signed-off-by: Roger Pau Monné --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc: Tim Deegan Cc: Wei Liu Cc: Doug Goldstein --- xen/Rules.mk | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/xen/Rules.mk b/xen/Rules.mk index ebe1dc0..8fc44d3 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -9,27 +9,31 @@ lto ?= n include $(XEN_ROOT)/Config.mk +error_str = "You must use '$(MAKE) -C xen menuconfig' from the top level directory to enable/disable $(1) now." +error_msg = $(error $(error_str)) +warning_msg = $(warning $(error_str)) + ifneq ($(origin crash_debug),undefined) -$(error "You must use 'make menuconfig' to enable/disable crash_debug now.") +$(call error_msg,crash_debug) endif ifeq ($(origin debug),command line) -$(warning "You must use 'make menuconfig' to enable/disable debug now.") +$(call warning_msg,debug) endif ifneq ($(origin frame_pointer),undefined) -$(error "You must use 'make menuconfig' to enable/disable frame_pointer now.") +$(call error_msg,frame_pointer) endif ifneq ($(origin kexec),undefined) -$(error "You must use 'make menuconfig' to enable/disable kexec now.") +$(call error_msg,kexec) endif ifneq ($(origin lock_profile),undefined) -$(error "You must use 'make menuconfig' to enable/disable lock_profile now.") +$(call error_msg,lock_profile) endif ifneq ($(origin perfc),undefined) -$(error "You must use 'make menuconfig' to enable/disable perfc now.") +$(call error_msg,perfc) endif ifneq ($(origin verbose),undefined) -$(error "You must use 'make menuconfig' to enable/disable verbose now.") +$(call error_msg,verbose) endif # Set ARCH/SUBARCH appropriately.