| Message ID | 1469723086-22387-1-git-send-email-vkuznets@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 28/07/16 17:24, Vitaly Kuznetsov wrote: > We pass xen_vcpu_id mapping information to hypercalls which require > uint32_t type so it would be cleaner to have it as uint32_t. The > initializer to -1 can be dropped as we always do the mapping before using > it and we never check the 'not set' value anyway. [...] > --- a/include/xen/xen-ops.h > +++ b/include/xen/xen-ops.h > @@ -9,7 +9,7 @@ > > DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu); > > -DECLARE_PER_CPU(int, xen_vcpu_id); > +DECLARE_PER_CPU(uint32_t, xen_vcpu_id); > static inline int xen_vcpu_nr(int cpu) Should the return type of this change to uint32_t as well? > { > return per_cpu(xen_vcpu_id, cpu); > David
David Vrabel <david.vrabel@citrix.com> writes: > On 28/07/16 17:24, Vitaly Kuznetsov wrote: >> We pass xen_vcpu_id mapping information to hypercalls which require >> uint32_t type so it would be cleaner to have it as uint32_t. The >> initializer to -1 can be dropped as we always do the mapping before using >> it and we never check the 'not set' value anyway. > [...] >> --- a/include/xen/xen-ops.h >> +++ b/include/xen/xen-ops.h >> @@ -9,7 +9,7 @@ >> >> DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu); >> >> -DECLARE_PER_CPU(int, xen_vcpu_id); >> +DECLARE_PER_CPU(uint32_t, xen_vcpu_id); >> static inline int xen_vcpu_nr(int cpu) > > Should the return type of this change to uint32_t as well? > Yes, missed that, will do v2. Sorry! >> { >> return per_cpu(xen_vcpu_id, cpu); >>
diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c index 6d3a171..1752116 100644 --- a/arch/arm/xen/enlighten.c +++ b/arch/arm/xen/enlighten.c @@ -47,7 +47,7 @@ DEFINE_PER_CPU(struct vcpu_info *, xen_vcpu); static struct vcpu_info __percpu *xen_vcpu_info; /* Linux <-> Xen vCPU id mapping */ -DEFINE_PER_CPU(int, xen_vcpu_id) = -1; +DEFINE_PER_CPU(uint32_t, xen_vcpu_id); EXPORT_PER_CPU_SYMBOL(xen_vcpu_id); /* These are unused until we support booting "pre-ballooned" */ diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index 54eef1a..78a14a0 100644 --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -120,7 +120,7 @@ DEFINE_PER_CPU(struct vcpu_info *, xen_vcpu); DEFINE_PER_CPU(struct vcpu_info, xen_vcpu_info); /* Linux <-> Xen vCPU id mapping */ -DEFINE_PER_CPU(int, xen_vcpu_id) = -1; +DEFINE_PER_CPU(uint32_t, xen_vcpu_id); EXPORT_PER_CPU_SYMBOL(xen_vcpu_id); enum xen_domain_type xen_domain_type = XEN_NATIVE; diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h index a4926f1..648ce814 100644 --- a/include/xen/xen-ops.h +++ b/include/xen/xen-ops.h @@ -9,7 +9,7 @@ DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu); -DECLARE_PER_CPU(int, xen_vcpu_id); +DECLARE_PER_CPU(uint32_t, xen_vcpu_id); static inline int xen_vcpu_nr(int cpu) { return per_cpu(xen_vcpu_id, cpu);
We pass xen_vcpu_id mapping information to hypercalls which require uint32_t type so it would be cleaner to have it as uint32_t. The initializer to -1 can be dropped as we always do the mapping before using it and we never check the 'not set' value anyway. Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> --- arch/arm/xen/enlighten.c | 2 +- arch/x86/xen/enlighten.c | 2 +- include/xen/xen-ops.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)