| Message ID | 1470731568-30140-1-git-send-email-rcojocaru@bitdefender.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
>>> On 09.08.16 at 10:32, <rcojocaru@bitdefender.com> wrote: > --- a/xen/common/vm_event.c > +++ b/xen/common/vm_event.c > @@ -255,7 +255,7 @@ static inline void vm_event_release_slot(struct domain *d, > > /* > * vm_event_mark_and_pause() tags vcpu and put it to sleep. > - * The vcpu will resume execution in vm_event_wake_waiters(). > + * The vcpu will resume execution in vm_event_wake(). > */ > void vm_event_mark_and_pause(struct vcpu *v, struct vm_event_domain *ved) > { I was about to commit this without further waiting for an ack, as being supposedly trivial, but then I checked and also found vm_event_wake{blocked,queued}(), and now I'm not sure whether the reference wouldn't better be to vm_event_wake_blocked(). Could you clarify that for me please? Jan
On 08/11/2016 01:38 PM, Jan Beulich wrote: >>>> On 09.08.16 at 10:32, <rcojocaru@bitdefender.com> wrote: >> --- a/xen/common/vm_event.c >> +++ b/xen/common/vm_event.c >> @@ -255,7 +255,7 @@ static inline void vm_event_release_slot(struct domain *d, >> >> /* >> * vm_event_mark_and_pause() tags vcpu and put it to sleep. >> - * The vcpu will resume execution in vm_event_wake_waiters(). >> + * The vcpu will resume execution in vm_event_wake(). >> */ >> void vm_event_mark_and_pause(struct vcpu *v, struct vm_event_domain *ved) >> { > > I was about to commit this without further waiting for an ack, as > being supposedly trivial, but then I checked and also found > vm_event_wake{blocked,queued}(), and now I'm not sure > whether the reference wouldn't better be to > vm_event_wake_blocked(). Could you clarify that for me please? Indeed, that's more precise. I'm happy to send V2 if you'd like. Thanks, Razvan
>>> On 11.08.16 at 14:10, <rcojocaru@bitdefender.com> wrote: > On 08/11/2016 01:38 PM, Jan Beulich wrote: >>>>> On 09.08.16 at 10:32, <rcojocaru@bitdefender.com> wrote: >>> --- a/xen/common/vm_event.c >>> +++ b/xen/common/vm_event.c >>> @@ -255,7 +255,7 @@ static inline void vm_event_release_slot(struct domain *d, >>> >>> /* >>> * vm_event_mark_and_pause() tags vcpu and put it to sleep. >>> - * The vcpu will resume execution in vm_event_wake_waiters(). >>> + * The vcpu will resume execution in vm_event_wake(). >>> */ >>> void vm_event_mark_and_pause(struct vcpu *v, struct vm_event_domain *ved) >>> { >> >> I was about to commit this without further waiting for an ack, as >> being supposedly trivial, but then I checked and also found >> vm_event_wake{blocked,queued}(), and now I'm not sure >> whether the reference wouldn't better be to >> vm_event_wake_blocked(). Could you clarify that for me please? > > Indeed, that's more precise. I'm happy to send V2 if you'd like. I can as well adjust it while committing. Jan
diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c index 941345b..ad7f986 100644 --- a/xen/common/vm_event.c +++ b/xen/common/vm_event.c @@ -255,7 +255,7 @@ static inline void vm_event_release_slot(struct domain *d, /* * vm_event_mark_and_pause() tags vcpu and put it to sleep. - * The vcpu will resume execution in vm_event_wake_waiters(). + * The vcpu will resume execution in vm_event_wake(). */ void vm_event_mark_and_pause(struct vcpu *v, struct vm_event_domain *ved) {
There's no such thing as function vm_event_wake_waiters() anymore. Signed-off-by: Razvan Cojocaru <rcojocaru@bitdefender.com> --- xen/common/vm_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)