diff mbox

[v2,12/30] xen/x86: make print_e820_memory_map global

Message ID 1474991845-27962-13-git-send-email-roger.pau@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Roger Pau Monné Sept. 27, 2016, 3:57 p.m. UTC 
So that it can be called from the Dom0 builder.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
---
 xen/arch/x86/e820.c        | 2 +-
 xen/include/asm-x86/e820.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Jan Beulich Sept. 30, 2016, 3:04 p.m. UTC | #1 
>>> On 27.09.16 at 17:57, <roger.pau@citrix.com> wrote:
> So that it can be called from the Dom0 builder.

Why would the Dom0 builder need to call it, when it doesn't so far?

Jan
Roger Pau Monné Oct. 3, 2016, 4:23 p.m. UTC | #2 
On Fri, Sep 30, 2016 at 09:04:24AM -0600, Jan Beulich wrote:
> >>> On 27.09.16 at 17:57, <roger.pau@citrix.com> wrote:
> > So that it can be called from the Dom0 builder.
> 
> Why would the Dom0 builder need to call it, when it doesn't so far?

IMHO, I find it useful to print the domain 0 memory map during creation. It 
wasn't useful for a PV Dom0, because the PV Dom0 memory map is just the 
native memory map, which is already printed earlier during the boot process. 
If it doesn't seem useful to you or others I can leave it out.

Roger.
Jan Beulich Oct. 4, 2016, 6:47 a.m. UTC | #3 
>>> On 03.10.16 at 18:23, <roger.pau@citrix.com> wrote:
> On Fri, Sep 30, 2016 at 09:04:24AM -0600, Jan Beulich wrote:
>> >>> On 27.09.16 at 17:57, <roger.pau@citrix.com> wrote:
>> > So that it can be called from the Dom0 builder.
>> 
>> Why would the Dom0 builder need to call it, when it doesn't so far?
> 
> IMHO, I find it useful to print the domain 0 memory map during creation. It 
> wasn't useful for a PV Dom0, because the PV Dom0 memory map is just the 
> native memory map, which is already printed earlier during the boot process. 
> If it doesn't seem useful to you or others I can leave it out.

Well, I don't mean to nack the change if others agree with you. If this
is to be made more widely available, it would want its first parameter
constified though.

Jan
diff mbox

Patch

diff --git a/xen/arch/x86/e820.c b/xen/arch/x86/e820.c
index ef077a5..48e35f9 100644
--- a/xen/arch/x86/e820.c
+++ b/xen/arch/x86/e820.c
@@ -87,7 +87,7 @@  static void __init add_memory_region(unsigned long long start,
     e820.nr_map++;
 }
 
-static void __init print_e820_memory_map(struct e820entry *map, unsigned int entries)
+void __init print_e820_memory_map(struct e820entry *map, unsigned int entries)
 {
     unsigned int i;
 
diff --git a/xen/include/asm-x86/e820.h b/xen/include/asm-x86/e820.h
index d9ff4eb..9dad76a 100644
--- a/xen/include/asm-x86/e820.h
+++ b/xen/include/asm-x86/e820.h
@@ -31,6 +31,7 @@  extern int e820_change_range_type(
 extern int e820_add_range(
     struct e820map *, uint64_t s, uint64_t e, uint32_t type);
 extern unsigned long init_e820(const char *, struct e820entry *, unsigned int *);
+extern void print_e820_memory_map(struct e820entry *map, unsigned int entries);
 extern struct e820map e820;
 
 /* These symbols live in the boot trampoline. */