From patchwork Wed Sep 28 09:42:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Rzeszutek Wilk X-Patchwork-Id: 9353677 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2BE516077A for ; Wed, 28 Sep 2016 09:45:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D40129478 for ; Wed, 28 Sep 2016 09:45:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1243A2947B; Wed, 28 Sep 2016 09:45:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AA86D2947C for ; Wed, 28 Sep 2016 09:45:10 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpBON-0000Vk-4D; Wed, 28 Sep 2016 09:43:07 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpBOL-0000Tf-AK for xen-devel@lists.xenproject.org; Wed, 28 Sep 2016 09:43:05 +0000 Received: from [85.158.143.35] by server-10.bemta-6.messagelabs.com id 7C/1D-21986-8A09BE75; Wed, 28 Sep 2016 09:43:04 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJLMWRWlGSWpSXmKPExsXSO6nOVXf5hNf hBjNbrS2+b5nM5MDocfjDFZYAxijWzLyk/IoE1owLTT+YCqZyVsxtd2tgPMnexcjFISQwkUli 2v1WJgjnG6PEgXc/WCGcjYwSJ159YoZwJjBK/G7qB3I4ONgETCTerHLsYuTkEBEwldg+8SQLS A2zwDRGiU+njjCBJIQFEiTmLVjLDmKzCKhK7N98GCzOK+AmcerEXEaQORIC8hLPbteDmJwC7h L3D/uCVAgBVXxveMwCYksIGEp83riUeQIj3wJGhlWM6sWpRWWpRbrGeklFmekZJbmJmTm6hgZ mermpxcWJ6ak5iUnFesn5uZsYgUHCAAQ7GDv+OR1ilORgUhLl3Rz+OlyILyk/pTIjsTgjvqg0 J7X4EKMMB4eSBO/CfqCcYFFqempFWmYOMFxh0hIcPEoivJEgad7igsTc4sx0iNQpRkUpcd5Kk IQASCKjNA+uDRYjlxhlpYR5GYEOEeIpSC3KzSxBlX/FKM7BqCTMuxhkCk9mXgnc9FdAi5mAFi 898QJkcUkiQkqqgVHkhMfbpF+M0xZdrQt7tlw/6GB8zqqVB47k7XnFukhnZ2gzc9udaL1dFQs Me6NU2xZsTn6rEPtPa0KJ0RbbZU57ilteFL/84J0Wtbt33WO99AK3+2vm1mdLGQaKzLjvm+oz j6mzjv9RWnve9oBNdsbcrKva9Gc2akTtXP27NWJLV7f0p5zCMiWW4oxEQy3mouJEAMgCdU2MA gAA X-Env-Sender: konrad.wilk@oracle.com X-Msg-Ref: server-12.tower-21.messagelabs.com!1475055782!35472689!1 X-Originating-IP: [141.146.126.69] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTQxLjE0Ni4xMjYuNjkgPT4gMjc3MjE4\n X-StarScan-Received: X-StarScan-Version: 8.84; banners=-,-,- X-VirusChecked: Checked Received: (qmail 8272 invoked from network); 28 Sep 2016 09:43:03 -0000 Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by server-12.tower-21.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 28 Sep 2016 09:43:03 -0000 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u8S9gbUh028653 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 Sep 2016 09:42:37 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u8S9gapY009160 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 28 Sep 2016 09:42:36 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u8S9gYKK019351; Wed, 28 Sep 2016 09:42:35 GMT Received: from localhost.localdomain.com (/209.6.196.81) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 28 Sep 2016 02:42:33 -0700 From: Konrad Rzeszutek Wilk To: xen-devel@lists.xenproject.org, konrad@kernel.org Date: Wed, 28 Sep 2016 05:42:15 -0400 Message-Id: <1475055746-22401-2-git-send-email-konrad.wilk@oracle.com> X-Mailer: git-send-email 2.4.11 In-Reply-To: <1475055746-22401-1-git-send-email-konrad.wilk@oracle.com> References: <1475055746-22401-1-git-send-email-konrad.wilk@oracle.com> X-Source-IP: userv0022.oracle.com [156.151.31.74] Cc: Wei Liu , Ian Jackson , Konrad Rzeszutek Wilk Subject: [Xen-devel] [PATCH v1 01/12] libxc/tmem/restore: Remove call to XEN_SYSCTL_TMEM_OP_SAVE_GET_VERSION X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP The only thing this hypercall returns is TMEM_SPEC_VERSION. The comment around is also misleading - this call does not do any domain operation. Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Wei Liu --- Cc: Ian Jackson Cc: Wei Liu v1: Initial submission. --- tools/libxc/xc_tmem.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tools/libxc/xc_tmem.c b/tools/libxc/xc_tmem.c index 4e5c278..31ae3f5 100644 --- a/tools/libxc/xc_tmem.c +++ b/tools/libxc/xc_tmem.c @@ -381,16 +381,12 @@ static int xc_tmem_restore_new_pool( int xc_tmem_restore(xc_interface *xch, int dom, int io_fd) { - uint32_t save_version; uint32_t this_max_pools, this_version; uint32_t pool_id; uint32_t minusone; uint32_t weight, cap, flags; int checksum = 0; - save_version = xc_tmem_control(xch,0,XEN_SYSCTL_TMEM_OP_SAVE_GET_VERSION,dom,0,0,NULL); - if ( save_version == -1 ) - return -1; /* domain doesn't exist */ if ( read_exact(io_fd, &this_version, sizeof(this_version)) ) return -1; if ( read_exact(io_fd, &this_max_pools, sizeof(this_max_pools)) )