From patchwork Fri Sep 30 18:11:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Rzeszutek Wilk X-Patchwork-Id: 9358721 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 55BC560757 for ; Fri, 30 Sep 2016 18:14:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4EFC22A14C for ; Fri, 30 Sep 2016 18:14:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 43C5F2A153; Fri, 30 Sep 2016 18:14:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B7E792A14C for ; Fri, 30 Sep 2016 18:14:27 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bq2IF-0005Y3-6a; Fri, 30 Sep 2016 18:12:19 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bq2ID-0005Xf-Nu for xen-devel@lists.xenproject.org; Fri, 30 Sep 2016 18:12:17 +0000 Received: from [85.158.143.35] by server-7.bemta-6.messagelabs.com id 1C/F1-15404-10BAEE75; Fri, 30 Sep 2016 18:12:17 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJLMWRWlGSWpSXmKPExsXSO6nOVZdh9bt wg/s7JSy+b5nM5MDocfjDFZYAxijWzLyk/IoE1ozGQ3tZCi5xViz/LNbA+I+9i5GLQ0hgIpPE 2oWdUM5vRonjbR9YIJyNjBIXZ79jhHAmMErMOX+JuYuRg4NNwETizSrHLkZODhEBU4ntE0+CN TALTGOU+HTqCBNIQlggTuL1u/9g9SwCqhKzPmqDmLwCrhKXXweAmBIC8hLPbteDFHMKuEnc3j KNEcQWAqro/HOCFcSWEDCU+LxxKfMERr4FjAyrGDWKU4vKUot0jSz1kooy0zNKchMzc3QNDcz 0clOLixPTU3MSk4r1kvNzNzECg4QBCHYwHlgUeIhRkoNJSZRX9ujbcCG+pPyUyozE4oz4otKc 1OJDjDIcHEoSvAkr34ULCRalpqdWpGXmAMMVJi3BwaMkwisBkuYtLkjMLc5Mh0idYlSUEuddC ZIQAElklObBtcFi5BKjrJQwLyPQIUI8BalFuZklqPKvGMU5GJWEeT+CTOHJzCuBm/4KaDET0O L8o29AFpckIqSkGhiFdotZhMq8nn1V/4rdLB1OH0ePugvCAn/LfQ6ozjmppjyjtPO6i0VtA1d 0wh/j6T0aR6oN96+w5n0cOc+v6nVHzoKkn3Kn1Kf5NisYulk6sousvvN85tGwDgser51MfWbP KziyT4sEvJjaG9718dKqkNY3uy7XqfFqTN57sv+57fvTZyfunaLEUpyRaKjFXFScCADFTlKNj AIAAA== X-Env-Sender: konrad.wilk@oracle.com X-Msg-Ref: server-9.tower-21.messagelabs.com!1475259134!35804174!1 X-Originating-IP: [141.146.126.69] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTQxLjE0Ni4xMjYuNjkgPT4gMjc3MjE4\n X-StarScan-Received: X-StarScan-Version: 8.84; banners=-,-,- X-VirusChecked: Checked Received: (qmail 63149 invoked from network); 30 Sep 2016 18:12:16 -0000 Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by server-9.tower-21.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 30 Sep 2016 18:12:16 -0000 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u8UICBli005439 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Sep 2016 18:12:11 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u8UICBdW017594 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Sep 2016 18:12:11 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id u8UICAbg016405; Fri, 30 Sep 2016 18:12:10 GMT Received: from localhost.us.oracle.com (/10.154.132.195) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 30 Sep 2016 11:12:10 -0700 From: Konrad Rzeszutek Wilk To: xen-devel@lists.xenproject.org, konrad@kernel.org Date: Fri, 30 Sep 2016 14:11:46 -0400 Message-Id: <1475259114-8693-2-git-send-email-konrad.wilk@oracle.com> X-Mailer: git-send-email 2.4.11 In-Reply-To: <1475259114-8693-1-git-send-email-konrad.wilk@oracle.com> References: <1475259114-8693-1-git-send-email-konrad.wilk@oracle.com> X-Source-IP: userv0022.oracle.com [156.151.31.74] Cc: Wei Liu , Ian Jackson , Konrad Rzeszutek Wilk Subject: [Xen-devel] [PATCH v2 1/9] libxc/tmem/restore: Remove call to XEN_SYSCTL_TMEM_OP_SAVE_GET_VERSION X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP The only thing this hypercall returns is TMEM_SPEC_VERSION. The comment around is also misleading - this call does not do any domain operation. Acked-by: Wei Liu Signed-off-by: Konrad Rzeszutek Wilk --- Cc: Ian Jackson Cc: Wei Liu v1: Initial submission. v2: Added Wei's Ack. --- tools/libxc/xc_tmem.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tools/libxc/xc_tmem.c b/tools/libxc/xc_tmem.c index 4e5c278..31ae3f5 100644 --- a/tools/libxc/xc_tmem.c +++ b/tools/libxc/xc_tmem.c @@ -381,16 +381,12 @@ static int xc_tmem_restore_new_pool( int xc_tmem_restore(xc_interface *xch, int dom, int io_fd) { - uint32_t save_version; uint32_t this_max_pools, this_version; uint32_t pool_id; uint32_t minusone; uint32_t weight, cap, flags; int checksum = 0; - save_version = xc_tmem_control(xch,0,XEN_SYSCTL_TMEM_OP_SAVE_GET_VERSION,dom,0,0,NULL); - if ( save_version == -1 ) - return -1; /* domain doesn't exist */ if ( read_exact(io_fd, &this_version, sizeof(this_version)) ) return -1; if ( read_exact(io_fd, &this_max_pools, sizeof(this_max_pools)) )