From patchwork Tue Oct 25 09:37:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 9394235 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5FF0860231 for ; Tue, 25 Oct 2016 09:41:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4FC5D28E67 for ; Tue, 25 Oct 2016 09:41:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4426129358; Tue, 25 Oct 2016 09:41:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6FC83292B5 for ; Tue, 25 Oct 2016 09:41:05 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byyBr-0001ob-2G; Tue, 25 Oct 2016 09:38:39 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byyBq-0001oU-46 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2016 09:38:38 +0000 Received: from [85.158.139.211] by server-15.bemta-5.messagelabs.com id 58/39-01343-D182F085; Tue, 25 Oct 2016 09:38:37 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDIsWRWlGSWpSXmKPExsWyU9JRQldKgz/ C4ONyXYvvWyYzOTB6HP5whSWAMYo1My8pvyKBNWPlTZGCpUIVPbdWMjcwPuTvYuTkkBDwk5g1 7Sk7iM0moCNxce5Oti5GDg4RARWJ23sNuhi5OJgFljFK/H12mwmkRlggROJJ5xFmEJtFQFXiW udkRhCbV8BFYtrD+WwQM3UlHp77zQoRF5Q4OfMJC4jNLKAp0br9NzuELS/RvHU22BwhAUWJ/n kPoHrTJSY+62GBsLklVn7+wzKBkW8WklGzkIyahWTUAkbmVYwaxalFZalFukbGeklFmekZJbm JmTm6hgamermpxcWJ6ak5iUnFesn5uZsYgaFWz8DAuINxR7vfIUZJDiYlUd7Gz3wRQnxJ+SmV GYnFGfFFpTmpxYcYZTg4lCR4q9T4I4QEi1LTUyvSMnOAQQ+TluDgURLhFQBJ8xYXJOYWZ6ZDp E4xKkqJ80qCJARAEhmleXBtsEi7xCgrJczLyMDAIMRTkFqUm1mCKv+KUZyDUUmYVwJkCk9mXg nc9FdAi5mAFgvG84AsLklESEk1MIZdDZ/tvbPT1PU6j0vN/08bC1WO+4Q1eb7b8XhPk0XO+xW Pdr8P3hwTvl8gI66PRdf9ROuxfazV1ky+v5J3rhScr7breyjjHP3Vu9QCDyt6h/5eJ527f93Z NKbT79yzvrae8n98ZMGHmCA71mr+LVLLfLbtMJ3LdnDp/JgvHtafJte/EOrqn6/EUpyRaKjFX FScCAAfFPGrrwIAAA== X-Env-Sender: prvs=099ae7f8d=roger.pau@citrix.com X-Msg-Ref: server-15.tower-206.messagelabs.com!1477388314!52902219!1 X-Originating-IP: [185.25.65.24] X-SpamReason: No, hits=0.0 required=7.0 tests=received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.0.13; banners=-,-,- X-VirusChecked: Checked Received: (qmail 25813 invoked from network); 25 Oct 2016 09:38:34 -0000 Received: from smtp.ctxuk.citrix.com (HELO SMTP.EU.CITRIX.COM) (185.25.65.24) by server-15.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 25 Oct 2016 09:38:34 -0000 X-IronPort-AV: E=Sophos;i="5.31,545,1473120000"; d="scan'208";a="33669412" From: Roger Pau Monne To: Date: Tue, 25 Oct 2016 11:37:16 +0200 Message-ID: <1477388236-23029-1-git-send-email-roger.pau@citrix.com> X-Mailer: git-send-email 2.7.4 (Apple Git-66) MIME-Version: 1.0 X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-DLP: AMS1 Cc: Wei Liu , Alexander Nusov , Ian Jackson , Roger Pau Monne Subject: [Xen-devel] [PATCH v2 for-4.8] tools/configure: fix pkg-config install path for FreeBSD X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP pkg-config from FreeBSD ports doesn't have ${prefix}/share/pkgconfig in the default search path, fix this by having a PKG_INSTALLDIR variable that can be changed on a per-OS basis. It would be best to use PKG_INSTALLDIR as defined by the pkg.m4 macro, but sadly this also reports a wrong value on FreeBSD (${libdir}/pkgconfig, which expands to /usr/local/lib/pkgconfig by default, and is also _not_ part of the default pkg-config search path). This patch should not change the behavior for Linux installs. Signed-off-by: Roger Pau Monné Reported-by: Alexander Nusov --- Cc: Ian Jackson Cc: Wei Liu Cc: Alexander Nusov --- Changes since v1: - Remove leftovers from a previous attempt at fixing the issue. --- config/FreeBSD.mk | 1 + config/Paths.mk.in | 2 ++ tools/libxl/Makefile | 4 ++-- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/config/FreeBSD.mk b/config/FreeBSD.mk index bb3a5d0..afeaefb 100644 --- a/config/FreeBSD.mk +++ b/config/FreeBSD.mk @@ -2,3 +2,4 @@ include $(XEN_ROOT)/config/StdGNU.mk # No wget on FreeBSD base system WGET = ftp +PKG_INSTALLDIR = ${prefix}/libdata/pkgconfig diff --git a/config/Paths.mk.in b/config/Paths.mk.in index 62cea48..a603295 100644 --- a/config/Paths.mk.in +++ b/config/Paths.mk.in @@ -56,3 +56,5 @@ XENFIRMWAREDIR := @XENFIRMWAREDIR@ XEN_CONFIG_DIR := @XEN_CONFIG_DIR@ XEN_SCRIPT_DIR := @XEN_SCRIPT_DIR@ + +PKG_INSTALLDIR := ${SHAREDIR}/pkgconfig diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile index a3c0af8..6d323ef 100644 --- a/tools/libxl/Makefile +++ b/tools/libxl/Makefile @@ -297,8 +297,8 @@ install: all $(INSTALL_DATA) libxlutil.a $(DESTDIR)$(libdir) $(INSTALL_DATA) libxl.h libxl_event.h libxl_json.h _libxl_types.h _libxl_types_json.h _libxl_list.h libxl_utils.h libxl_uuid.h libxlutil.h $(DESTDIR)$(includedir) $(INSTALL_DATA) bash-completion $(DESTDIR)$(BASH_COMPLETION_DIR)/xl.sh - $(INSTALL_DATA) xenlight.pc $(DESTDIR)$(SHAREDIR)/pkgconfig/ - $(INSTALL_DATA) xlutil.pc $(DESTDIR)$(SHAREDIR)/pkgconfig/ + $(INSTALL_DATA) xenlight.pc $(PKG_INSTALLDIR) + $(INSTALL_DATA) xlutil.pc $(PKG_INSTALLDIR) .PHONY: clean clean: