| Message ID | 1479346630-122644-4-git-send-email-konrad.wilk@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Konrad Rzeszutek Wilk writes ("[PATCH v1 3/7] ts-xen-build: Install livepatch regressions tests."):
> That come with the Xen git tree (see xen/test/).
I think this and the "build them" patch should be combined.
> + buildcmd_stamped_logged(600, 'xen', 'tests-install', '',<<END,'') if $dokconfig;
Can you keep the lines down to 75 characters or less please ?
> + if test -d xen/test; then
> + mkdir -p dist/install/usr/lib/debug
> + livepatch_files=`find xen/test/livepatch -name '*.livepatch' -print`
> + cp \$livepatch_files dist/install/usr/lib/debug
Should this not be in the xen.git Makefiles ?
Also, the result of this is that the tests end up in the tools output
because you haven't fixed `divide'. Background: each osstest
invocation of ts-xen-build produces two primary deliverables: `' and
`xen' aka `dist' and `xendist'.
I think, but I'm not sure, that these patches contain hypervisor code
and should be in `xendist'.
Thanks,
Ian.
diff --git a/ts-xen-build b/ts-xen-build index 9843c2e..1b36b9c 100755 --- a/ts-xen-build +++ b/ts-xen-build @@ -170,6 +170,13 @@ END $make_prefix make -C xen tests fi END + buildcmd_stamped_logged(600, 'xen', 'tests-install', '',<<END,'') if $dokconfig; + if test -d xen/test; then + mkdir -p dist/install/usr/lib/debug + livepatch_files=`find xen/test/livepatch -name '*.livepatch' -print` + cp \$livepatch_files dist/install/usr/lib/debug + fi +END } sub divide () {
That come with the Xen git tree (see xen/test/). Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> --- ts-xen-build | 7 +++++++ 1 file changed, 7 insertions(+)