diff mbox

[v1,7/7] make-flight/mfi-common: Add them in the matrix.

Message ID 1479346630-122644-8-git-send-email-konrad.wilk@oracle.com (mailing list archive)
State New, archived
Headers show

Commit Message

Konrad Rzeszutek Wilk Nov. 17, 2016, 1:37 a.m. UTC
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 make-flight | 12 ++++++++++++
 mfi-common  |  9 +++++++++
 2 files changed, 21 insertions(+)

Comments

Ian Jackson Nov. 17, 2016, 12:24 p.m. UTC | #1
Konrad Rzeszutek Wilk writes ("[PATCH v1 7/7] make-flight/mfi-common: Add them in the matrix."):
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Can you accompany this with a diff of the output of
   standalone-generate-dump-flight-runvars
before and after ?

You probably want
  AP_FETCH_PLACEHOLDERS=y eatmydata ./standalone-generate-dump-flight-runvars

Ian.
Ian Jackson Dec. 12, 2016, 4:19 p.m. UTC | #2
Konrad Rzeszutek Wilk writes ("Re: [Xen-devel] [PATCH v1 7/7] make-flight/mfi-common: Add them in the matrix."):
> On Thu, Nov 17, 2016 at 12:24:20PM +0000, Ian Jackson wrote:
> > Can you accompany this with a diff of the output of
> >    standalone-generate-dump-flight-runvars
> > before and after ?
> 
> I get:
> 
> Repos must be configured in /home/konrad/.xen-osstest/config
> make-flight libvirt failed

It just means the config variable literally `Repos'.  From README:

  Repos              Full path to a temporary directory where repositories
                     can be cloned. This is needed for anything which uses
                     cr-daily-branch, including "./standalone make-flight"
                     and "standalone-generate-dump-flight-runvars".

Ian.
Konrad Rzeszutek Wilk Dec. 12, 2016, 7:01 p.m. UTC | #3
On Thu, Nov 17, 2016 at 12:24:20PM +0000, Ian Jackson wrote:
> Konrad Rzeszutek Wilk writes ("[PATCH v1 7/7] make-flight/mfi-common: Add them in the matrix."):
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> Can you accompany this with a diff of the output of
>    standalone-generate-dump-flight-runvars
> before and after ?

I get:

Repos must be configured in /home/konrad/.xen-osstest/config
make-flight libvirt failed


Any ideas which repos I should configure?

And I did do ./sg-run-job build-amd64-libvirt

right beforehand?

> 
> You probably want
>   AP_FETCH_PLACEHOLDERS=y eatmydata ./standalone-generate-dump-flight-runvars

That is what I did.
> 
> Ian.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
diff mbox

Patch

diff --git a/make-flight b/make-flight
index d45a0e3..c2add66 100755
--- a/make-flight
+++ b/make-flight
@@ -485,6 +485,17 @@  do_xtf_tests () {
   done
 }
 
+do_livepatch_tests () {
+  if ! branch_wants_livepatch_tests; then
+      return
+  fi
+
+  job_create_test test-$xenarch$kern-$dom0arch-livepatch             \
+       test-livepatch xl $xenarch $dom0arch                          \
+       xen_boot_append='loglvl=all'                                  \
+       all_hostflags=$most_hostflags
+}
+
 do_multivcpu_tests () {
   if [ $xenarch != $dom0arch ]; then
     return
@@ -800,6 +811,7 @@  test_matrix_do_one () {
 
   do_xtf_tests
   do_openstack_tests
+  do_livepatch_tests
 }
 
 if [ x$buildflight = x ]; then
diff --git a/mfi-common b/mfi-common
index 76b93d1..08494f3 100644
--- a/mfi-common
+++ b/mfi-common
@@ -76,6 +76,15 @@  branch_wants_xtf_tests () {
   esac
 }
 
+branch_wants_livepatch_tests () {
+  case "$branch" in
+    osstest*) return 0;;
+    xen-*)    return 0;;
+    livepatch*)     return 0;;
+    *)        return 1;;
+  esac
+}
+
 job_create_build () {
   job_create_build_filter_callback "$@" || return 0