From patchwork Mon Nov 28 21:27:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Stabellini X-Patchwork-Id: 9450467 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4F94C600CB for ; Mon, 28 Nov 2016 21:29:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 41D2928047 for ; Mon, 28 Nov 2016 21:29:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 369CE28068; Mon, 28 Nov 2016 21:29:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D61BB2808F for ; Mon, 28 Nov 2016 21:29:36 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBTSZ-0007kz-8D; Mon, 28 Nov 2016 21:27:35 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBTSY-0007kY-6B for xen-devel@lists.xensource.com; Mon, 28 Nov 2016 21:27:34 +0000 Received: from [85.158.137.68] by server-11.bemta-3.messagelabs.com id 16/EF-16257-541AC385; Mon, 28 Nov 2016 21:27:33 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFLMWRWlGSWpSXmKPExsVybKJsh67TQps Ig96J4hb3prxnd2D02N63iz2AMYo1My8pvyKBNWPzyY/MBb/4KqbN2MPWwPiVu4uRi0NIYCqj xJZPl1ghnO1MEi/eX2DvYuTkYBMwlPj7ZBMbiC0ioCzRNLkHzGYWqJdoWHUMzBYWMJH4OW0PW D2LgKrEpR0bmUFsXgFXiQ9t35hAbAkBOYmTxyazgticAj4Sp489A6sREvCWWH32CRtETYbEvJ 45rBC2l8SiG5egbDWJq+c2MU9g5FvAyLCKUb04tagstUjXQi+pKDM9oyQ3MTNH19DAWC83tbg 4MT01JzGpWC85P3cTIzBMGIBgB+OFdudDjJIcTEqivNPdbCKE+JLyUyozEosz4otKc1KLDzHK cHAoSfAyLgDKCRalpqdWpGXmAAMWJi3BwaMkwssPkuYtLkjMLc5Mh0idYlSUEufdMx8oIQCSy CjNg2uDRcklRlkpYV5GoEOEeApSi3IzS1DlXzGKczAqCfOKgIznycwrgZv+CmgxE9Dit6+tQR aXJCKkpBoYT/y4bqHQtn9SdteM7Przgoc2HAhnTuG8/21/GUNb66QPMUu87prsCF7wcNW3itZ bS+WXTLXqr3af02/uFXjDoXN5y1znpenxFmyyP8P+rLmSlSyisqLsn4xu62KGCqlnc7amzC3m 1tyhvzh81fWw6G2a2aoBmry1mUXVv7TYG8yec34+Vd2pxFKckWioxVxUnAgAVZNluY0CAAA= X-Env-Sender: sstabellini@kernel.org X-Msg-Ref: server-15.tower-31.messagelabs.com!1480368449!69359320!1 X-Originating-IP: [198.145.29.136] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.0.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 7724 invoked from network); 28 Nov 2016 21:27:30 -0000 Received: from mail.kernel.org (HELO mail.kernel.org) (198.145.29.136) by server-15.tower-31.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 28 Nov 2016 21:27:30 -0000 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9CA7E201C0; Mon, 28 Nov 2016 21:27:27 +0000 (UTC) Received: from sstabellini-ThinkPad-X260.hsd1.ca.comcast.net (96-82-76-110-static.hfc.comcastbusiness.net [96.82.76.110]) (using TLSv1.2 with cipher AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 72F17201B9; Mon, 28 Nov 2016 21:27:26 +0000 (UTC) From: Stefano Stabellini To: aneesh.kumar@linux.vnet.ibm.com Date: Mon, 28 Nov 2016 13:27:21 -0800 Message-Id: <1480368444-4310-1-git-send-email-sstabellini@kernel.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: X-Virus-Scanned: ClamAV using ClamSMTP Cc: xen-devel@lists.xensource.com, anthony.perard@citrix.com, sstabellini@kernel.org, groug@kaod.org, qemu-devel@nongnu.org Subject: [Xen-devel] [PATCH v2 1/4] 9pfs: move pdus to V9fsState X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP pdus are initialized and used in 9pfs common code. Move the array from V9fsVirtioState to V9fsState. Signed-off-by: Stefano Stabellini Reviewed-by: Greg Kurz --- hw/9pfs/9p.c | 7 +++---- hw/9pfs/9p.h | 1 + hw/9pfs/virtio-9p.h | 1 - 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index aea7e9d..05e950f 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -3440,7 +3440,6 @@ void pdu_submit(V9fsPDU *pdu) /* Returns 0 on success, 1 on failure. */ int v9fs_device_realize_common(V9fsState *s, Error **errp) { - V9fsVirtioState *v = container_of(s, V9fsVirtioState, state); int i, len; struct stat stat; FsDriverEntry *fse; @@ -3451,9 +3450,9 @@ int v9fs_device_realize_common(V9fsState *s, Error **errp) QLIST_INIT(&s->free_list); QLIST_INIT(&s->active_list); for (i = 0; i < (MAX_REQ - 1); i++) { - QLIST_INSERT_HEAD(&s->free_list, &v->pdus[i], next); - v->pdus[i].s = s; - v->pdus[i].idx = i; + QLIST_INSERT_HEAD(&s->free_list, &s->pdus[i], next); + s->pdus[i].s = s; + s->pdus[i].idx = i; } v9fs_path_init(&path); diff --git a/hw/9pfs/9p.h b/hw/9pfs/9p.h index 3976b7f..07cee01 100644 --- a/hw/9pfs/9p.h +++ b/hw/9pfs/9p.h @@ -229,6 +229,7 @@ typedef struct V9fsState char *tag; enum p9_proto_version proto_version; int32_t msize; + V9fsPDU pdus[MAX_REQ]; /* * lock ensuring atomic path update * on rename. diff --git a/hw/9pfs/virtio-9p.h b/hw/9pfs/virtio-9p.h index 25c47c7..52c4b9d 100644 --- a/hw/9pfs/virtio-9p.h +++ b/hw/9pfs/virtio-9p.h @@ -10,7 +10,6 @@ typedef struct V9fsVirtioState VirtIODevice parent_obj; VirtQueue *vq; size_t config_size; - V9fsPDU pdus[MAX_REQ]; VirtQueueElement *elems[MAX_REQ]; V9fsState state; } V9fsVirtioState;