From patchwork Tue Dec 6 14:28:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Rzeszutek Wilk X-Patchwork-Id: 9462707 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DECB560236 for ; Tue, 6 Dec 2016 14:30:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C988C2841B for ; Tue, 6 Dec 2016 14:30:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BC73428421; Tue, 6 Dec 2016 14:30:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RCVD_IN_SORBS_SPAM,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 411A92841B for ; Tue, 6 Dec 2016 14:30:50 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cEGjX-0003Xi-9w; Tue, 06 Dec 2016 14:28:39 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cEGjW-0003Xc-8B for xen-devel@lists.xenproject.org; Tue, 06 Dec 2016 14:28:38 +0000 Received: from [193.109.254.147] by server-10.bemta-6.messagelabs.com id D1/5A-28971-51BC6485; Tue, 06 Dec 2016 14:28:37 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBIsWRWlGSWpSXmKPExsVyMfTOIV2R024 RBp+n6Vh83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBm3tqxhKfjPWvF4okQDYxtrFyMXh5DALEaJ VbdOs4M4LAI3WSTO9F1iA3EkBL6ySMy9OgcowwnkxEjs2faZqYuRA8iulth12AckLCSgJLFl8 mNGiEm7mCSa2lcxgySEBfQkJn+7zQhiswnoSzxde40ZotdN4tM1LpCwiMBmRomWHlMQm1nASG Jy4zsWkBJhATuJ3ispIGEWAVWJbyuWgV3AK+Ai8f/daVaIa+Qkbp7rZJ7AKLCAkWEVo3pxalF ZapGumV5SUWZ6RkluYmaOrqGBmV5uanFxYnpqTmJSsV5yfu4mRmBIMQDBDsZ5J/wPMUpyMCmJ 8qpYukUI8SXlp1RmJBZnxBeV5qQWH2KU4eBQkuANPgmUEyxKTU+tSMvMAQY3TFqCg0dJhFcLJ M1bXJCYW5yZDpE6xWjJcWzW4qdMHAferwCSuzrXPGUSYsnLz0uVEue1AGkQAGnIKM2DGweLwE uMslLCvIxABwrxFKQW5WaWoMq/YhTnYFQS5o0DmcKTmVcCt/UV0EFMQAedOO4MclBJIkJKqoF xhxGvt8aikwUsQbfDe34Ynw4rKt+6SE3HYXtwUqjtsznNvM01zw+JHfu8fKLBftMuu8lSlx2/ u/Tee71WS0eYY15ShvEa/923+CwzjnYwOl28k8UvfYYrLI7R6qhq8rydezxS2kImCJXMa36oX Op9xsCKg89a1mM/39/pnof440USlP99OKDEUpyRaKjFXFScCACeIEF2uwIAAA== X-Env-Sender: ketuzsezr@gmail.com X-Msg-Ref: server-14.tower-27.messagelabs.com!1481034515!63518500!1 X-Originating-IP: [209.85.220.194] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.0.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 7843 invoked from network); 6 Dec 2016 14:28:36 -0000 Received: from mail-qk0-f194.google.com (HELO mail-qk0-f194.google.com) (209.85.220.194) by server-14.tower-27.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 6 Dec 2016 14:28:36 -0000 Received: by mail-qk0-f194.google.com with SMTP id h201so43899203qke.3 for ; Tue, 06 Dec 2016 06:28:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=1XhXXKeJ/ENEtdZjEjx0wm2qGmdak05zTh8tQ6cGRtc=; b=Qv21k0iUYAiBTTd0btElv6GDvRjRHC7pycqjRfd6dUjjq9zQTV8excpsX7rz2VGz0d nmae41HIBoVgbxNZ6M5fKpNE1L1776HTTtE1A0BGxb5AV1mYS0alDmwl72FxO6pJZy7j cfmkjwCcqjpkyWBtQpK9NSVvQH72lK1Y5pAIN1Yoy/d2abf/MPQJPj7/FJhhANPt/R10 F8LIDJDCYjzZuOAn8/at6c9qp48lu7ssCXa3yW5zQVGY8YaUXxD0f0icKR89dXOzY5ND 4p5ERFr2RdvpoqxzfUUok8E4aj6qsmbNcFvTEd0Puw5duTL2RWDLT7wI349KFLBxmNqr XHTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=1XhXXKeJ/ENEtdZjEjx0wm2qGmdak05zTh8tQ6cGRtc=; b=G9RCyBwVdqZVHjn5y2qGC2Vp1Ng2zEk6t+Ua3rAue5BSX2kKTqQwb0VY1cDkYoqPYp vENYm8eyxtU8COiN02fTFN44makCe68ayNE2X5DxlyL6CZbcQ6wlg84FvrgSMK3Oeous DFoW2R1xSP0G/zsczMoS1aNFHqnqWY0318tclF+8C3phk5wc8A03BHXdHXzJmbC/ML0k V8QNlkrm3qXOyTEjykaPegOgPrKGBmc1tQ3xMAAPhwTL/5DcFyNk3Ej4m//7dmjNPg72 7Axzk7QKgGdfLEmR18bS7Wk7ASILuTHvbBXckL2qeJ6O+KeDBrzvuBUiHj/DQh7NzMvA qACA== X-Gm-Message-State: AKaTC0223Idug122lyHydk3/VOHBGdhlx1NfY1Y4qiyMjZ0G1K2ZpBuP/BKMUtsOuImOaw== X-Received: by 10.55.92.199 with SMTP id q190mr54213231qkb.303.1481034515599; Tue, 06 Dec 2016 06:28:35 -0800 (PST) Received: from build-external.dumpdata.com (209-6-196-81.c3-0.smr-ubr2.sbo-smr.ma.cable.rcn.com. [209.6.196.81]) by smtp.gmail.com with ESMTPSA id s41sm12087829qtc.39.2016.12.06.06.28.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Dec 2016 06:28:35 -0800 (PST) From: Konrad Rzeszutek Wilk X-Google-Original-From: Konrad Rzeszutek Wilk To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, bhelgaas@google.com, jgross@suse.com, x86@kernel.org, linux-pci@vger.kernel.org Date: Tue, 6 Dec 2016 09:28:21 -0500 Message-Id: <1481034501-716-1-git-send-email-konrad.wilk@oracle.com> X-Mailer: git-send-email 2.7.4 Subject: [Xen-devel] [PATCH] xen/pci: Bubble up error and fix description. X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP The function is never called under PV guests, and only shows up when MSI (or MSI-X) cannot be allocated. Convert the message to include the error value. Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Juergen Gross --- arch/x86/pci/xen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c index bedfab9..e1fb269 100644 --- a/arch/x86/pci/xen.c +++ b/arch/x86/pci/xen.c @@ -264,8 +264,8 @@ static int xen_hvm_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) return 0; error: - dev_err(&dev->dev, - "Xen PCI frontend has not registered MSI/MSI-X support!\n"); + dev_err(&dev->dev, "Failed to create MSI%s! ret=%d!\n", + type == PCI_CAP_ID_MSI ? "" : "-X", irq); return irq; }