| Message ID | 1481928967-4130-2-git-send-email-alistair.francis@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote: > Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> Why? Thanks! > --- > Config.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Config.mk b/Config.mk > index 3ec7367..e3cda81 100644 > --- a/Config.mk > +++ b/Config.mk > @@ -34,7 +34,7 @@ CONFIG_$(XEN_OS) := y > SHELL ?= /bin/sh > > # Tools to run on system hosting the build > -HOSTCFLAGS = -Wall -Werror -Wstrict-prototypes -O2 -fomit-frame-pointer > +HOSTCFLAGS = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer > HOSTCFLAGS += -fno-strict-aliasing > > DISTDIR ?= $(XEN_ROOT)/dist > -- > 2.7.4 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel
On Sat, Dec 17, 2016 at 7:51 AM, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote: > On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote: >> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> > > > Why? Hey Konrad, The problem that I have is that we build Xen releases in buildroot. As things change (GCC version usually) new warnings are generated for issues that previously never caused any problems. Instead of constantly fixing these small warnings it is easier to disable Werror. I understand that for development this isn't what you want. I just thought it was worth at least sending this up. Maybe a way to disable Werror when configuring would be the best solution? Thanks, Alistair > > Thanks! >> --- >> Config.mk | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Config.mk b/Config.mk >> index 3ec7367..e3cda81 100644 >> --- a/Config.mk >> +++ b/Config.mk >> @@ -34,7 +34,7 @@ CONFIG_$(XEN_OS) := y >> SHELL ?= /bin/sh >> >> # Tools to run on system hosting the build >> -HOSTCFLAGS = -Wall -Werror -Wstrict-prototypes -O2 -fomit-frame-pointer >> +HOSTCFLAGS = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer >> HOSTCFLAGS += -fno-strict-aliasing >> >> DISTDIR ?= $(XEN_ROOT)/dist >> -- >> 2.7.4 >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xen.org >> https://lists.xen.org/xen-devel
On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote: > On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote: >> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> > > > Why? *adjusts his distro maintainer hat* It's considered really bad form for upstreams to push -Werror in their projects. However I know there's upstream interest to keep it. The compromise would probably be to get my rear in gear and get a wider range of distros testing with Travis CI / GitLab CI.
On Mon, Dec 19, 2016 at 7:53 PM, Doug Goldstein <cardoe@cardoe.com> wrote: > On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote: >> On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote: >>> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> >> >> >> Why? > > *adjusts his distro maintainer hat* It's considered really bad form for > upstreams to push -Werror in their projects. However I know there's > upstream interest to keep it. The compromise would probably be to get my > rear in gear and get a wider range of distros testing with Travis CI / > GitLab CI. I agree with both points. I understand why upstream wants it there, but it's a pain. What about an option to override and remove Werror, so it can still be enabled by default? Thanks, Alistair > > -- > Doug Goldstein >
diff --git a/Config.mk b/Config.mk index 3ec7367..e3cda81 100644 --- a/Config.mk +++ b/Config.mk @@ -34,7 +34,7 @@ CONFIG_$(XEN_OS) := y SHELL ?= /bin/sh # Tools to run on system hosting the build -HOSTCFLAGS = -Wall -Werror -Wstrict-prototypes -O2 -fomit-frame-pointer +HOSTCFLAGS = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer HOSTCFLAGS += -fno-strict-aliasing DISTDIR ?= $(XEN_ROOT)/dist
Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> --- Config.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)