| Message ID | 1481928967-4130-6-git-send-email-alistair.francis@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Dec 16, 2016 at 02:56:05PM -0800, Alistair Francis wrote: > To avoid this build error with newer build systems: > error: #warning redirecting incorrect #include <sys/signal.h> to > <signal.h> [-Werror=cpp] And what is the 'newer build system' you speak off? Thanks! > > Rename sys/signal.h to signal.h > > Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> > --- > tools/blktap2/drivers/tapdisk-server.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/blktap2/drivers/tapdisk-server.c b/tools/blktap2/drivers/tapdisk-server.c > index eecde3d..71315bb 100644 > --- a/tools/blktap2/drivers/tapdisk-server.c > +++ b/tools/blktap2/drivers/tapdisk-server.c > @@ -30,7 +30,7 @@ > #include <unistd.h> > #include <stdlib.h> > #include <sys/ioctl.h> > -#include <sys/signal.h> > +#include <signal.h> > > #include "tapdisk-utils.h" > #include "tapdisk-server.h" > -- > 2.7.4 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel
On Sat, Dec 17, 2016 at 7:56 AM, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote: > On Fri, Dec 16, 2016 at 02:56:05PM -0800, Alistair Francis wrote: >> To avoid this build error with newer build systems: >> error: #warning redirecting incorrect #include <sys/signal.h> to >> <signal.h> [-Werror=cpp] > > And what is the 'newer build system' you speak off? Sorry I should have specified more there. It's GCC 5 that I am seeing the problem on. Thanks, Alistair > > Thanks! >> >> Rename sys/signal.h to signal.h >> >> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> >> --- >> tools/blktap2/drivers/tapdisk-server.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/blktap2/drivers/tapdisk-server.c b/tools/blktap2/drivers/tapdisk-server.c >> index eecde3d..71315bb 100644 >> --- a/tools/blktap2/drivers/tapdisk-server.c >> +++ b/tools/blktap2/drivers/tapdisk-server.c >> @@ -30,7 +30,7 @@ >> #include <unistd.h> >> #include <stdlib.h> >> #include <sys/ioctl.h> >> -#include <sys/signal.h> >> +#include <signal.h> >> >> #include "tapdisk-utils.h" >> #include "tapdisk-server.h" >> -- >> 2.7.4 >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xen.org >> https://lists.xen.org/xen-devel
On 12/19/16 12:02 PM, Alistair Francis wrote: > On Sat, Dec 17, 2016 at 7:56 AM, Konrad Rzeszutek Wilk > <konrad.wilk@oracle.com> wrote: >> On Fri, Dec 16, 2016 at 02:56:05PM -0800, Alistair Francis wrote: >>> To avoid this build error with newer build systems: >>> error: #warning redirecting incorrect #include <sys/signal.h> to >>> <signal.h> [-Werror=cpp] >> >> And what is the 'newer build system' you speak off? > > Sorry I should have specified more there. > > It's GCC 5 that I am seeing the problem on. Same as the last patch. This is your libc.
diff --git a/tools/blktap2/drivers/tapdisk-server.c b/tools/blktap2/drivers/tapdisk-server.c index eecde3d..71315bb 100644 --- a/tools/blktap2/drivers/tapdisk-server.c +++ b/tools/blktap2/drivers/tapdisk-server.c @@ -30,7 +30,7 @@ #include <unistd.h> #include <stdlib.h> #include <sys/ioctl.h> -#include <sys/signal.h> +#include <signal.h> #include "tapdisk-utils.h" #include "tapdisk-server.h"
To avoid this build error with newer build systems: error: #warning redirecting incorrect #include <sys/signal.h> to <signal.h> [-Werror=cpp] Rename sys/signal.h to signal.h Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> --- tools/blktap2/drivers/tapdisk-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)