From patchwork Tue Dec 20 12:37:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Edgar E. Iglesias" X-Patchwork-Id: 9481495 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3E82E60237 for ; Tue, 20 Dec 2016 12:39:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 312C028338 for ; Tue, 20 Dec 2016 12:39:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 244A428461; Tue, 20 Dec 2016 12:39:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BB38828338 for ; Tue, 20 Dec 2016 12:39:54 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJJg1-0003td-5j; Tue, 20 Dec 2016 12:37:53 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJJfz-0003tC-Q6 for xen-devel@lists.xen.org; Tue, 20 Dec 2016 12:37:51 +0000 Received: from [85.158.143.35] by server-8.bemta-6.messagelabs.com id 37/58-05787-F1629585; Tue, 20 Dec 2016 12:37:51 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNIsWRWlGSWpSXmKPExsVyMfS6k66cWmS EwaGlKhZLPi5mcWD0OLr7N1MAYxRrZl5SfkUCa8ahXQ2sBVv5Ko4cFmhgnM3dxcjFISQwiVHi xMUnzCAOi8BLFolLl++wdDFyckgI9LNKPPohCmHHSCzac5ANwq6QOP3gKCuILSSgLnH63Q42i EnTmSROLpvABJJgEzCR2PvnAZgtIiAtce3zZUYQm1nAV+LmzuNgcWEBV4mm/zvAhrIIqEosnr CGHcTmFfCQ2HVqGzvEMjmJm+c6mUFsTgFPieWzJ0At9pDY8/E76wRGgQWMDKsYNYpTi8pSi3S NjfWSijLTM0pyEzNzdA0NzPRyU4uLE9NTcxKTivWS83M3MQIDiwEIdjDuXB94iFGSg0lJlHc/ T0SEEF9SfkplRmJxRnxRaU5q8SFGGQ4OJQleftXICCHBotT01Iq0zBxgiMOkJTh4lER4lVWA0 rzFBYm5xZnpEKlTjJYcx2YtfsrEMe0ZiNzVueYpkxBLXn5eqpQ4rwrIPAGQhozSPLhxsDi8xC grJczLCHSgEE9BalFuZgmq/CtGcQ5GJWFeMZApPJl5JXBbXwEdxAR00MLucJCDShIRUlINjMG fjxi/fZlcPn1ycZtf6ZLcPjGR+axvsv9IzmFSkmKx/Fu0wW7XyusfT4u4lZVP9Vq20qUlMs/k 0mV/y94s9QR9a4XlXoVbcy8n54jvSNL10mLlnrbnOUfxZ9GJ6R27/iz2Z1dtCNocWOrA9/6m5 5Z0xbK1MTuy7i5q3Wkv3fI3qJWZvUxPiaU4I9FQi7moOBEAs9mNSr4CAAA= X-Env-Sender: edgar.iglesias@gmail.com X-Msg-Ref: server-12.tower-21.messagelabs.com!1482237470!49222331!1 X-Originating-IP: [209.85.215.66] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.1.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 46476 invoked from network); 20 Dec 2016 12:37:50 -0000 Received: from mail-lf0-f66.google.com (HELO mail-lf0-f66.google.com) (209.85.215.66) by server-12.tower-21.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 20 Dec 2016 12:37:50 -0000 Received: by mail-lf0-f66.google.com with SMTP id p100so10249979lfg.2 for ; Tue, 20 Dec 2016 04:37:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Z1OfgrF25spsD1H8zMcYRDhN0FTRPWFBEFahGQIMGNw=; b=pi3jDgL9wJ2ApVbznW5lon+O/1Sf5MmmV9POJEVTQQbwTullsYUAy40RKSat5tepHj TMPcdhVRq04QpJ1TKxravR4snVK90g+BTg1kEMBlLpecRQUPSODkLwxSfBYURsuCtT6x VZxoBJMl1jjUMhwOSxkXN2I0qjNvu4LwZaP31Uxqz2UC+9uokqeSJIJzi0N3J7XrA4wl 1joQvMmmJ+POIbNCjXamgKAvjdx5/IvSsKIzemqls7PugInViqoo3ez+W+rEDiHHpE6B cBfYAUoGY1CppmvhMd2JBHYtMsrd6DSYE9IR955OwxdCby75WUc14rNXqRisu55f/nJM MCDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Z1OfgrF25spsD1H8zMcYRDhN0FTRPWFBEFahGQIMGNw=; b=LYpWhtjZpXuVTfGZY66johGSHLME7rtU5RgBwWNHqi0sLoZkBviKuzU2YSczLmkKMD kup35FhNUxJB6poS/xAZA+YSfF5++jVWI97O5uyO1u6wrF2Bt09cMEW5thaTiW/kjGDM BsVgDH73zLGsR23rnUlDVHnSnO17ZE3V0o9JIlhYAoyHxicfDCeORFGnj2w11r7S2uiC ohSQi3BFoif4mABXax3XhqQXZ8erywVvy4J1V69Jnw6orhK6lzc9mqbj4918W9zVOj96 KZAHx/TYWLRYgaILD2+HTR98aUJM9g2ZJDtem1cYEMXFVOCFKPr+gOnVO4IA+PpccXIy 4/AQ== X-Gm-Message-State: AKaTC02/8IaioC8ZvHaUzhb9e+ushAwwov+6kgnfsUnCCCetYRc6TucdM8WaJSZ/co1Klg== X-Received: by 10.25.216.214 with SMTP id r83mr6228736lfi.3.1482237469806; Tue, 20 Dec 2016 04:37:49 -0800 (PST) Received: from localhost (81-231-233-234-no56.tbcn.telia.com. [81.231.233.234]) by smtp.gmail.com with ESMTPSA id s7sm4713794lja.14.2016.12.20.04.37.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Dec 2016 04:37:49 -0800 (PST) From: "Edgar E. Iglesias" To: xen-devel@lists.xen.org Date: Tue, 20 Dec 2016 13:37:47 +0100 Message-Id: <1482237467-17879-2-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1482237467-17879-1-git-send-email-edgar.iglesias@gmail.com> References: <1482237467-17879-1-git-send-email-edgar.iglesias@gmail.com> Cc: edgar.iglesias@xilinx.com, julien.grall@arm.com, sstabellini@kernel.org Subject: [Xen-devel] [PATCH v2 1/1] xen/arm: Map mmio-sram nodes as cached memory X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: "Edgar E. Iglesias" Relax the mapping of mmio-sram nodes that do not set the no-memory-wc property to cached normal memory. Rationale: Although on chip memories are relatively fast compared to off-chip memories, large on chip memories are still significantly slower than L1 caches. Depending on the memory, either cached or uncached may make most sense. Also, hardware domains may like to use the memory in a cache-coherent way to avoid SW managed coherency. By mapping it cached at S2, we let hardware domains select cacheability via S1 mappings. Signed-off-by: Edgar E. Iglesias --- xen/arch/arm/domain_build.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 07b868d..08646b8 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -56,8 +56,20 @@ static const struct dt_device_match dev_map_attrs[] __initconst = .data = (void *) (uintptr_t) p2m_mmio_direct_dev, }, { + /* + * Although on chip memories are relatively fast compared to + * off-chip memories, large on chip memories are still + * significantly slower than L1 caches. Depending on the + * memory, either cached or uncached may make most sense. + * + * Also, hardware domains may like to use the memory in a + * cache-coherent way to avoid SW managed coherency. + * + * By mapping it cached at S2, we let hardware domains select + * cacheability via S1 mappings. + */ __DT_MATCH_COMPATIBLE("mmio-sram"), - .data = (void *) (uintptr_t) p2m_mmio_direct_nc, + .data = (void *) (uintptr_t) p2m_mmio_direct_c, }, { /* sentinel */ }, };