From patchwork Thu Apr 6 13:18:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yu Zhang X-Patchwork-Id: 9667419 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EFE3A601EB for ; Thu, 6 Apr 2017 13:40:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A253F283F4 for ; Thu, 6 Apr 2017 13:40:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 93E2E28472; Thu, 6 Apr 2017 13:40:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 222B5283F4 for ; Thu, 6 Apr 2017 13:40:02 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cw7bg-0004R4-0w; Thu, 06 Apr 2017 13:37:48 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cw7be-0004QY-T3 for xen-devel@lists.xen.org; Thu, 06 Apr 2017 13:37:46 +0000 Received: from [193.109.254.147] by server-11.bemta-6.messagelabs.com id AB/6B-03642-AA446E85; Thu, 06 Apr 2017 13:37:46 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeJIrShJLcpLzFFi42Jpa+tw1F3p8iz CoO2MusWSj4tZHBg9ju7+zRTAGMWamZeUX5HAmvFnYzNrwWeeirsT2pgaGBdwdTFycbAI3GKS WNO6ixnEERKYzijx7eAyxi5GTg4JAV6JI8tmsELYfhIPFn1lgShqZ5Ro3/CCDSTBJqAt8WP1b 7AGEQFpiWufL4PZzAISEm1rDwM1c3AIC4RJzDwoDBJmEVCV+P7oOFgrr4CnxKu1s9gg5stJnD w2GWwXp4CXxJFvz9hBbCGgmsffP7JMYORbwMiwilGjOLWoLLVI18hcL6koMz2jJDcxM0fX0MB MLze1uDgxPTUnMalYLzk/dxMjMFAYgGAH4+K1gYcYJTmYlER5FXyeRAjxJeWnVGYkFmfEF5Xm pBYfYtTg4BDoXbP6AqMUS15+XqqSBO9E52cRQoJFqempFWmZOcBQhimV4OBREuHtAUnzFhck5 hZnpkOkTjEqSonzeoAkBEASGaV5cG2w+LnEKCslzMsIdJQQT0FqUW5mCar8K0ZxDkYlYd4zIF N4MvNK4Ka/AlrMBLTY59ZTkMUliQgpqQbGheLzmj7M2zF7xeWOeYdi4rVqjv53k/8VsdSRM8Z s6ZsgKdtXeWpuHZL7es5qTma7tHHOI2a3B+c6P8v//lF7oOx37HTNziPve+9ti7CvCjiS5Gxz +XmNPYunRhfjv7az+05sb+WPt42YunXz9ls7n85dGmOl4bFqt8q5g4sWFF951ppSIPbFSImlO CPRUIu5qDgRAArO/zSaAgAA X-Env-Sender: yu.c.zhang@linux.intel.com X-Msg-Ref: server-3.tower-27.messagelabs.com!1491485862!95782523!2 X-Originating-IP: [134.134.136.65] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.12; banners=-,-,- X-VirusChecked: Checked Received: (qmail 544 invoked from network); 6 Apr 2017 13:37:45 -0000 Received: from mga03.intel.com (HELO mga03.intel.com) (134.134.136.65) by server-3.tower-27.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 6 Apr 2017 13:37:45 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491485865; x=1523021865; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=SbQuVxXnthMcJz7xchVODHpT2tf97a9+ssJo5ggJYPs=; b=OAh4BHSQEwE+9gX4lhBFHdAo01exMfWVRJC9OvUNRNs73UGZ5Ae7AXfA nFlkJCvbut9OpFln9qVPT/NTaDNLrg==; Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Apr 2017 06:37:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,159,1488873600"; d="scan'208";a="85705811" Received: from zhangyu-optiplex-9020.bj.intel.com ([10.238.135.159]) by fmsmga006.fm.intel.com with ESMTP; 06 Apr 2017 06:37:41 -0700 From: Yu Zhang To: xen-devel@lists.xen.org Date: Thu, 6 Apr 2017 21:18:33 +0800 Message-Id: <1491484718-5048-2-git-send-email-yu.c.zhang@linux.intel.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1491484718-5048-1-git-send-email-yu.c.zhang@linux.intel.com> References: <1491484718-5048-1-git-send-email-yu.c.zhang@linux.intel.com> Cc: zhiyuan.lv@intel.com Subject: [Xen-devel] [PATCH v11 1/6] x86/ioreq server: Release the p2m lock after mmio is handled. X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Routine hvmemul_do_io() may need to peek the p2m type of a gfn to select the ioreq server. For example, operations on gfns with p2m_ioreq_server type will be delivered to a corresponding ioreq server, and this requires that the p2m type not be switched back to p2m_ram_rw during the emulation process. To avoid this race condition, we delay the release of p2m lock in hvm_hap_nested_page_fault() until mmio is handled. Note: previously in hvm_hap_nested_page_fault(), put_gfn() was moved before the handling of mmio, due to a deadlock risk between the p2m lock and the event lock(in commit 77b8dfe). Later, a per-event channel lock was introduced in commit de6acb7, to send events. So we do not need to worry about the deadlock issue. Signed-off-by: Yu Zhang Reviewed-by: Jan Beulich --- xen/arch/x86/hvm/hvm.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 2e76c23..d954d65 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -1827,15 +1827,10 @@ int hvm_hap_nested_page_fault(paddr_t gpa, unsigned long gla, (npfec.write_access && (p2m_is_discard_write(p2mt) || (p2mt == p2m_ioreq_server))) ) { - __put_gfn(p2m, gfn); - if ( ap2m_active ) - __put_gfn(hostp2m, gfn); - - rc = 0; if ( !handle_mmio_with_translation(gla, gpa >> PAGE_SHIFT, npfec) ) hvm_inject_hw_exception(TRAP_gp_fault, 0); rc = 1; - goto out; + goto out_put_gfn; } /* Check if the page has been paged out */