diff mbox

x86/microcode: Use the return value from early_microcode_update_cpu

Message ID 1492694280-2437-1-git-send-email-ross.lagerwall@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ross Lagerwall April 20, 2017, 1:18 p.m. UTC 
Use the return value from early_microcode_update_cpu rather than
ignoring it.

Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
---
 xen/arch/x86/microcode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Cooper April 20, 2017, 1:20 p.m. UTC | #1 
On 20/04/17 14:18, Ross Lagerwall wrote:
> Use the return value from early_microcode_update_cpu rather than
> ignoring it.

Spotted by Coverity.

>
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Julien, can we have a release ack please?

~Andrew
Julien Grall April 20, 2017, 3:42 p.m. UTC | #2 
Hi,

On 20/04/17 14:20, Andrew Cooper wrote:
> On 20/04/17 14:18, Ross Lagerwall wrote:
>> Use the return value from early_microcode_update_cpu rather than
>> ignoring it.
>
> Spotted by Coverity.
>
>>
>> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> Julien, can we have a release ack please?

Release-Acked-by: Julien Grall <julien.grall@arm.com>

Cheers,

>
> ~Andrew
>
diff mbox

Patch

diff --git a/xen/arch/x86/microcode.c b/xen/arch/x86/microcode.c
index 4e7dfcd..7558202 100644
--- a/xen/arch/x86/microcode.c
+++ b/xen/arch/x86/microcode.c
@@ -431,5 +431,5 @@  int __init early_microcode_init(void)
         register_cpu_notifier(&microcode_percpu_nfb);
     }
 
-    return 0;
+    return rc;
 }