From patchwork Wed May 3 08:44:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yi Sun X-Patchwork-Id: 9709013 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DA54360385 for ; Wed, 3 May 2017 08:56:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BAB3D28602 for ; Wed, 3 May 2017 08:56:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AF65128604; Wed, 3 May 2017 08:56:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 21EF828606 for ; Wed, 3 May 2017 08:56:27 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5q3T-0001Ku-Qs; Wed, 03 May 2017 08:54:39 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5q3S-0001J1-TJ for xen-devel@lists.xenproject.org; Wed, 03 May 2017 08:54:39 +0000 Received: from [85.158.139.211] by server-11.bemta-5.messagelabs.com id EE/87-01733-ECA99095; Wed, 03 May 2017 08:54:38 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNLMWRWlGSWpSXmKPExsXS1tYhoXt2Fme kwZkLchbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8aMM6vYClY6VBx6dpOpgXGqXhcjF4eQwHRG icVXT7F0MXJySAjwShxZNoMVwvaXOHFyPhtEUQOjxPKNM5hAEmwC6hKPv/aA2SICShL3Vk1mA iliFtjJJLHu9HdmkISwgJvEgknfwIpYBFQlXp49AraBV8BT4l7LN2aIDXISJ49NBtvGCRR//m UjO4gtJOAhcejZe6YJjLwLGBlWMaoXpxaVpRbpGuslFWWmZ5TkJmbm6BoamOrlphYXJ6an5iQ mFesl5+duYgQGBAMQ7GDc+8/pEKMkB5OSKK/6K/ZIIb6k/JTKjMTijPii0pzU4kOMMhwcShK8 D2dyRgoJFqWmp1akZeYAQxMmLcHBoyTC2wWS5i0uSMwtzkyHSJ1i1OV4t/TDeyYhlrz8vFQpc d7pIEUCIEUZpXlwI2BxcolRVkqYlxHoKCGegtSi3MwSVPlXjOIcjErCvMkgU3gy80rgNr0COo IJ6IhmWQ6QI0oSEVJSDYwWKXt9TpZ5lbaW1Z3S/Hkl1O/Hj7hPnFnKwU5GX897V+/mVVg34TF v+eU6hiS5c+aqf2tfPXdT8NMOzzl49sQhye79V4TnVa8zO3jl6Yrs0gsfJ4luXKCSfT7kgepf icMH0z0213UcqDh1R6Tl6rUbG/jrI58fC7uxzPzu7A1XMzZoiJ+7yBqkxFKckWioxVxUnAgAW e8Rn44CAAA= X-Env-Sender: yi.y.sun@linux.intel.com X-Msg-Ref: server-2.tower-206.messagelabs.com!1493801620!75519330!22 X-Originating-IP: [134.134.136.24] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTM0LjEzNC4xMzYuMjQgPT4gMzkwOTcx\n X-StarScan-Received: X-StarScan-Version: 9.4.12; banners=-,-,- X-VirusChecked: Checked Received: (qmail 16335 invoked from network); 3 May 2017 08:54:36 -0000 Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by server-2.tower-206.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 3 May 2017 08:54:36 -0000 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 May 2017 01:54:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,283,1491289200"; d="scan'208";a="852347723" Received: from vmmmba-s2600wft.bj.intel.com ([10.240.193.39]) by FMSMGA003.fm.intel.com with ESMTP; 03 May 2017 01:54:33 -0700 From: Yi Sun To: xen-devel@lists.xenproject.org Date: Wed, 3 May 2017 16:44:21 +0800 Message-Id: <1493801063-38513-22-git-send-email-yi.y.sun@linux.intel.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1493801063-38513-1-git-send-email-yi.y.sun@linux.intel.com> References: <1493801063-38513-1-git-send-email-yi.y.sun@linux.intel.com> Cc: kevin.tian@intel.com, wei.liu2@citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, he.chen@linux.intel.com, ian.jackson@eu.citrix.com, Yi Sun , mengxu@cis.upenn.edu, jbeulich@suse.com, chao.p.peng@linux.intel.com, roger.pau@citrix.com Subject: [Xen-devel] [PATCH v11 21/23] tools: L2 CAT: support show cbm for L2 CAT. X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP This patch implements changes in xl/xc changes to support showing CBM of L2 CAT. The new level option is introduced to original CAT showing command in order to show CBM for specified level CAT. - 'xl psr-cat-show' is updated to show CBM of a domain according to input cache level. Examples: root@:~$ xl psr-cat-show -l2 1 Socket ID : 0 Default CBM : 0xff ID NAME CBM 1 ubuntu14 0x7f Signed-off-by: He Chen Signed-off-by: Yi Sun Acked-by: Wei Liu --- v9: - move xl_cmdimpl.c changes into xl/xl_psr.c. - move xl_cmdtable.c changes into xl/xl_cmdtable.c. v6: - check if input level is correct. - adjust '{' postion for 'if'. (suggested by Wei Liu) v5: - remove 'L2_CBM' in idl because it has been moved to patch 21: "tools: L2 CAT: support get HW info for L2 CAT". (suggested by Wei Liu) v4: - create this patch because of codes architecture change. --- tools/libxc/include/xenctrl.h | 1 + tools/libxc/xc_psr.c | 3 ++ tools/xl/xl_cmdtable.c | 3 +- tools/xl/xl_psr.c | 85 +++++++++++++++++++++++++++++-------------- 4 files changed, 63 insertions(+), 29 deletions(-) diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h index 3fbcd70..0952f75 100644 --- a/tools/libxc/include/xenctrl.h +++ b/tools/libxc/include/xenctrl.h @@ -2444,6 +2444,7 @@ enum xc_psr_cat_type { XC_PSR_CAT_L3_CBM = 1, XC_PSR_CAT_L3_CBM_CODE = 2, XC_PSR_CAT_L3_CBM_DATA = 3, + XC_PSR_CAT_L2_CBM = 4, }; typedef enum xc_psr_cat_type xc_psr_cat_type; diff --git a/tools/libxc/xc_psr.c b/tools/libxc/xc_psr.c index 84a08c4..04f5927 100644 --- a/tools/libxc/xc_psr.c +++ b/tools/libxc/xc_psr.c @@ -299,6 +299,9 @@ int xc_psr_cat_get_domain_data(xc_interface *xch, uint32_t domid, case XC_PSR_CAT_L3_CBM_DATA: cmd = XEN_DOMCTL_PSR_CAT_OP_GET_L3_DATA; break; + case XC_PSR_CAT_L2_CBM: + cmd = XEN_DOMCTL_PSR_CAT_OP_GET_L2_CBM; + break; default: errno = EINVAL; return -1; diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index 30eb93c..539cb64 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -557,7 +557,8 @@ struct cmd_spec cmd_table[] = { { "psr-cat-show", &main_psr_cat_show, 0, 1, "Show Cache Allocation Technology information", - "", + "[options] ", + "-l Specify the cache level to process, otherwise L3 cache is processed\n" }, #endif diff --git a/tools/xl/xl_psr.c b/tools/xl/xl_psr.c index 271b88f..575f4a0 100644 --- a/tools/xl/xl_psr.c +++ b/tools/xl/xl_psr.c @@ -342,7 +342,7 @@ static void psr_cat_print_one_domain_cbm_type(uint32_t domid, uint32_t socketid, } static void psr_cat_print_one_domain_cbm(uint32_t domid, uint32_t socketid, - bool cdp_enabled) + bool cdp_enabled, unsigned int lvl) { char *domain_name; @@ -350,27 +350,38 @@ static void psr_cat_print_one_domain_cbm(uint32_t domid, uint32_t socketid, printf("%5d%25s", domid, domain_name); free(domain_name); - if (!cdp_enabled) { - psr_cat_print_one_domain_cbm_type(domid, socketid, - LIBXL_PSR_CBM_TYPE_L3_CBM); - } else { - psr_cat_print_one_domain_cbm_type(domid, socketid, - LIBXL_PSR_CBM_TYPE_L3_CBM_CODE); + switch (lvl) { + case 3: + if (!cdp_enabled) { + psr_cat_print_one_domain_cbm_type(domid, socketid, + LIBXL_PSR_CBM_TYPE_L3_CBM); + } else { + psr_cat_print_one_domain_cbm_type(domid, socketid, + LIBXL_PSR_CBM_TYPE_L3_CBM_CODE); + psr_cat_print_one_domain_cbm_type(domid, socketid, + LIBXL_PSR_CBM_TYPE_L3_CBM_DATA); + } + break; + case 2: psr_cat_print_one_domain_cbm_type(domid, socketid, - LIBXL_PSR_CBM_TYPE_L3_CBM_DATA); + LIBXL_PSR_CBM_TYPE_L2_CBM); + break; + default: + printf("Input lvl %d is wrong!", lvl); + break; } printf("\n"); } static int psr_cat_print_domain_cbm(uint32_t domid, uint32_t socketid, - bool cdp_enabled) + bool cdp_enabled, unsigned int lvl) { int i, nr_domains; libxl_dominfo *list; if (domid != INVALID_DOMID) { - psr_cat_print_one_domain_cbm(domid, socketid, cdp_enabled); + psr_cat_print_one_domain_cbm(domid, socketid, cdp_enabled, lvl); return 0; } @@ -380,49 +391,59 @@ static int psr_cat_print_domain_cbm(uint32_t domid, uint32_t socketid, } for (i = 0; i < nr_domains; i++) - psr_cat_print_one_domain_cbm(list[i].domid, socketid, cdp_enabled); + psr_cat_print_one_domain_cbm(list[i].domid, socketid, cdp_enabled, lvl); libxl_dominfo_list_free(list, nr_domains); return 0; } -static int psr_cat_print_socket(uint32_t domid, libxl_psr_cat_info *info) +static int psr_cat_print_socket(uint32_t domid, libxl_psr_cat_info *info, + unsigned int lvl) { int rc; uint32_t l3_cache_size; - rc = libxl_psr_cmt_get_l3_cache_size(ctx, info->id, &l3_cache_size); - if (rc) { - fprintf(stderr, "Failed to get l3 cache size for socket:%d\n", - info->id); - return -1; + printf("%-16s: %u\n", "Socket ID", info->id); + + /* So far, CMT only supports L3 cache. */ + if (lvl == 3) { + rc = libxl_psr_cmt_get_l3_cache_size(ctx, info->id, &l3_cache_size); + if (rc) { + fprintf(stderr, "Failed to get l3 cache size for socket:%d\n", + info->id); + return -1; + } + printf("%-16s: %uKB\n", "L3 Cache", l3_cache_size); } - printf("%-16s: %u\n", "Socket ID", info->id); - printf("%-16s: %uKB\n", "L3 Cache", l3_cache_size); printf("%-16s: %#llx\n", "Default CBM", (1ull << info->cbm_len) - 1); if (info->cdp_enabled) printf("%5s%25s%16s%16s\n", "ID", "NAME", "CBM (code)", "CBM (data)"); else printf("%5s%25s%16s\n", "ID", "NAME", "CBM"); - return psr_cat_print_domain_cbm(domid, info->id, info->cdp_enabled); + return psr_cat_print_domain_cbm(domid, info->id, info->cdp_enabled, lvl); } -static int psr_cat_show(uint32_t domid) +static int psr_cat_show(uint32_t domid, unsigned int lvl) { int i, nr; int rc; libxl_psr_cat_info *info; - rc = libxl_psr_cat_get_info(ctx, &info, &nr, 3); + if (lvl != 2 && lvl != 3) { + fprintf(stderr, "Input lvl %d is wrong\n", lvl); + return EXIT_FAILURE; + } + + rc = libxl_psr_cat_get_info(ctx, &info, &nr, lvl); if (rc) { - fprintf(stderr, "Failed to get cat info\n"); + fprintf(stderr, "Failed to get %s cat info\n", (lvl == 3)?"L3":"L2"); return rc; } for (i = 0; i < nr; i++) { - rc = psr_cat_print_socket(domid, info + i); + rc = psr_cat_print_socket(domid, info + i, lvl); if (rc) goto out; } @@ -533,11 +554,19 @@ int main_psr_cat_cbm_set(int argc, char **argv) int main_psr_cat_show(int argc, char **argv) { - int opt; + int opt = 0; uint32_t domid; + unsigned int lvl = 3; - SWITCH_FOREACH_OPT(opt, "", NULL, "psr-cat-show", 0) { - /* No options */ + static struct option opts[] = { + {"level", 1, 0, 'l'}, + COMMON_LONG_OPTS + }; + + SWITCH_FOREACH_OPT(opt, "l:", opts, "psr-cat-show", 0) { + case 'l': + lvl = atoi(optarg); + break; } if (optind >= argc) @@ -549,7 +578,7 @@ int main_psr_cat_show(int argc, char **argv) return 2; } - return psr_cat_show(domid); + return psr_cat_show(domid, lvl); } int main_psr_hwinfo(int argc, char **argv)