From patchwork Thu Jun 29 05:49:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "lan,Tianyu" X-Patchwork-Id: 9816515 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F3D2E6020A for ; Thu, 29 Jun 2017 11:59:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8FBF42521E for ; Thu, 29 Jun 2017 11:59:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8487F28623; Thu, 29 Jun 2017 11:59:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00, DATE_IN_PAST_06_12, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 19D922860B for ; Thu, 29 Jun 2017 11:59:22 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQY3z-0005cu-IS; Thu, 29 Jun 2017 11:56:47 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQY3y-0005cg-OW for xen-devel@lists.xensource.com; Thu, 29 Jun 2017 11:56:46 +0000 Received: from [85.158.139.211] by server-15.bemta-5.messagelabs.com id F1/59-01736-DFAE4595; Thu, 29 Jun 2017 11:56:45 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFLMWRWlGSWpSXmKPExsVywNykQvfvq5B Ig8m31CzuTXnP7sDosb1vF3sAYxRrZl5SfkUCa8bVFzPZC86xVdw59Zi5gfEgaxcjF4eQwHRG iYnPb7N1MXJySAjwShxZNoMVwvaXONS8mBGiqJ1RYs7xh8wgCTYBdYkTiycygtgiApYSs9a3g TUwC2xjlNi3RwHEFhbwkTj06gF7FyMHB4uAqsS1y5EgYV4BF4lt1/pZIOYrSEx5+B5sJKeAq8 S1ZfPZQWwhoJqra3vYJzDyLmBkWMWoUZxaVJZapGtkqZdUlJmeUZKbmJmja2hgqpebWlycmJ6 ak5hUrJecn7uJERgO9QwMjDsYL2/xO8QoycGkJMpr+DwkUogvKT+lMiOxOCO+qDQntfgQowwH h5IEr9dLoJxgUWp6akVaZg4wMGHSEhw8SiK8fSCtvMUFibnFmekQqVOMuhxNH7Z8YRJiycvPS 5US550IMkMApCijNA9uBCxKLjHKSgnzMjIwMAjxFKQW5WaWoMq/YhTnYFQS5s0EmcKTmVcCt+ kV0BFMQEcIzwA7oiQRISXVwNjJdNk2xKK2vfXQmawY3ls/pv64NKtQfytfgEU5D3dEyHImP5b KU6fNPqyZN+vqokSul+9eWnGXKRua3zr8ISxC6fAjFkWb8PsGth9syk5eTQ01uMvMtaZQR3yN XXjn/9Vdl5f9XbbsXMethuSVpUyC+vKiVw/1TZvywWxx2l13oTzv5fs7tZRYijMSDbWYi4oTA ePAH6ONAgAA X-Env-Sender: tianyu.lan@intel.com X-Msg-Ref: server-16.tower-206.messagelabs.com!1498737403!84757966!1 X-Originating-IP: [192.55.52.120] X-SpamReason: No, hits=0.8 required=7.0 tests=DATE_IN_PAST_06_12 X-StarScan-Received: X-StarScan-Version: 9.4.19; banners=-,-,- X-VirusChecked: Checked Received: (qmail 56071 invoked from network); 29 Jun 2017 11:56:45 -0000 Received: from mga04.intel.com (HELO mga04.intel.com) (192.55.52.120) by server-16.tower-206.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 29 Jun 2017 11:56:45 -0000 Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jun 2017 04:56:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,280,1496127600"; d="scan'208";a="120301500" Received: from sky-ws.sh.intel.com (HELO localhost) ([10.239.48.74]) by fmsmga005.fm.intel.com with ESMTP; 29 Jun 2017 04:56:40 -0700 From: Lan Tianyu To: qemu-devel@nongnu.org, xen-devel@lists.xensource.com Date: Thu, 29 Jun 2017 01:49:52 -0400 Message-Id: <1498715394-16402-2-git-send-email-tianyu.lan@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1498715394-16402-1-git-send-email-tianyu.lan@intel.com> References: <1498715394-16402-1-git-send-email-tianyu.lan@intel.com> Cc: Lan Tianyu , kevin.tian@intel.com, sstabellini@kernel.org, mst@redhat.com, anthony.perard@citrix.com, marcel@redhat.com, Chao Gao Subject: [Xen-devel] [PATCH 1/3] i386/msi: Correct mask of destination ID in MSI address X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Chao Gao According to SDM 10.11.1, only [19:12] bits of MSI address are Destination ID, change the mask to avoid ambiguity for VT-d spec has used the bit 4 to indicate a remappable interrupt request. Signed-off-by: Chao Gao Signed-off-by: Lan Tianyu Reviewed-by: Anthony PERARD Reviewed-by: Peter Xu --- include/hw/i386/apic-msidef.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/i386/apic-msidef.h b/include/hw/i386/apic-msidef.h index 8b4d4cc..420b411 100644 --- a/include/hw/i386/apic-msidef.h +++ b/include/hw/i386/apic-msidef.h @@ -26,6 +26,6 @@ #define MSI_ADDR_DEST_ID_SHIFT 12 #define MSI_ADDR_DEST_IDX_SHIFT 4 -#define MSI_ADDR_DEST_ID_MASK 0x00ffff0 +#define MSI_ADDR_DEST_ID_MASK 0x000ff000 #endif /* HW_APIC_MSIDEF_H */