From patchwork Thu Jul 6 01:53:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yi Sun X-Patchwork-Id: 9827465 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 35F26602BD for ; Thu, 6 Jul 2017 02:09:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 248F2285C7 for ; Thu, 6 Jul 2017 02:09:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 10900285C9; Thu, 6 Jul 2017 02:09:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 87DA5285C7 for ; Thu, 6 Jul 2017 02:09:31 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSwCM-0000wE-8Q; Thu, 06 Jul 2017 02:07:18 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSwCL-0000tN-BU for xen-devel@lists.xenproject.org; Thu, 06 Jul 2017 02:07:17 +0000 Received: from [85.158.139.211] by server-3.bemta-5.messagelabs.com id 2F/E8-02022-45B9D595; Thu, 06 Jul 2017 02:07:16 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkkeJIrShJLcpLzFFi42Jpa+uQ1w2cHRt pcLHXxOL7lslMDowehz9cYQlgjGLNzEvKr0hgzWg5cZ6x4KVJxYzJxxgbGFtUuhg5OYQEKiUm Lp3DCGJLCPBKHFk2gxXCDpB4OHMZexcjF1BNA6PEl0dz2UESbALqEo+/9jCB2CICShL3Vk1mA iliFpjPJPH6/ANmkISwQIzE5rd9YA0sAqoSj46dA2vgFfCUaLu0lwVig5zEyWOTwbZxAsWPXG 1mh7jIQ2Jj+2umCYy8CxgZVjFqFKcWlaUW6RpZ6iUVZaZnlOQmZuboGhqY6uWmFhcnpqfmJCY V6yXn525iBAZEPQMD4w7Gy1v8DjFKcjApifL+0Y+NFOJLyk+pzEgszogvKs1JLT7EKMPBoSTB O3cWUE6wKDU9tSItMwcYmjBpCQ4eJRHe1cJAad7igsTc4sx0iNQpRmOOVTN/fmPieDXh/zcmI Za8/LxUKXFee5BJAiClGaV5cINgMXOJUVZKmJeRgYFBiKcgtSg3swRV/hWjOAejkjBvMMgUns y8Erh9r4BOYQI6RbExBuSUkkSElFQDY5fImc7Z2o7LjvZeu3XDOzK6fXJrsdC+fxK7f32r2O3 Y8PJ8x5HNeSrH+67fEg/esMpB6Mg81h8cLnrN85R38t2d++S5xvb02JnfYuU3/l9nMnFX/+N4 d9fv3CquGexl4g2700ROL550InA5Z62otsKO1Wefbnb7rtH9oYX7W3BB9XlPvzBmJSWW4oxEQ y3mouJEAENeQvOUAgAA X-Env-Sender: yi.y.sun@linux.intel.com X-Msg-Ref: server-14.tower-206.messagelabs.com!1499306830!62773795!2 X-Originating-IP: [134.134.136.31] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 9.4.25; banners=-,-,- X-VirusChecked: Checked Received: (qmail 6198 invoked from network); 6 Jul 2017 02:07:13 -0000 Received: from mga06.intel.com (HELO mga06.intel.com) (134.134.136.31) by server-14.tower-206.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 6 Jul 2017 02:07:13 -0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 05 Jul 2017 19:07:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.40,314,1496127600"; d="scan'208"; a="1191048059" Received: from vmmmba-s2600wft.bj.intel.com ([10.240.193.80]) by fmsmga002.fm.intel.com with ESMTP; 05 Jul 2017 19:07:00 -0700 From: Yi Sun To: xen-devel@lists.xenproject.org Date: Thu, 6 Jul 2017 09:53:03 +0800 Message-Id: <1499305996-19029-11-git-send-email-yi.y.sun@linux.intel.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1499305996-19029-1-git-send-email-yi.y.sun@linux.intel.com> References: <1499305996-19029-1-git-send-email-yi.y.sun@linux.intel.com> Cc: kevin.tian@intel.com, wei.liu2@citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, Yi Sun , mengxu@cis.upenn.edu, jbeulich@suse.com, chao.p.peng@linux.intel.com, roger.pau@citrix.com Subject: [Xen-devel] [PATCH v13 10/23] x86: refactor psr: L3 CAT: set value: implement cos finding flow. X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Continue from patch: 'x86: refactor psr: L3 CAT: set value: assemble features value array' We can try to find if there is a COS ID on which all features' COS registers values are same as the array assembled before. Signed-off-by: Yi Sun Reviewed-by: Jan Beulich --- v13: - remove unnecessary blank line. (suggested by Jan Beulich) v12: - use 'ARRAY_SIZE' to calculate array boundary. (suggested by Jan Beulich) - move same type variables declaration to one line. (suggested by Jan Beulich) - use 'ASSERT_UNREACHABLE()' to record bug and return error code if feat exists but props does not exist. (suggested by Jan Beulich) - move 'i' definition into the loop to limit its scope. (suggested by Jan Beulich) v11: - move 'compare_val' implementation from CDP patch to this. (suggested by Jan Beulich) - remove 'rc' in 'compare_val' to make codes clearer. (suggested by Jan Beulich) - changes about 'feat_props'. (suggested by Jan Beulich) - fix bug. (suggested by Jan Beulich) - remove unnecessary variable initialization. (suggested by Jan Beulich) - remove unnecessary comment. (suggested by Jan Beulich) - adjust array check place prior to using the array. (suggested by Jan Beulich) - add comment. v10: - remove 'compare_val' hook and its CAT implementation. Make its functionality be generic in 'find_cos' flow. (suggested by Jan Beulich) - changes related to 'props'. (suggested by Jan Beulich) - rename 'val_array' to 'val_ptr'. (suggested by Jan Beulich) - rename 'find' to 'found'. (suggested by Jan Beulich) - move some variables declaration and initialization into loop. (suggested by Jan Beulich) - adjust codes positions. (suggested by Jan Beulich) v9: - modify comments of 'compare_val' to be same as current implementation. (suggested by Wei Liu) - fix indentation issue. (suggested by Wei Liu) - rename 'l3_cat_compare_val' to 'cat_compare_val' to cover all L3/L2 CAT features. (suggested by Roger Pau) - remove parameter 'found' from 'cat_compare_val' and modify the return values to let caller know if the id is found or not. (suggested by Roger Pau) - replace feature list handling to feature array handling. (suggested by Roger Pau) - replace 'get_cos_num' to 'feat->cos_num'. (suggested by Jan Beulich) - directly use 'cos_reg_val[0]' as default value. (suggested by Jan Beulich) - modify patch title to indicate 'L3 CAT'. (suggested by Jan Beulich) - changes about 'uint64_t' to 'uint32_t'. (suggested by Jan Beulich) v5: - modify commit message to provide exact patch name to continue from. (suggested by Jan Beulich) - remove 'get_cos_max_from_type' because it can be replaced by 'get_cos_max'. - move type check out from callback functions to caller. (suggested by Jan Beulich) - modify variables names to make them better, e.g. 'feat_tmp' to 'feat'. (suggested by Jan Beulich) - modify comments according to changes of codes. (suggested by Jan Beulich) v4: - create this patch to make codes easier to understand. (suggested by Jan Beulich) --- xen/arch/x86/psr.c | 100 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 100 insertions(+) diff --git a/xen/arch/x86/psr.c b/xen/arch/x86/psr.c index 84a8e30..306b02b 100644 --- a/xen/arch/x86/psr.c +++ b/xen/arch/x86/psr.c @@ -752,10 +752,110 @@ static int insert_val_into_array(uint32_t val[], return -EINVAL; } +static int compare_val(const uint32_t val[], + const struct feat_node *feat, + const struct feat_props *props, + unsigned int cos) +{ + unsigned int i; + + for ( i = 0; i < props->cos_num; i++ ) + { + uint32_t feat_val; + + /* If cos is bigger than cos_max, we need compare default value. */ + if ( cos > feat->cos_max ) + { + /* + * COS ID 0 always stores the default value. + * For CDP: + * - DATA default value stored in cos_reg_val[0]; + * - CODE default value stored in cos_reg_val[1]. + */ + feat_val = feat->cos_reg_val[i]; + + /* + * If cos is bigger than feature's cos_max, the val should be + * default value. Otherwise, it fails to find a COS ID. So we + * have to exit find flow. + */ + if ( val[i] != feat_val ) + return -EINVAL; + } + else + { + feat_val = feat->cos_reg_val[cos * props->cos_num + i]; + if ( val[i] != feat_val ) + return 0; + } + } + + return 1; +} + static int find_cos(const uint32_t val[], unsigned int array_len, enum psr_feat_type feat_type, const struct psr_socket_info *info) { + unsigned int cos, cos_max; + const unsigned int *ref = info->cos_ref; + const struct feat_node *feat; + + /* cos_max is the one of the feature which is being set. */ + feat = info->features[feat_type]; + if ( !feat ) + return -ENOENT; + + cos_max = feat->cos_max; + + for ( cos = 0; cos <= cos_max; cos++ ) + { + const uint32_t *val_ptr = val; + unsigned int len = array_len, i; + int rc = 0; + + if ( cos && !ref[cos] ) + continue; + + for ( i = 0; i < ARRAY_SIZE(info->features); i++ ) + { + const struct feat_props *props = feat_props[i]; + + feat = info->features[i]; + if ( !feat ) + continue; + + if ( !props ) + { + ASSERT_UNREACHABLE(); + return -ENOENT; + } + + if ( len < props->cos_num ) + return -ENOSPC; + + /* + * Compare value according to feature array order. + * We must follow this order because value array is assembled + * as this order. + */ + rc = compare_val(val_ptr, feat, props, cos); + if ( rc < 0 ) + return rc; + + /* If fail to match, go to next cos to compare. */ + if ( !rc ) + break; + + len -= props->cos_num; + val_ptr += props->cos_num; + } + + /* For this COS ID all entries in the values array do match. Use it. */ + if ( rc ) + return cos; + } + return -ENOENT; }