From patchwork Mon Aug 14 17:15:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Volodymyr Babchuk X-Patchwork-Id: 9899829 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1C5B9602CA for ; Mon, 14 Aug 2017 17:18:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0640728671 for ; Mon, 14 Aug 2017 17:18:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EF3D72867D; Mon, 14 Aug 2017 17:18:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6A17128671 for ; Mon, 14 Aug 2017 17:18:22 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhIy8-0004Kd-QP; Mon, 14 Aug 2017 17:16:00 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhIy7-0004KF-Rs for xen-devel@lists.xen.org; Mon, 14 Aug 2017 17:15:59 +0000 Received: from [85.158.143.35] by server-3.bemta-6.messagelabs.com id B5/B4-03044-FCAD1995; Mon, 14 Aug 2017 17:15:59 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA1WSW0gUcRTG/c/M7o7iyLgqnqyEtjQRNa1IMQI J0jS7PfSgqDmr0+7C3tpZTZ9au2hrmi4WkkhqG12WEjWNSAwTRUw07WJaEgZdNkvLSi1WsJmd 1Wqevvn/vnPOd+CQuPyMNIRki8ysSc9oFVIfQr0FOxA9/MqWEVtTRSVcm7MTSWhvX6cLO4QyJ Rq90lCUK1GP9ZXhxmZZ0bmZjzILKpWWIx+SoEtwGBhqIcqRN4noLGhrtyIByGkbBiNDI0gAcj oPyhbmcUFL6e3Q3PBEJuhAei2M/XjmLsDpUgQl3W2YAALoTHjRWikVNEGHgXW4xF1A0WnQdeW 2RNBAh8LEsNXd1JveBxWvBzFxWBp0dPYTot8fBi6/c2ucBnjkdOJi7QZ4vziFC4OBvoTA2V9L iMWbocv1xWNaD31D9fw7yev90NQSKT6/wODt1USx9rQMHkzOIRFEwfyrDxIR1Mjg1/w4IYI0u FnX4zEZ4fvHT0g0jUtg8p7dY1oHr2dmMBFUSeDcuMMTKRdml10eUO4LI7/PeoJbZXD9Ypm0Go XX/bNs3T/LNiLMgSI41lTImqLjYmOUJo1KbdYxGi3/tyNGx3Ico2K1jJKLyTPo2hB/C178dx/ 1f83pQWtITBFE5aZXZsj9lIb8YjXDqY+aCrQs14PWkaQCKNWELUPub2JVbNExjZY/qBUMpK8i kAoSMMUZGR2nUYnoMdpGnvrW/hMjp6uXFzA5oTfo2ZBgyiFYacGqLtCvNlo5zqdofUgAhfhoc l8ja9JpzP/zaRRMIkUAxQpdfDV68+q8aT4Kxke5IGxBcWbmLwqxoKiXkrS5pVpWEfC5cTY2bN Eef7fLMnkk2jm+vKs3PLVlNFGzdSClKeJNstKutL68cStrE+N3o4J6WLg2W3ryOLMUvzv9YKo rJ7snYdDSGrmRDN8zX7zN0qA+ERZK2BzPc69Pzd3xqun1w1Py0XmmvsXRnXe40G4cTU4a3Jnc MaUgODUTF4mbOOYPXR10xJcDAAA= X-Env-Sender: Volodymyr_Babchuk@epam.com X-Msg-Ref: server-15.tower-21.messagelabs.com!1502730957!77724605!1 X-Originating-IP: [104.47.2.78] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 15283 invoked from network); 14 Aug 2017 17:15:58 -0000 Received: from mail-db5eur01on0078.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.78) by server-15.tower-21.messagelabs.com with AES256-SHA256 encrypted SMTP; 14 Aug 2017 17:15:58 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=EPAM.onmicrosoft.com; s=selector1-epam-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=IENEIMBVZHnx7RSsJoIhEMx3BmoDclQncEwqrGlUkoQ=; b=BHHMvzDtYRgViM+CBcm+BnbpyWnL+LaWhoOADVsPzzduuCvohJjsUTxDTf9uJ6ZZfUmVyfmgGaPt0nG2Xm4zLwghD0qhh4FmODNdJL9WfgW0O+sofvqffcD1snnar/C3tLP/6YwlGvtYgbAMMxsIJgU2U549oUYHh/0RWMaO44Y= Received: from EPUAKYIW2556.kyiv.epam.com (85.223.209.52) by AM4PR0301MB2130.eurprd03.prod.outlook.com (2603:10a6:200:4d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1341.21; Mon, 14 Aug 2017 17:15:54 +0000 Received: by EPUAKYIW2556.kyiv.epam.com (sSMTP sendmail emulation); Mon, 14 Aug 2017 20:15:43 +0300 From: Volodymyr Babchuk To: xen-devel@lists.xen.org Date: Mon, 14 Aug 2017 20:15:08 +0300 Message-Id: <1502730909-28413-3-git-send-email-volodymyr_babchuk@epam.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1502730909-28413-1-git-send-email-volodymyr_babchuk@epam.com> References: <1502730909-28413-1-git-send-email-volodymyr_babchuk@epam.com> MIME-Version: 1.0 X-Originating-IP: [85.223.209.52] X-ClientProxiedBy: DM5PR16CA0033.namprd16.prod.outlook.com (2603:10b6:4:15::19) To AM4PR0301MB2130.eurprd03.prod.outlook.com (2603:10a6:200:4d::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b7bd7c87-6953-4294-da21-08d4e3381fd5 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:AM4PR0301MB2130; X-Microsoft-Exchange-Diagnostics: 1; AM4PR0301MB2130; 3:oUk8lNS50xWFHNDlUoKd8GW94SGuueduWf/XA0x7RnF24fLxy1dbaI46D4puxLyqD2GICqSEBl5fPybSKJLwsxXJFWRRha8Ghypbcf73mKNZIEHRpWLnE4Tkr1MM4joHqRES0QXRzHvWoWv6dkpZy5ycBMv1AEdSlP6WN5zFrjIa07GtpNP5bdRcL2xqJQNWsM2SD3TCeUuPIubxk6RUDl3VHzgp2Hnljq1XiDxSmIc9SRUcz8IHhOQRSe72giyn; 25:9Rch3CWdvaSBYL2up2Ek0563UgkNq8J1QjXXhozDaDp0oLN93LHIW7Brlqb4N3osslhQJDNlaaUNHwMO/Pv4SotRpWfa28Bs+Cabsegqz3TzLk4TPzt+s8OkrYy7fDeRGBxDoQTXxdAnJ8eewklep78/ma6jwRVkpgkf4Nb5+miuTmLZHxJXeGwqIkC09hv7XoSbVXL+hAofvVerZPf9MllUHNvmzXatReadc58RLKgmK0z6a35/kbmIRueDGcwHQe5Qhni7nqmjadfOQPiGgiCxokGbtQSezYPzfFV/IUFM7FQloI27R2YwPqNTkkfYG3IenPGy27yYCgnICxtgsA==; 31:ZSg/n9AxRfs1ehC4HFm48iis6pGpG4NDOahQ/FbclgaypLalaXZ5ALX4rsonWfwP4H93qNebKAscc+fvteZrp3XtYtC+UdGXy+xPjuLTUF+kX22UYrKE4nAh9+Onk1DUgHQVj8NLk/R/WJIH9AHAuQSm4+W15fjeCGsm9wynbfI+lM5Ly7PnEnGKrXiiFbb4jqMkaeDeW+Ue1R1xIzPvb470XnsGih7jLIsZLp5KmLA= X-MS-TrafficTypeDiagnostic: AM4PR0301MB2130: X-Microsoft-Exchange-Diagnostics: 1; AM4PR0301MB2130; 20:FUYurKw1BrYCToKbn3VY5F/0saBgGBPkX7GEGR3CjKVS1E2wLHL9OsovdV/nzRKikeIMMzO9S2WoK6LxerJ7N7pw5IYqe8psb+Lr5brcRVZ2Q4XkITSrGZ3ohiQSteacox/WChA4vCHN1lm6aM+QSdts/OueO378RcWR01vDWgllVDVuT1UXvcK4pMbGPeI9LLP/s7Hbz7lVHhVXSnmcJkXJrRAHsK3s1j+iGFvxfULxwrxoD1ThCqx1+NeZc5zyIuZj2KscvTjpZ8Sr5e7XPdWD9VCmvar+aVHDPR7pduTGNhwg+Ce0ihSgMF1+x4iSECu5VWt2iaIXJodmZgLKfs9HhTXJuAQ5cNRMvjiyCBHfyk8eeA7Dbukf6ivsszsJJt5rMIXAeoT1buf5TwBYK/fzBU5OnGWGO0nCocXrJISh5nfxsob0LmadN29dJzBlZJgPv5e8pztlX/2ODTQukB/lWe+VDxEcLMOkEcJm9I6/M1hryKWwsKldLuvqEepS; 4:Ms4GsEY6/QZnA2uH98pzwO/1Kh2gGNzR2kqC8TNbw07YRkXu+dUBay4D+xRLHfjYMhvQuTsdIpjU05YnY8ina6ZpY9qXL4oucUlsA1+4yifVscJR1GCvXnmdt+B4StqLX9jYnKd69Q04SbVx53s1Ypfe9OIfmblqQljC+NXW+pNSZbPIiCM3hK6e3fafTELM1dD63pe47D8ujsc6kNxXa/nTBkBSvwbwOeMO4kl1Zc5/e8OEzZwuSpqGYIw3HiU+4czYztHg3jCnIMb0+ofJqNLpsFi5INdwUJYqOek/KVe6pp70yGVaB4AnrNsGcjPbLqJPumUif16uX/VkIz571Q== X-Exchange-Antispam-Report-Test: UriScan:(180628864354917)(4114951738403); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123560025)(20161123558100)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM4PR0301MB2130; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM4PR0301MB2130; X-Forefront-PRVS: 039975700A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6009001)(199003)(189002)(5003940100001)(72206003)(2361001)(189998001)(6116002)(48376002)(3846002)(50466002)(68736007)(80792005)(97736004)(478600001)(110136004)(50226002)(305945005)(86362001)(5660300001)(122856001)(107886003)(54906002)(42186005)(105586002)(36756003)(7736002)(4326008)(66066001)(76176999)(33646002)(7350300001)(50986999)(101416001)(81156014)(81166006)(2351001)(106356001)(53936002)(47776003)(2950100002)(6666003)(6916009)(8676002)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0301MB2130; H:EPUAKYIW2556.kyiv.epam.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: epam.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM4PR0301MB2130; 23:eFnuzZJIeX9HIDwBOEpedxtU9gk8BYpmjw2kEr+?= =?us-ascii?Q?LtY//ZiUZNHu7BcVywWfcDrfeNtiza9IZ17PR+fgLd0eqTN1bqpB4ocNqwOx?= =?us-ascii?Q?Y3OF2QcjQqxTFHbxBVi2dYQuU5UbQpiUbU2b4nI3ycO83hYoYOeAFVLULHLi?= =?us-ascii?Q?sE23ITpQQfYJXI1tW9p/XvuqfO1BkWJllIdb07g1OU0ValoIrNMqC2YhrU1n?= =?us-ascii?Q?zP0ojmu8l6ZUwWy0pMNxzFEC54sLCSC78FcD6mTBtO6X9IJzfF/7ye+MZOAB?= =?us-ascii?Q?uneuuIkkRBxMUycW0hflSCSVsufHJuP1c7Kk7BPLdAuJXyx+rc2TGDPogSOX?= =?us-ascii?Q?zX1jk1NctjT3NNjSvNys8c5K+2DzdJpMz0A7aSrBGpAzo6b2wIO+5cW7R+Z3?= =?us-ascii?Q?plbOofCWLWPXoF5LzVy8qrbMfOsYVe0Bj8TggbNM+/Mirk+qORxY7LrhOFHU?= =?us-ascii?Q?TKTJg2PRWBFipYI4pskCfenmxPvT+08Yn4SklT3H1QfnNmCnaJukr5cuXE0Y?= =?us-ascii?Q?ugbtVngOM8YREusKdevkiY376606GUiFtzvwPoITud5y7SA50D5/zsbOhVyF?= =?us-ascii?Q?OoU1dlz4ZWi76pq0FTMC2GUCNCHKxDVGrZU0U6YFMJkbPmJXzp/wQP+X4M+D?= =?us-ascii?Q?5EI4vPZxa3hpi37bPXCwM2i0PVUtKV2G7YchCCoRPZgxXYNAX2KIeO+ccU6N?= =?us-ascii?Q?1uC6PTgF33ZyCukhJrhyZ4jTffOA/S77Gxvz1oLaTKkemwtjtM0U/92j3wZt?= =?us-ascii?Q?T8FCRZBTEg/KfMCXjHn5yyaDAjWk0smP6YZUjTAB1/hl4wO2o2IxiAve60Mn?= =?us-ascii?Q?3MH2T0qmNhn017/f0tomHl14kL5C0Nz351UkShG3mUN2IlNt5znyVBfYHAZn?= =?us-ascii?Q?7uZZ6zHQBldh3+xOAzarvJvVKkW8EPSPizbYZEAkbKZSIzn0f75SjFNWocSb?= =?us-ascii?Q?tSrxskGzYppkeTmneoE7RyoAbqxhvRCgu7VlEAETXKjzQSVVfgqeh0hM0VM4?= =?us-ascii?Q?UXHXz+hQWRZSwcEI4N1eXA8zE3TCw//ftXiv7LIcHD6IbSoJAmf8oGHmaDA0?= =?us-ascii?Q?ZSS7JzaMUCpfWg1VqlKVbZjXPLZzvqqwQujw/xbVakosAFViinoyXc46OTbF?= =?us-ascii?Q?petpI6phY/Whm3AznxAIx2vvwOXNw4B3a?= X-Microsoft-Exchange-Diagnostics: 1; AM4PR0301MB2130; 6:LEjJtd6JRQwt4z8Q6joQbCPCsmOwI5vmtxKwDa2LzSjlFLsPWU82Vd7kWd615FgdB/97h96Kc6wejJN/EWyRIn7liUQ/i8VJR3GnyDkR00Wewlz6sbn7dHi61ET96R27piLS20ukFr1ooIMPtiE6jD6DiKnvrS1MtTXLEg/91Zk8cdiNB1y2es+a9hJGhXhKEw1ZW0vUL0EOihHoSW9bt1koszMa/Rs5943zkni0p3XGH/JBKQnWd1bdPTPAOTSlhExvyV+hy+u7/faHTzuFVpHTVYBTbsOL5Xa6pWHK96zHrg6M4oBEXzz9iuwMMLL0xESaT8R2oeBhAZckGVgFqQ==; 5:jnuzSBRh2yYUqrkM8RClq1fL4a0Jf32fgPEXoA1wX9XrZVogDimzo/qI7EneQZoKkGrKIdvVKzoye4KROQnWtPMRlgNmF6waOGOrl//ftim7jcvNkXm86YvmVRhmCdmYRNmE6ZuFG8u0GQK2OKtFxg==; 24:JjhwcpYuFKPbWAeW8OqwRAO6296UHrIQRzvRwl4PySEXE8s9Myk89bdUPtUpfe6nRdfcJMyCDpa+gbBoNfoGt64qUXaBUext1A50uZ2h8g4=; 7:1rSEB6UWBbK34dOgNZ9zgN7DrKWscqzmEfGsYMj7eafLBy+9RJ5XwsdxKMujMFpgKIMC1W9aveD90eSV47BvUr3/nS6+9X87C6CSGlooa1KLBOIoMx2QEBRSoQLgNGOlJMbLTr315anpBdnBsemAn+3iEDQWWuVjWpwHB5jx/tSqO4I0NxZ4ht+aJ6zquI+u1ANQTIbgvgAx2bUiBW6vNScp+1izjM8vlKqJi6/UpAU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2017 17:15:54.0500 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0301MB2130 Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: [Xen-devel] [PATCH v3 2/3] arm: traps: handle unknown exceptions in check_conditional_instr() X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP According to ARM architecture reference manual (ARM DDI 0487B.a page D7-2259, ARM DDI 0406C.c page B3-1426), exception with unknown reason (HSR.EC == 0) has no valid bits in HSR (apart from HSR.EC), so we can't check if that was caused by conditional instruction. We need to assume that it is unconditional. Signed-off-by: Volodymyr Babchuk Acked-by: Julien Grall --- xen/arch/arm/traps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index c07999b..eae2212 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -1717,7 +1717,7 @@ static int check_conditional_instr(struct cpu_user_regs *regs, int cond; /* Unconditional Exception classes */ - if ( hsr.ec >= 0x10 ) + if ( hsr.ec == HSR_EC_UNKNOWN || hsr.ec >= 0x10 ) return 1; /* Check for valid condition in hsr */