From patchwork Mon Aug 28 17:32:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksandr Tyshchenko X-Patchwork-Id: 9925925 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B939860380 for ; Mon, 28 Aug 2017 17:34:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AAC462876C for ; Mon, 28 Aug 2017 17:34:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9FB2028770; Mon, 28 Aug 2017 17:34:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6B7BA2876E for ; Mon, 28 Aug 2017 17:34:46 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmNtz-0007Lp-WE; Mon, 28 Aug 2017 17:32:43 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmNty-0007Kb-IG for xen-devel@lists.xenproject.org; Mon, 28 Aug 2017 17:32:42 +0000 Received: from [193.109.254.147] by server-8.bemta-6.messagelabs.com id B5/8D-09901-9B354A95; Mon, 28 Aug 2017 17:32:41 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNIsWRWlGSWpSXmKPExsVyMfS6k+7O4CW RBjdPSlp83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBlN85UKtrBVrPo+gbmBcTtrFyMXh5DAdEaJ 9ttHWEAcFoGXLBJXJuxnBnEkBPpZJQ63tgBlOIGcOInZVzcCJTiA7HKJv11GIGEhASWJ1zs3M 0FMmskk8WLmXlaQBJuAgcT+d0/YQWwRoKJ7qyYzgdjMAhkSx9fMYwOxhQXSJWa+fQdWwyKgKj G1rZEZxOYVcJY493omE8ReOYmb5zrB4pwCLhKP1/YwQix2lvi1qZN5AqPAAkaGVYwaxalFZal FuoZGeklFmekZJbmJmTm6hgZmermpxcWJ6ak5iUnFesn5uZsYgYHFAAQ7GC9vDDjEKMnBpCTK u7NicaQQX1J+SmVGYnFGfFFpTmrxIUYZDg4lCd7ioCWRQoJFqempFWmZOcAQh0lLcPAoifAuB knzFhck5hZnpkOkTjFacly5su4LE0fThy1AcsqB7V+YhFjy8vNSpcR5d4I0CIA0ZJTmwY2Dxe ElRlkpYV5GoAOFeApSi3IzS1DlXzGKczAqCfMmgEzhycwrgdv6CuggJqCDFAUXghxUkoiQkmp gvHH+8UV1K/Zl1fnnP+Q9WhzW6jL54p0Sl3ecbNu+zHqVX1Oew5TaqREhLeKk9O4BW8MdHR6R zA3meZWJVxs6suzO/XKqiBFanrsosfDT3xXvduiU7ntj3/VA/6nPpGeCvxfvOSVspBW8Ttr5c vrU11LXT2k0Nj11eKMQ/mNd7XUVp5B+3UWVSizFGYmGWsxFxYkAM+H7P74CAAA= X-Env-Sender: olekstysh@gmail.com X-Msg-Ref: server-2.tower-27.messagelabs.com!1503941560!54273614!1 X-Originating-IP: [209.85.215.66] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 52418 invoked from network); 28 Aug 2017 17:32:41 -0000 Received: from mail-lf0-f66.google.com (HELO mail-lf0-f66.google.com) (209.85.215.66) by server-2.tower-27.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 28 Aug 2017 17:32:41 -0000 Received: by mail-lf0-f66.google.com with SMTP id l140so766935lfg.3 for ; Mon, 28 Aug 2017 10:32:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=CEOGOoF5NDIuX7xlLRjxSYo+V8juMA7+AoTS+btbREU=; b=Zm32fz0NkYUZi5cXETrutkUuQ57LlX1zjC2xRbZ4U0UxECjZ4NAKo0Ti4vd+bu/FHL Wv5yygjkZnW+gqUzxyk8InN01hfrSmZ9wdFuZvsfi7SzWQockMIiLGy5vmbh1WFK5nYN 1zax4uupUqGTUG1A3yVoYYr+wg+BN+awLIhDsJ/UpzurairNnpQ9E3lnNQIqzoYiGDzk LYCMg/2sTffj3QzLRSeWkTefjw4kVtomEw35STS1VrBuj8JxGyHSFWOMc2RWiDEEEwQo Ro6y1Jn6uRN5EFaowCMCnn8Tfvh0sOF4MQJOVgtHVWlrAS1IR3Zg/PKgd+V5yQUhDyJD uQqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=CEOGOoF5NDIuX7xlLRjxSYo+V8juMA7+AoTS+btbREU=; b=JlOV7Dq+AJYcCpkWWC6v/PjbJcFPt/PNhjHgrANkJVfZlSwOiy7K9rcH9NiqrKAEi9 8YcuNwM8CQt7Xzke6TgZgMyBdMJh69X77z2JHivri4c/9JCmMVheBv0g97VDbhxJrvGq plXrFGjm78flJIUhGPtnRPQC+knjAmiUIi0mGZQGb7A5F72fNUDYnTUzvZQndZertgaG qZH8I5QqyKMrnRUal0u0ewvPZc3bl8wq/CapHiqbKOadN3sitC8FUvZQfiXKM7pSMV1e 4EmimlkUFPdR9p3HV6tfSZ1LSIFAKGjMP3DaMy3M5v11V6m0KDV2kbh/etw6g09n3hdj kKMA== X-Gm-Message-State: AHYfb5g9ck8uUM28VYdrrroRN4rQPTMC9oK3vfidMwujX5eQtJ0yONt1 4CmKuivqBPkUMrjA X-Received: by 10.46.9.129 with SMTP id 123mr537397ljj.171.1503941560265; Mon, 28 Aug 2017 10:32:40 -0700 (PDT) Received: from otyshchenko.kyiv.epam.com (ll-53.209.223.85.sovam.net.ua. [85.223.209.53]) by smtp.gmail.com with ESMTPSA id u6sm156754lfk.56.2017.08.28.10.32.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 28 Aug 2017 10:32:39 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Date: Mon, 28 Aug 2017 20:32:25 +0300 Message-Id: <1503941546-24716-2-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1503941546-24716-1-git-send-email-olekstysh@gmail.com> References: <1503941546-24716-1-git-send-email-olekstysh@gmail.com> Cc: Oleksandr Tyshchenko , julien.grall@arm.com, sstabellini@kernel.org Subject: [Xen-devel] [PATCH v1 1/2] xen/arm: vgic: Check for vgic handler to be initialized before dereferencing it X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Oleksandr Tyshchenko Since domain_vgic_free() can be called when the vgic_ops haven't been initialised yet, always check that d->arch.vgic.handler is not a null. Signed-off-by: Oleksandr Tyshchenko Signed-off-by: Stefano Stabellini --- xen/arch/arm/vgic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c index 7a4e3cd..6cf947c 100644 --- a/xen/arch/arm/vgic.c +++ b/xen/arch/arm/vgic.c @@ -187,7 +187,8 @@ void domain_vgic_free(struct domain *d) } } - d->arch.vgic.handler->domain_free(d); + if ( d->arch.vgic.handler ) + d->arch.vgic.handler->domain_free(d); xfree(d->arch.vgic.shared_irqs); xfree(d->arch.vgic.pending_irqs); xfree(d->arch.vgic.allocated_irqs);