From patchwork Wed Sep 20 19:50:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Boris Ostrovsky X-Patchwork-Id: 9962225 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 614C360234 for ; Wed, 20 Sep 2017 19:50:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 516AE2841C for ; Wed, 20 Sep 2017 19:50:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4288729223; Wed, 20 Sep 2017 19:50:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C7E692841C for ; Wed, 20 Sep 2017 19:49:59 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dukxp-0002la-4l; Wed, 20 Sep 2017 19:47:17 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dukxo-0002lS-7M for xen-devel@lists.xen.org; Wed, 20 Sep 2017 19:47:16 +0000 Received: from [85.158.143.35] by server-6.bemta-6.messagelabs.com id E1/B0-03423-3C5C2C95; Wed, 20 Sep 2017 19:47:15 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBLMWRWlGSWpSXmKPExsUyZ7p8oO7+o4c iDU5NtrBY8nExiwOjx9Hdv5kCGKNYM/OS8isSWDP+d55lLTjFVjHx7kK2BsYVrF2MXBxCAhOZ JN6d+c0I4fxmlFjQuBYqs5FR4uyEx0wQTg+jxN3dm5m7GDk52ASMJM4enc4IYosISEtc+3wZr J1ZYBOjxP5jN5lAEsICoRI7l3wBa2ARUJXYMnU3K4jNK+ApcXzdajBbQkBBYsrD98wQtqHE6Y fbGCcw8ixgZFjFqFGcWlSWWqRraKSXVJSZnlGSm5iZo2toYKaXm1pcnJiempOYVKyXnJ+7iRH ofwYg2MF4eWPAIUZJDiYlUd6sw4cihfiS8lMqMxKLM+KLSnNSiw8xynBwKEnwPjoClBMsSk1P rUjLzAEGIkxagoNHSYT3FEiat7ggMbc4Mx0idYrRmOPGw+t/mDg6bt79wyTEkpeflyolzvsVp FQApDSjNA9uECxCLjHKSgnzMgKdJsRTkFqUm1mCKv+KUZyDUUmY9xDIFJ7MvBK4fa+ATmECOi V7wwGQU0oSEVJSDYw3dsin+2yN41+ULt9hd6HV58n8QhnRAhXrl2WKPDLqX3YIlrstuimUsWr 3lop6BfvkNL9mW+MZrAJTjhp7b5jst4GnO+V6mpjDsS//HAzP81y0vbJC3sbeY6LsyyvfuR6s mG+ltOdPSKG97LXy34KTXnysvZ5ufF48wbDy6KQbNlO1GL4/PabEUpyRaKjFXFScCAD8xicDi wIAAA== X-Env-Sender: boris.ostrovsky@oracle.com X-Msg-Ref: server-13.tower-21.messagelabs.com!1505936830!77966743!1 X-Originating-IP: [156.151.31.81] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTU2LjE1MS4zMS44MSA9PiAyODgzMzk=\n X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 32380 invoked from network); 20 Sep 2017 19:47:11 -0000 Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by server-13.tower-21.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 20 Sep 2017 19:47:11 -0000 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v8KJl5ZI004307 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Sep 2017 19:47:07 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id v8KJl5TA032135 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Sep 2017 19:47:05 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id v8KJl4fV023145; Wed, 20 Sep 2017 19:47:05 GMT Received: from ovs104.us.oracle.com (/10.149.76.204) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 20 Sep 2017 12:47:04 -0700 From: Boris Ostrovsky To: xen-devel@lists.xen.org Date: Wed, 20 Sep 2017 15:50:27 -0400 Message-Id: <1505937027-7604-1-git-send-email-boris.ostrovsky@oracle.com> X-Mailer: git-send-email 1.8.3.1 X-Source-IP: userv0021.oracle.com [156.151.31.71] Cc: kevin.tian@intel.com, jbeulich@suse.com, andrew.cooper3@citrix.com, jun.nakajima@intel.com, Boris Ostrovsky , roger.pau@citrix.com Subject: [Xen-devel] [PATCH] x86/hvm: Remove unnecessary is_hvm_domain() test in construct_vmcs() X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP It's a leftover from PVHv1 days. Signed-off-by: Boris Ostrovsky Reviewed-by: Roger Pau Monné --- xen/arch/x86/hvm/vmx/vmcs.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index f62fe7e..b5100b5 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -1271,14 +1271,10 @@ static int construct_vmcs(struct vcpu *v) vmx_vmcs_exit(v); - /* PVH: paging mode is updated by arch_set_info_guest(). */ - if ( is_hvm_domain(d) ) - { - /* will update HOST & GUEST_CR3 as reqd */ - paging_update_paging_modes(v); + /* will update HOST & GUEST_CR3 as reqd */ + paging_update_paging_modes(v); - vmx_vlapic_msr_changed(v); - } + vmx_vlapic_msr_changed(v); return 0; }