From patchwork Sun Oct 8 07:23:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yi Sun X-Patchwork-Id: 9991733 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 730B360244 for ; Sun, 8 Oct 2017 07:47:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6456928689 for ; Sun, 8 Oct 2017 07:47:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 57E2D28713; Sun, 8 Oct 2017 07:47:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E632028695 for ; Sun, 8 Oct 2017 07:47:35 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e16Gv-0002gO-Fk; Sun, 08 Oct 2017 07:45:13 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e16Gt-0002fh-QA for xen-devel@lists.xenproject.org; Sun, 08 Oct 2017 07:45:12 +0000 Received: from [85.158.139.211] by server-10.bemta-5.messagelabs.com id 83/1F-01781-787D9D95; Sun, 08 Oct 2017 07:45:11 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRWlGSWpSXmKPExsXS1taRott2/Wa kwaVZ0hbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8afVUdYCranVEyf7NrAOMezi5GTQ0igQuLj gtmsILaEAK/EkWUzgGwOIDtA4u7iqi5GLqCSBkaJk083MILUsAmoSzz+2sMEYosIKEncWzWZC aSIWeA3o8SpLYfAEsICgRJ/7u5lB7FZBFQlHj1tZAaxeQXcJW5vn8YIsUxO4uSxyWCLOQU8JG ad38AOcZC7xOrV7YwQ9YISJ2c+YQE5iBlo8fp5QiBhZgF5ieats5knMArMQlI1C6FqFpKqBYz MqxjVi1OLylKLdA31kooy0zNKchMzc3QNDUz1clOLixPTU3MSk4r1kvNzNzECw7KegYFxB2NT r/MhRkkOJiVR3j9XbkYK8SXlp1RmJBZnxBeV5qQWH2KU4eBQkuDdeg0oJ1iUmp5akZaZA4wQm LQEB4+SCO/kS0Bp3uKCxNzizHSI1ClGXY6Om3f/MAmx5OXnpUqJ8x4BmSEAUpRRmgc3Ahatlx hlpYR5GRkYGIR4ClKLcjNLUOVfMYpzMCoJ834DmcKTmVcCt+kV0BFMQEcwFt8AOaIkESEl1cC oq1G7Krir833aREeuTC5hbsWuLzvLBfZHhLJvmtsreHyB4dqL34ok3S/eO7zGS//PFoHKSYfK mxLvWpgmv+09wTz5rcrkSq9jW6OqHrdZ/048cKb/+cZLW9T0H2hKfjRYMZ35+zcDidST84ta8 gXWvtll2dquejgrP2LSpnvbfcPmbj5dNiVMiaU4I9FQi7moOBEAfRelxtECAAA= X-Env-Sender: yi.y.sun@linux.intel.com X-Msg-Ref: server-11.tower-206.messagelabs.com!1507448706!86188759!3 X-Originating-IP: [134.134.136.100] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 28019 invoked from network); 8 Oct 2017 07:45:10 -0000 Received: from mga07.intel.com (HELO mga07.intel.com) (134.134.136.100) by server-11.tower-206.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 8 Oct 2017 07:45:10 -0000 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP; 08 Oct 2017 00:45:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.42,493,1500966000"; d="scan'208"; a="1022874825" Received: from vmmmba-s2600wft.bj.intel.com ([10.240.193.75]) by orsmga003.jf.intel.com with ESMTP; 08 Oct 2017 00:44:28 -0700 From: Yi Sun To: xen-devel@lists.xenproject.org Date: Sun, 8 Oct 2017 15:23:48 +0800 Message-Id: <1507447441-5422-4-git-send-email-yi.y.sun@linux.intel.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1507447441-5422-1-git-send-email-yi.y.sun@linux.intel.com> References: <1507447441-5422-1-git-send-email-yi.y.sun@linux.intel.com> MIME-Version: 1.0 Cc: Wei Liu , Yi Sun , Andrew Cooper , Jan Beulich , Chao Peng , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [Xen-devel] [PATCH v6 03/16] x86: rename 'cbm_type' to 'psr_type' to make it general X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP This patch renames 'cbm_type' to 'psr_type' to generalize it. Then, we can reuse this for all psr allocation features. Signed-off-by: Yi Sun Reviewed-by: Wei Liu Reviewed-by: Roger Pau Monné Acked-by: Jan Beulich --- CC: Jan Beulich CC: Andrew Cooper CC: Wei Liu CC: Roger Pau Monné CC: Chao Peng v5: - correct character of reviewer's name. (suggested by Jan Beulich) v4: - fix words in commit message. (suggested by Roger Pau Monné) v3: - replace 'psr_val_type' to 'psr_type' and remove '_VAL' from the enum items. (suggested by Roger Pau Monné) v2: - replace 'PSR_VAL_TYPE_{L3, L2}' to 'PSR_VAL_TYPE_{L3, L2}_CBM'. (suggested by Chao Peng) --- xen/arch/x86/domctl.c | 16 ++++++------ xen/arch/x86/psr.c | 62 +++++++++++++++++++++++++---------------------- xen/arch/x86/sysctl.c | 4 +-- xen/include/asm-x86/psr.h | 18 +++++++------- 4 files changed, 52 insertions(+), 48 deletions(-) diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c index 8a6004b..0cd18a6 100644 --- a/xen/arch/x86/domctl.c +++ b/xen/arch/x86/domctl.c @@ -1454,41 +1454,41 @@ long arch_do_domctl( case XEN_DOMCTL_PSR_SET_L3_CBM: ret = psr_set_val(d, domctl->u.psr_alloc.target, domctl->u.psr_alloc.data, - PSR_CBM_TYPE_L3); + PSR_TYPE_L3_CBM); break; case XEN_DOMCTL_PSR_SET_L3_CODE: ret = psr_set_val(d, domctl->u.psr_alloc.target, domctl->u.psr_alloc.data, - PSR_CBM_TYPE_L3_CODE); + PSR_TYPE_L3_CODE); break; case XEN_DOMCTL_PSR_SET_L3_DATA: ret = psr_set_val(d, domctl->u.psr_alloc.target, domctl->u.psr_alloc.data, - PSR_CBM_TYPE_L3_DATA); + PSR_TYPE_L3_DATA); break; case XEN_DOMCTL_PSR_SET_L2_CBM: ret = psr_set_val(d, domctl->u.psr_alloc.target, domctl->u.psr_alloc.data, - PSR_CBM_TYPE_L2); + PSR_TYPE_L2_CBM); break; case XEN_DOMCTL_PSR_GET_L3_CBM: - ret = domctl_psr_get_val(d, domctl, PSR_CBM_TYPE_L3, copyback); + ret = domctl_psr_get_val(d, domctl, PSR_TYPE_L3_CBM, copyback); break; case XEN_DOMCTL_PSR_GET_L3_CODE: - ret = domctl_psr_get_val(d, domctl, PSR_CBM_TYPE_L3_CODE, copyback); + ret = domctl_psr_get_val(d, domctl, PSR_TYPE_L3_CODE, copyback); break; case XEN_DOMCTL_PSR_GET_L3_DATA: - ret = domctl_psr_get_val(d, domctl, PSR_CBM_TYPE_L3_DATA, copyback); + ret = domctl_psr_get_val(d, domctl, PSR_TYPE_L3_DATA, copyback); break; case XEN_DOMCTL_PSR_GET_L2_CBM: - ret = domctl_psr_get_val(d, domctl, PSR_CBM_TYPE_L2, copyback); + ret = domctl_psr_get_val(d, domctl, PSR_TYPE_L2_CBM, copyback); break; default: diff --git a/xen/arch/x86/psr.c b/xen/arch/x86/psr.c index dbf7a4c..263ddbe 100644 --- a/xen/arch/x86/psr.c +++ b/xen/arch/x86/psr.c @@ -100,24 +100,24 @@ static const struct feat_props { unsigned int cos_num; /* - * An array to save all 'enum cbm_type' values of the feature. It is + * An array to save all 'enum psr_type' values of the feature. It is * used with cos_num together to get/write a feature's COS registers * values one by one. */ - enum cbm_type type[MAX_COS_NUM]; + enum psr_type type[MAX_COS_NUM]; /* * alt_type is 'alternative type'. When this 'alt_type' is input, the * feature does some special operations. */ - enum cbm_type alt_type; + enum psr_type alt_type; /* get_feat_info is used to return feature HW info through sysctl. */ bool (*get_feat_info)(const struct feat_node *feat, uint32_t data[], unsigned int array_len); /* write_msr is used to write out feature MSR register. */ - void (*write_msr)(unsigned int cos, uint32_t val, enum cbm_type type); + void (*write_msr)(unsigned int cos, uint32_t val, enum psr_type type); } *feat_props[FEAT_TYPE_NUM]; /* @@ -215,13 +215,13 @@ static void free_socket_resources(unsigned int socket) bitmap_zero(info->dom_set, DOMID_IDLE + 1); } -static enum psr_feat_type psr_cbm_type_to_feat_type(enum cbm_type type) +static enum psr_feat_type psr_type_to_feat_type(enum psr_type type) { enum psr_feat_type feat_type = FEAT_TYPE_UNKNOWN; switch ( type ) { - case PSR_CBM_TYPE_L3: + case PSR_TYPE_L3_CBM: feat_type = FEAT_TYPE_L3_CAT; /* @@ -233,12 +233,12 @@ static enum psr_feat_type psr_cbm_type_to_feat_type(enum cbm_type type) break; - case PSR_CBM_TYPE_L3_DATA: - case PSR_CBM_TYPE_L3_CODE: + case PSR_TYPE_L3_DATA: + case PSR_TYPE_L3_CODE: feat_type = FEAT_TYPE_L3_CDP; break; - case PSR_CBM_TYPE_L2: + case PSR_TYPE_L2_CBM: feat_type = FEAT_TYPE_L2_CAT; break; @@ -362,15 +362,16 @@ static bool cat_get_feat_info(const struct feat_node *feat, } /* L3 CAT props */ -static void l3_cat_write_msr(unsigned int cos, uint32_t val, enum cbm_type type) +static void l3_cat_write_msr(unsigned int cos, uint32_t val, + enum psr_type type) { wrmsrl(MSR_IA32_PSR_L3_MASK(cos), val); } static const struct feat_props l3_cat_props = { .cos_num = 1, - .type[0] = PSR_CBM_TYPE_L3, - .alt_type = PSR_CBM_TYPE_UNKNOWN, + .type[0] = PSR_TYPE_L3_CBM, + .alt_type = PSR_TYPE_UNKNOWN, .get_feat_info = cat_get_feat_info, .write_msr = l3_cat_write_msr, }; @@ -387,9 +388,10 @@ static bool l3_cdp_get_feat_info(const struct feat_node *feat, return true; } -static void l3_cdp_write_msr(unsigned int cos, uint32_t val, enum cbm_type type) +static void l3_cdp_write_msr(unsigned int cos, uint32_t val, + enum psr_type type) { - wrmsrl(((type == PSR_CBM_TYPE_L3_DATA) ? + wrmsrl(((type == PSR_TYPE_L3_DATA) ? MSR_IA32_PSR_L3_MASK_DATA(cos) : MSR_IA32_PSR_L3_MASK_CODE(cos)), val); @@ -397,23 +399,24 @@ static void l3_cdp_write_msr(unsigned int cos, uint32_t val, enum cbm_type type) static const struct feat_props l3_cdp_props = { .cos_num = 2, - .type[0] = PSR_CBM_TYPE_L3_DATA, - .type[1] = PSR_CBM_TYPE_L3_CODE, - .alt_type = PSR_CBM_TYPE_L3, + .type[0] = PSR_TYPE_L3_DATA, + .type[1] = PSR_TYPE_L3_CODE, + .alt_type = PSR_TYPE_L3_CBM, .get_feat_info = l3_cdp_get_feat_info, .write_msr = l3_cdp_write_msr, }; /* L2 CAT props */ -static void l2_cat_write_msr(unsigned int cos, uint32_t val, enum cbm_type type) +static void l2_cat_write_msr(unsigned int cos, uint32_t val, + enum psr_type type) { wrmsrl(MSR_IA32_PSR_L2_MASK(cos), val); } static const struct feat_props l2_cat_props = { .cos_num = 1, - .type[0] = PSR_CBM_TYPE_L2, - .alt_type = PSR_CBM_TYPE_UNKNOWN, + .type[0] = PSR_TYPE_L2_CBM, + .alt_type = PSR_TYPE_UNKNOWN, .get_feat_info = cat_get_feat_info, .write_msr = l2_cat_write_msr, }; @@ -675,7 +678,7 @@ static struct psr_socket_info *get_socket_info(unsigned int socket) return socket_info + socket; } -int psr_get_info(unsigned int socket, enum cbm_type type, +int psr_get_info(unsigned int socket, enum psr_type type, uint32_t data[], unsigned int array_len) { const struct psr_socket_info *info = get_socket_info(socket); @@ -687,7 +690,7 @@ int psr_get_info(unsigned int socket, enum cbm_type type, if ( IS_ERR(info) ) return PTR_ERR(info); - feat_type = psr_cbm_type_to_feat_type(type); + feat_type = psr_type_to_feat_type(type); if ( feat_type >= ARRAY_SIZE(info->features) ) return -ENOENT; @@ -708,7 +711,7 @@ int psr_get_info(unsigned int socket, enum cbm_type type, } int psr_get_val(struct domain *d, unsigned int socket, - uint32_t *val, enum cbm_type type) + uint32_t *val, enum psr_type type) { const struct psr_socket_info *info = get_socket_info(socket); const struct feat_node *feat; @@ -720,7 +723,7 @@ int psr_get_val(struct domain *d, unsigned int socket, if ( IS_ERR(info) ) return PTR_ERR(info); - feat_type = psr_cbm_type_to_feat_type(type); + feat_type = psr_type_to_feat_type(type); if ( feat_type >= ARRAY_SIZE(info->features) ) return -ENOENT; @@ -850,7 +853,7 @@ static int insert_val_into_array(uint32_t val[], unsigned int array_len, const struct psr_socket_info *info, enum psr_feat_type feat_type, - enum cbm_type type, + enum psr_type type, uint32_t new_val) { const struct feat_node *feat; @@ -886,8 +889,9 @@ static int insert_val_into_array(uint32_t val[], /* * Value setting position is same as feature array. * For CDP, user may set both DATA and CODE to same value. For such case, - * user input 'PSR_CBM_TYPE_L3' as type. The alternative type of CDP is same - * as it. So we should set new_val to both of DATA and CODE under such case. + * user input 'PSR_TYPE_L3_CBM' as type. The alternative type of CDP is + * same as it. So we should set new_val to both of DATA and CODE under such + * case. */ for ( i = 0; i < props->cos_num; i++ ) { @@ -1182,7 +1186,7 @@ static int write_psr_msrs(unsigned int socket, unsigned int cos, } int psr_set_val(struct domain *d, unsigned int socket, - uint64_t new_val, enum cbm_type type) + uint64_t new_val, enum psr_type type) { unsigned int old_cos, array_len; int cos, ret; @@ -1198,7 +1202,7 @@ int psr_set_val(struct domain *d, unsigned int socket, if ( new_val != val ) return -EINVAL; - feat_type = psr_cbm_type_to_feat_type(type); + feat_type = psr_type_to_feat_type(type); if ( feat_type >= ARRAY_SIZE(info->features) || !info->features[feat_type] ) return -ENOENT; diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c index 8ae6747..6867ee1 100644 --- a/xen/arch/x86/sysctl.c +++ b/xen/arch/x86/sysctl.c @@ -179,7 +179,7 @@ long arch_do_sysctl( case XEN_SYSCTL_PSR_get_l3_info: { ret = psr_get_info(sysctl->u.psr_alloc.target, - PSR_CBM_TYPE_L3, data, ARRAY_SIZE(data)); + PSR_TYPE_L3_CBM, data, ARRAY_SIZE(data)); if ( ret ) break; @@ -198,7 +198,7 @@ long arch_do_sysctl( case XEN_SYSCTL_PSR_get_l2_info: { ret = psr_get_info(sysctl->u.psr_alloc.target, - PSR_CBM_TYPE_L2, data, ARRAY_SIZE(data)); + PSR_TYPE_L2_CBM, data, ARRAY_SIZE(data)); if ( ret ) break; diff --git a/xen/include/asm-x86/psr.h b/xen/include/asm-x86/psr.h index 18a42f3..cb3f067 100644 --- a/xen/include/asm-x86/psr.h +++ b/xen/include/asm-x86/psr.h @@ -53,12 +53,12 @@ struct psr_cmt { struct psr_cmt_l3 l3; }; -enum cbm_type { - PSR_CBM_TYPE_L3, - PSR_CBM_TYPE_L3_CODE, - PSR_CBM_TYPE_L3_DATA, - PSR_CBM_TYPE_L2, - PSR_CBM_TYPE_UNKNOWN, +enum psr_type { + PSR_TYPE_L3_CBM, + PSR_TYPE_L3_CODE, + PSR_TYPE_L3_DATA, + PSR_TYPE_L2_CBM, + PSR_TYPE_UNKNOWN, }; extern struct psr_cmt *psr_cmt; @@ -72,12 +72,12 @@ int psr_alloc_rmid(struct domain *d); void psr_free_rmid(struct domain *d); void psr_ctxt_switch_to(struct domain *d); -int psr_get_info(unsigned int socket, enum cbm_type type, +int psr_get_info(unsigned int socket, enum psr_type type, uint32_t data[], unsigned int array_len); int psr_get_val(struct domain *d, unsigned int socket, - uint32_t *val, enum cbm_type type); + uint32_t *val, enum psr_type type); int psr_set_val(struct domain *d, unsigned int socket, - uint64_t val, enum cbm_type type); + uint64_t val, enum psr_type type); void psr_domain_init(struct domain *d); void psr_domain_free(struct domain *d);