From patchwork Mon Oct 16 03:04:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yi Sun X-Patchwork-Id: 10007601 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5CD57601E7 for ; Mon, 16 Oct 2017 03:28:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5009F27D29 for ; Mon, 16 Oct 2017 03:28:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4E72127CF3; Mon, 16 Oct 2017 03:28:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9509F27BA5 for ; Mon, 16 Oct 2017 03:28:19 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3w2D-0002XS-BX; Mon, 16 Oct 2017 03:25:45 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3w2C-0002WC-98 for xen-devel@lists.xenproject.org; Mon, 16 Oct 2017 03:25:44 +0000 Received: from [85.158.137.68] by server-9.bemta-3.messagelabs.com id 76/7B-05363-7B624E95; Mon, 16 Oct 2017 03:25:43 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRWlGSWpSXmKPExsXS1tYhr7tN7Um kwZ/ZNhbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8aK8xcZCw7rVrQ8WMHYwLhYqYuRk0NIoELi 2MUOJhBbQoBX4siyGawQto/E09uXmLsYuYBqGhglNvy+xAKSYBNQl3j8tQesQURASeLeqslgN rPAdUaJnrmxILawQKzEgi+rgJo5OFgEVCUadumBhHkFPCSuvHnKCDFfTuLksclguziB4jPvbm IDKRcScJe4eEUdolxQ4uTMJywgYWagrevnCUEskpdo3jqbeQKjwCwkVbMQqmYhqVrAyLyKUaM 4tagstUjXyEQvqSgzPaMkNzEzR9fQwFgvN7W4ODE9NScxqVgvOT93EyMwLOsZGBh3ML467neI UZKDSUmU91zrw0ghvqT8lMqMxOKM+KLSnNTiQ4wyHBxKErzbVZ9ECgkWpaanVqRl5gAjBCYtw cGjJMI7CSTNW1yQmFucmQ6ROsWoy9Fx8+4fJiGWvPy8VClx3isgRQIgRRmleXAjYNF6iVFWSp iXkYGBQYinILUoN7MEVf4VozgHo5Iw7y2QKTyZeSVwm14BHcEEdMS7iAcgR5QkIqSkGhhNUna cTYvc+WJee0iFlUklp2+ey4RivtQTmSlVr5l1L+2RkE8SfLIv+WfzzBCvzPg47XbZusVd1s7S CxPOCZ35Xxew/MPOQ3VmAjqO0nNvtdzyfO3z3fnf6s1n3XuY91aqbTc6sejPUn5xd52E93Jc7 rx5X+P/cq2fvMCtUr5PTLTpUZ6YjhJLcUaioRZzUXEiAAw9gM/RAgAA X-Env-Sender: yi.y.sun@linux.intel.com X-Msg-Ref: server-9.tower-31.messagelabs.com!1508124315!54894109!10 X-Originating-IP: [134.134.136.31] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 36081 invoked from network); 16 Oct 2017 03:25:42 -0000 Received: from mga06.intel.com (HELO mga06.intel.com) (134.134.136.31) by server-9.tower-31.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 16 Oct 2017 03:25:42 -0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP; 15 Oct 2017 20:25:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,371,1503385200"; d="scan'208";a="533663" Received: from vmmmba-s2600wft.bj.intel.com ([10.240.193.75]) by orsmga001.jf.intel.com with ESMTP; 15 Oct 2017 20:25:39 -0700 From: Yi Sun To: xen-devel@lists.xenproject.org Date: Mon, 16 Oct 2017 11:04:14 +0800 Message-Id: <1508123061-6600-10-git-send-email-yi.y.sun@linux.intel.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1508123061-6600-1-git-send-email-yi.y.sun@linux.intel.com> References: <1508123061-6600-1-git-send-email-yi.y.sun@linux.intel.com> MIME-Version: 1.0 Cc: Wei Liu , Chao Peng , Yi Sun , Ian Jackson , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [Xen-devel] [PATCH v8 09/16] tools: create general interfaces to support psr allocation features X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP This patch creates general interfaces in libxl to support all psr allocation features. Add 'LIBXL_HAVE_PSR_GENERIC' to indicate interface change. Please note, the functionality cannot work until later patches are applied. Signed-off-by: Yi Sun Reviewed-by: Roger Pau Monné Acked-by: Wei Liu --- CC: Wei Liu CC: Ian Jackson CC: Roger Pau Monné CC: Chao Peng v5: - adjust parameters position in 'libxl_psr_get_hw_info'. (suggested by Roger Pau Monné) v4: - add description for LIBXL_HAVE_PSR_GENERIC to mention newly added public functions. (suggested by Roger Pau Monné) v3: - change 'LIBXL_HAVE_PSR_MBA' to 'LIBXL_HAVE_PSR_GENERIC'. (suggested by Roger Pau Monné) - 'typedef enum libxl_psr_cbm_type libxl_psr_type;' in libxl.h. (suggested by Roger Pau Monné and Wei Liu) - change 'libxl_psr_cbm_type' to 'libxl_psr_type' in newly defined interfaces. (suggested by Roger Pau Monné) v2: - remove '_INFO' in 'libxl_psr_feat_type' and make corresponding changes in 'libxl_psr_hw_info'. (suggested by Chao Peng) --- tools/libxl/libxl.h | 37 +++++++++++++++++++++++++++++++++++++ tools/libxl/libxl_psr.c | 25 +++++++++++++++++++++++++ tools/libxl/libxl_types.idl | 22 ++++++++++++++++++++++ 3 files changed, 84 insertions(+) diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h index f82b91e..11c87aa 100644 --- a/tools/libxl/libxl.h +++ b/tools/libxl/libxl.h @@ -976,6 +976,17 @@ void libxl_mac_copy(libxl_ctx *ctx, libxl_mac *dst, const libxl_mac *src); #define LIBXL_HAVE_PSR_L2_CAT 1 /* + * LIBXL_HAVE_PSR_GENERIC + * + * If this is defined, the Memory Bandwidth Allocation feature is supported. + * The following public functions are available: + * libxl_psr_{set/get}_val + * libxl_psr_get_hw_info + * libxl_psr_hw_info_list_free + */ +#define LIBXL_HAVE_PSR_GENERIC 1 + +/* * LIBXL_HAVE_MCA_CAPS * * If this is defined, setting MCA capabilities for HVM domain is supported. @@ -2296,6 +2307,32 @@ int libxl_psr_cat_get_info(libxl_ctx *ctx, libxl_psr_cat_info **info, int libxl_psr_cat_get_l3_info(libxl_ctx *ctx, libxl_psr_cat_info **info, int *nr); void libxl_psr_cat_info_list_free(libxl_psr_cat_info *list, int nr); + +typedef enum libxl_psr_cbm_type libxl_psr_type; + +/* + * Function to set a domain's value. It operates on a single or multiple + * target(s) defined in 'target_map'. 'target_map' specifies all the sockets + * to be operated on. + */ +int libxl_psr_set_val(libxl_ctx *ctx, uint32_t domid, + libxl_psr_type type, libxl_bitmap *target_map, + uint64_t val); +/* + * Function to get a domain's cbm. It operates on a single 'target'. + * 'target' specifies which socket to be operated on. + */ +int libxl_psr_get_val(libxl_ctx *ctx, uint32_t domid, + libxl_psr_type type, unsigned int target, + uint64_t *val); +/* + * On success, the function returns an array of elements in 'info', + * and the length in 'nr'. + */ +int libxl_psr_get_hw_info(libxl_ctx *ctx, libxl_psr_feat_type type, + unsigned int lvl, unsigned int *nr, + libxl_psr_hw_info **info); +void libxl_psr_hw_info_list_free(libxl_psr_hw_info *list, unsigned int nr); #endif /* misc */ diff --git a/tools/libxl/libxl_psr.c b/tools/libxl/libxl_psr.c index 197505a..d4f5f67 100644 --- a/tools/libxl/libxl_psr.c +++ b/tools/libxl/libxl_psr.c @@ -428,6 +428,31 @@ void libxl_psr_cat_info_list_free(libxl_psr_cat_info *list, int nr) free(list); } +int libxl_psr_set_val(libxl_ctx *ctx, uint32_t domid, + libxl_psr_type type, libxl_bitmap *target_map, + uint64_t val) +{ + return ERROR_FAIL; +} + +int libxl_psr_get_val(libxl_ctx *ctx, uint32_t domid, + libxl_psr_type type, unsigned int target, + uint64_t *val) +{ + return ERROR_FAIL; +} + +int libxl_psr_get_hw_info(libxl_ctx *ctx, libxl_psr_feat_type type, + unsigned int lvl, unsigned int *nr, + libxl_psr_hw_info **info) +{ + return ERROR_FAIL; +} + +void libxl_psr_hw_info_list_free(libxl_psr_hw_info *list, unsigned int nr) +{ +} + /* * Local variables: * mode: C diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl index 2d0bb8a..b05f10b 100644 --- a/tools/libxl/libxl_types.idl +++ b/tools/libxl/libxl_types.idl @@ -1032,6 +1032,7 @@ libxl_psr_cbm_type = Enumeration("psr_cbm_type", [ (2, "L3_CBM_CODE"), (3, "L3_CBM_DATA"), (4, "L2_CBM"), + (5, "MBA_THRTL"), ]) libxl_psr_cat_info = Struct("psr_cat_info", [ @@ -1040,3 +1041,24 @@ libxl_psr_cat_info = Struct("psr_cat_info", [ ("cbm_len", uint32), ("cdp_enabled", bool), ]) + +libxl_psr_feat_type = Enumeration("psr_feat_type", [ + (1, "CAT"), + (2, "MBA"), + ]) + +libxl_psr_hw_info = Struct("psr_hw_info", [ + ("id", uint32), + ("u", KeyedUnion(None, libxl_psr_feat_type, "type", + [("cat", Struct(None, [ + ("cos_max", uint32), + ("cbm_len", uint32), + ("cdp_enabled", bool), + ])), + ("mba", Struct(None, [ + ("cos_max", uint32), + ("thrtl_max", uint32), + ("linear", bool), + ])), + ])) + ], dir=DIR_OUT)