From patchwork Tue May 5 08:15:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 11528389 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 721F51392 for ; Tue, 5 May 2020 08:16:16 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5887D2068E for ; Tue, 5 May 2020 08:16:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5887D2068E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jVsjl-0004IC-6m; Tue, 05 May 2020 08:15:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jVsjj-0004Ht-LX for xen-devel@lists.xenproject.org; Tue, 05 May 2020 08:15:31 +0000 X-Inumbo-ID: 95217967-8ea8-11ea-9d93-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 95217967-8ea8-11ea-9d93-12813bfff9fa; Tue, 05 May 2020 08:15:31 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 5B5A9AFF0; Tue, 5 May 2020 08:15:32 +0000 (UTC) Subject: [PATCH v8 06/12] x86/HVM: make hvmemul_blk() capable of handling r/o operations From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <60cc730f-2a1c-d7a6-74fe-64f3c9308831@suse.com> Message-ID: <1587789a-b0d6-6d18-99fc-a94bbea52d7b@suse.com> Date: Tue, 5 May 2020 10:15:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <60cc730f-2a1c-d7a6-74fe-64f3c9308831@suse.com> Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Paul Durrant , Wei Liu , Roger Pau Monne Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" In preparation for handling e.g. FLDENV or {F,FX,X}RSTOR here as well. Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant --- v8: New (could be folded into "x86emul: support MOVDIR{I,64B} insns", but would invalidate Paul's R-b there). --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -1453,7 +1453,7 @@ static int hvmemul_blk( struct hvm_emulate_ctxt *hvmemul_ctxt = container_of(ctxt, struct hvm_emulate_ctxt, ctxt); unsigned long addr; - uint32_t pfec = PFEC_page_present | PFEC_write_access; + uint32_t pfec = PFEC_page_present; int rc; void *mapping = NULL; @@ -1462,6 +1462,9 @@ static int hvmemul_blk( if ( rc != X86EMUL_OKAY || !bytes ) return rc; + if ( x86_insn_is_mem_write(state, ctxt) ) + pfec |= PFEC_write_access; + if ( is_x86_system_segment(seg) ) pfec |= PFEC_implicit; else if ( hvmemul_ctxt->seg_reg[x86_seg_ss].dpl == 3 )