From patchwork Mon Mar 18 11:53:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13595318 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3B41C54E58 for ; Mon, 18 Mar 2024 11:54:21 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.694616.1083559 (Exim 4.92) (envelope-from ) id 1rmBZA-0002z3-Um; Mon, 18 Mar 2024 11:54:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 694616.1083559; Mon, 18 Mar 2024 11:54:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rmBZA-0002xt-Nl; Mon, 18 Mar 2024 11:54:08 +0000 Received: by outflank-mailman (input) for mailman id 694616; Mon, 18 Mar 2024 11:54:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rmBZ8-0001F3-PA for xen-devel@lists.xenproject.org; Mon, 18 Mar 2024 11:54:06 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 38e8a27b-e51e-11ee-afdd-a90da7624cb6; Mon, 18 Mar 2024 12:54:06 +0100 (CET) Received: from nico.bugseng.com (unknown [46.228.253.194]) by support.bugseng.com (Postfix) with ESMTPSA id 338494EE074B; Mon, 18 Mar 2024 12:54:05 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38e8a27b-e51e-11ee-afdd-a90da7624cb6 From: Nicola Vetrini To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: [XEN PATCH 09/10] xen/wait: address violations of MISRA C Rule 20.7 Date: Mon, 18 Mar 2024 12:53:52 +0100 Message-Id: <1d9f79590a224b4007f34a609b8024b36dd44a04.1710762555.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter the semantics of the passed-in macro parameter. No functional change. Signed-off-by: Nicola Vetrini Acked-by: Jan Beulich --- xen/include/xen/wait.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/include/xen/wait.h b/xen/include/xen/wait.h index 6eb7667d9c7f..1c68bc564b09 100644 --- a/xen/include/xen/wait.h +++ b/xen/include/xen/wait.h @@ -40,12 +40,12 @@ do { \ if ( condition ) \ break; \ for ( ; ; ) { \ - prepare_to_wait(&wq); \ + prepare_to_wait(&(wq)); \ if ( condition ) \ break; \ wait(); \ } \ - finish_wait(&wq); \ + finish_wait(&(wq)); \ } while (0) /* Private functions. */