From patchwork Thu Feb 11 11:38:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Faggioli X-Patchwork-Id: 8277961 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D3E059F88A for ; Thu, 11 Feb 2016 11:41:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6500820373 for ; Thu, 11 Feb 2016 11:41:32 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DF482035D for ; Thu, 11 Feb 2016 11:41:31 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aTpaF-0005to-BC; Thu, 11 Feb 2016 11:38:51 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aTpaD-0005tU-LC for xen-devel@lists.xenproject.org; Thu, 11 Feb 2016 11:38:49 +0000 Received: from [85.158.137.68] by server-8.bemta-3.messagelabs.com id 33/1A-24375-8C27CB65; Thu, 11 Feb 2016 11:38:48 +0000 X-Env-Sender: raistlin.df@gmail.com X-Msg-Ref: server-7.tower-31.messagelabs.com!1455190728!14241504!1 X-Originating-IP: [74.125.82.68] X-SpamReason: No, hits=0.2 required=7.0 tests=RCVD_ILLEGAL_IP, UPPERCASE_25_50 X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 19314 invoked from network); 11 Feb 2016 11:38:48 -0000 Received: from mail-wm0-f68.google.com (HELO mail-wm0-f68.google.com) (74.125.82.68) by server-7.tower-31.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 11 Feb 2016 11:38:48 -0000 Received: by mail-wm0-f68.google.com with SMTP id g62so10139513wme.2 for ; Thu, 11 Feb 2016 03:38:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:from:to:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding; bh=/3jZW5togwjlDRV5dc7pQKQwgzxDt5aGTIlhElg/D6U=; b=Cbn8MctyBSiJ1oyHmYrA1JbkArWxmcq3hqyOm1YkD1u82i3ALsH05aevUerCL2kvuH LI+IPSGiG4/u9m4lFBEnDaETeb5YouA6jX9B6JPgWWrwpsCZAIZsQy505YIK4oQvneaj J2u8cfTqAQzUNawr1EslMToV2gYIuW/pnYRwDXoPinXlJYzE7azFXr4in9mQ67X8nbst pisMfRP0GK6RTzupwDc8jrPLLzEcz4F4VkU0rAw2iQ/FXg+/mFhzR34HDvyAxS6mnqWj In7VTOCHIJnKpSQ8dBg9bSiOPVbQ33PyChN0izxXJqWOB8B5EHF+V0vXXQQC9RxNMgra LG+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:from:to:cc:date:message-id :in-reply-to:references:user-agent:mime-version:content-type :content-transfer-encoding; bh=/3jZW5togwjlDRV5dc7pQKQwgzxDt5aGTIlhElg/D6U=; b=hgDKTxH6nsuPz/wZnsN//p5O+zlagG1h+h80Ob+raAiGggcduWSAxTksByM4BaRhIF lawsAE6AP0+Sxf8loCEMQQ6MH7jnq1PstnrK/OkuJGORH6CzG7qom2hwGpnKC5bb1SNh v7opi1GCUEznFOfpTTR/vVCKXVESVjjew6ig2ZwA4A7SXk4/4BN7BM2r/4lxycvjGEDh rvJGRDuSV8IIY78ryJLEb1RdwmTxF6kRpk8ZJaoDBfyUOpFmfxGro24ZOlyNWCtkO8o6 nROCxMTNRCq+o71GX8iByRv+dIySPBWm6hdKWXwd0nuTN4u7+gXupuiXnd2SFU5L2fAl 23EA== X-Gm-Message-State: AG10YORi2z6AGoiL56vB6exEROXs7jLS624RbMgTMFKOcp9mVEpfzJeZLGqEOwCu0iM93A== X-Received: by 10.194.94.138 with SMTP id dc10mr53581239wjb.37.1455190728219; Thu, 11 Feb 2016 03:38:48 -0800 (PST) Received: from Solace.station (net-2-35-170-8.cust.vodafonedsl.it. [2.35.170.8]) by smtp.gmail.com with ESMTPSA id gg7sm7204990wjd.10.2016.02.11.03.38.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Feb 2016 03:38:47 -0800 (PST) From: Dario Faggioli To: xen-devel@lists.xenproject.org Date: Thu, 11 Feb 2016 12:38:45 +0100 Message-ID: <20160211113845.20959.87679.stgit@Solace.station> In-Reply-To: <20160211113321.20959.53804.stgit@Solace.station> References: <20160211113321.20959.53804.stgit@Solace.station> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Cc: George Dunlap Subject: [Xen-devel] [PATCH 1/3] xen: credit1: trace vCPU boost/unboost X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add tracepoints and a performance counter for boosting and unboosting in Credit1. Note that they (the trace points) do not cover the case of the idle vCPU being boosted to run a tasklet, as there already is TRC_CSCHED_SCHED_TASKLET for that. Signed-off-by: Dario Faggioli --- Cc: George Dunlap --- xen/common/sched_credit.c | 8 ++++++++ xen/include/xen/perfc_defn.h | 1 + 2 files changed, 9 insertions(+) diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c index 671bbee..5708701 100644 --- a/xen/common/sched_credit.c +++ b/xen/common/sched_credit.c @@ -126,6 +126,8 @@ #define TRC_CSCHED_STOLEN_VCPU TRC_SCHED_CLASS_EVT(CSCHED, 4) #define TRC_CSCHED_PICKED_CPU TRC_SCHED_CLASS_EVT(CSCHED, 5) #define TRC_CSCHED_TICKLE TRC_SCHED_CLASS_EVT(CSCHED, 6) +#define TRC_CSCHED_BOOST_START TRC_SCHED_CLASS_EVT(CSCHED, 7) +#define TRC_CSCHED_BOOST_END TRC_SCHED_CLASS_EVT(CSCHED, 8) /* @@ -856,7 +858,11 @@ csched_vcpu_acct(struct csched_private *prv, unsigned int cpu) * amount of CPU resources and should no longer be boosted. */ if ( svc->pri == CSCHED_PRI_TS_BOOST ) + { svc->pri = CSCHED_PRI_TS_UNDER; + TRACE_2D(TRC_CSCHED_BOOST_END, svc->sdom->dom->domain_id, + svc->vcpu->vcpu_id); + } /* * Update credits @@ -1023,6 +1029,8 @@ csched_vcpu_wake(const struct scheduler *ops, struct vcpu *vc) if ( svc->pri == CSCHED_PRI_TS_UNDER && !test_bit(CSCHED_FLAG_VCPU_PARKED, &svc->flags) ) { + TRACE_2D(TRC_CSCHED_BOOST_START, vc->domain->domain_id, vc->vcpu_id); + SCHED_STAT_CRANK(vcpu_boost); svc->pri = CSCHED_PRI_TS_BOOST; } diff --git a/xen/include/xen/perfc_defn.h b/xen/include/xen/perfc_defn.h index 76ee803..21c1e0b 100644 --- a/xen/include/xen/perfc_defn.h +++ b/xen/include/xen/perfc_defn.h @@ -40,6 +40,7 @@ PERFCOUNTER(acct_reorder, "csched: acct_reorder") PERFCOUNTER(acct_min_credit, "csched: acct_min_credit") PERFCOUNTER(acct_vcpu_active, "csched: acct_vcpu_active") PERFCOUNTER(acct_vcpu_idle, "csched: acct_vcpu_idle") +PERFCOUNTER(vcpu_boost, "csched: vcpu_boost") PERFCOUNTER(vcpu_park, "csched: vcpu_park") PERFCOUNTER(vcpu_unpark, "csched: vcpu_unpark") PERFCOUNTER(load_balance_idle, "csched: load_balance_idle")